Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

Hi, This version fixes the cstr leak and explicitly frees tmp when allocating cookies fails. Freeing tmp also means we don't need to free *cookies when ret is less than zero. I've also formatted the name properly, so it'll show up as a new thread. Thanks in advance.

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On Wed, Apr 26, 2017 at 09:48:09PM -0400, Micah Galizia wrote: > Signed-off-by: Micah Galizia > --- > libavformat/http.c | 212 > +++-- > 1 file changed, 155 insertions(+), 57 deletions(-) forgot to mention the commit

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On Wed, Apr 26, 2017 at 09:48:09PM -0400, Micah Galizia wrote: > Signed-off-by: Micah Galizia > --- > libavformat/http.c | 212 > +++-- > 1 file changed, 155 insertions(+), 57 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

Thanks for the review, new fix checks av_dict_set return. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Ignore expired cookies

Signed-off-by: Micah Galizia --- libavformat/http.c | 212 +++-- 1 file changed, 155 insertions(+), 57 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 293a8a7204..58fc3902ab 100644 ---

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On Sat, Apr 08, 2017 at 09:05:46PM -0400, Micah Galizia wrote: > Signed-off-by: Micah Galizia > --- > libavformat/http.c | 211 > ++--- > 1 file changed, 154 insertions(+), 57 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On 2017-04-08 09:05 PM, Micah Galizia wrote: Is there something I can do to get this reviewed? Thanks in advance. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On 2017-04-08 09:05 PM, Micah Galizia wrote: Signed-off-by: Micah Galizia Hello, Has anyone had a chance to review this? I was hoping to get the rework (if needed) done this weekend. Thanks, ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] Ignore expired cookies

Signed-off-by: Micah Galizia --- libavformat/http.c | 211 ++--- 1 file changed, 154 insertions(+), 57 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 293a8a7204..425711aab5 100644 ---

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

Hi Nicolas! On 2017-03-30 22:12 +0200, Nicolas George wrote: > Le decadi 10 germinal, an CCXXV, Alexander Strasser a écrit : > > If expiry is zero terminated and you are going through it one byte at a > > time, > > you could omit the strlen call and just check if expiry[i] is non zero. > > > >

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

Thanks for those comments -- I'll get rid of the strlen in the upcoming patch but, Nicolas, you lost me there. Anyway, this patch only does half the job -- I have a new one that is unfortunately larger, but has taken prior advice to break cookies into dicts. On Thu, Mar 30, 2017 at 4:12 PM,

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

Le decadi 10 germinal, an CCXXV, Alexander Strasser a écrit : > If expiry is zero terminated and you are going through it one byte at a time, > you could omit the strlen call and just check if expiry[i] is non zero. > > It's maybe the more common idiom too. On the other hand, code that does not

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

Hi! On 2017-03-29 19:42 -0400, Micah Galizia wrote: > I'm going to have to submit a v2 for this patch (hopefully soon) -- > this version only accomplishes half the job: not sending expired > cookies. The change should also prevent storing them in the first > place. > > Regardless, thanks for

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

Hi, I'm going to have to submit a v2 for this patch (hopefully soon) -- this version only accomplishes half the job: not sending expired cookies. The change should also prevent storing them in the first place. Regardless, thanks for your help on this one. On Sat, Mar 25, 2017 at 7:27 PM, Micah

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On Sat, Mar 25, 2017 at 10:51 AM, wm4 wrote: > This can overflow sizeof(exp_buf). Sorry, new patch cleans that up. >> + >> +// move the string beyond the day of week >> +i = 0; >> +while ((exp_buf[i] < '0' || exp_buf[i] >

[FFmpeg-devel] [PATCH] Ignore expired cookies

Signed-off-by: Micah Galizia --- libavformat/http.c | 43 +++ 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 293a8a7..53fae2a 100644 --- a/libavformat/http.c +++

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On Sat, 25 Mar 2017 10:31:00 -0400 Micah Galizia wrote: > Signed-off-by: Micah Galizia > --- > libavformat/http.c | 43 +++ > 1 file changed, 39 insertions(+), 4 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH] Ignore expired cookies

Signed-off-by: Micah Galizia --- libavformat/http.c | 43 +++ 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 293a8a7..f7d1925 100644 --- a/libavformat/http.c +++

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On 2017-03-25 07:11 AM, wm4 wrote: >> -while ((param = av_strtok(cookie, "; ", _param))) { >> +while ((param = av_strtok(cookie, ";", _param))) { >> + >> +// move past any leading whitespace >> +param += strspn(param, WHITESPACES); >> + > Not quite sure

[FFmpeg-devel] [PATCH] Ignore expired cookies

Signed-off-by: Micah Galizia --- libavformat/http.c | 41 + 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 293a8a7..37bdacf 100644 --- a/libavformat/http.c +++

[FFmpeg-devel] [PATCH] Ignore expired cookies

Hi, This is my second attempt at fixing how we are handling expired cookies. As a reminder, on some authenticated Neulion streams, they send a cookie from the past, like so: Set-Cookie: nlqptid=""; Domain=.neulion.com; Expires=Thu, 01-Jan-1970 00:00:10 GMT; Path=/ These expired cookies are

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

On Sun, Feb 12, 2017 at 6:28 AM, Nicolas George wrote: > Thanks for the patch. See remarks below. > > Le tridi 23 pluviôse, an CCXXV, Micah Galizia a écrit : >> On some authenticated Neulion streams, they send a cookie from the past, >> like so: >> >> Set-Cookie: nlqptid="";

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

Thanks for the patch. See remarks below. Le tridi 23 pluviôse, an CCXXV, Micah Galizia a écrit : > On some authenticated Neulion streams, they send a cookie from the past, > like so: > > Set-Cookie: nlqptid=""; Domain=.neulion.com; Expires=Thu, 01-Jan-1970 > 00:00:10 GMT; Path=/ > > As a

[FFmpeg-devel] [PATCH] Ignore expired cookies

--- libavformat/http.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 944a6cf..24368aa 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -682,12 +682,46 @@ static int

[FFmpeg-devel] [PATCH] Ignore expired cookies

This one fixes the memory leak -- sorry for all the spam. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Ignore expired cookies

Signed-off-by: Micah Galizia --- libavformat/http.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 944a6cf..e7b8ac3 100644 --- a/libavformat/http.c +++

[FFmpeg-devel] [PATCH] Ignore expired cookies

Appologies, gmail screwed up the patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Ignore expired cookies

Hello, On some authenticated Neulion streams, they send a cookie from the past, like so: Set-Cookie: nlqptid=""; Domain=.neulion.com; Expires=Thu, 01-Jan-1970 00:00:10 GMT; Path=/ As a result, the good cookie value is overwritten and authentication breaks immediately. I realise disqualifying a