[FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-15 Thread Mats Peterson
Here is a *suggestion* for how to end the QuickTime palette in Matroska saga. I have created a new file 'qtpalette.c' with a function get_qtpalette(), that will be called from both matroskadec.c and mov.c. So, no more calling into another demuxer to get the palette, and no duplicated code, sinc

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-15 Thread Mats Peterson
On 12/15/2015 06:51 PM, Mats Peterson wrote: Here is a *suggestion* for how to end the QuickTime palette in Matroska saga. I have created a new file 'qtpalette.c' with a function get_qtpalette(), that will be called from both matroskadec.c and mov.c. So, no more calling into another demuxer to ge

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/15/2015 07:25 PM, Mats Peterson wrote: On 12/15/2015 06:51 PM, Mats Peterson wrote: Here is a *suggestion* for how to end the QuickTime palette in Matroska saga. I have created a new file 'qtpalette.c' with a function get_qtpalette(), that will be called from both matroskadec.c and mov.c.

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/16/2015 06:07 PM, Mats Peterson wrote: On 12/15/2015 07:25 PM, Mats Peterson wrote: On 12/15/2015 06:51 PM, Mats Peterson wrote: Here is a *suggestion* for how to end the QuickTime palette in Matroska saga. I have created a new file 'qtpalette.c' with a function get_qtpalette(), that will

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Lou Logan
On Wed, 16 Dec 2015 18:13:01 +0100, Mats Peterson wrote: > I forgot to remove a "fprintf(stderr, "COLOR COUNT: %d\n", > color_count);" line in qtpalette.c, but it's easy to find. This will just make people ignore the patch because we don't have enough time to update your patch for you. Please pr

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/16/2015 07:15 PM, Lou Logan wrote: On Wed, 16 Dec 2015 18:13:01 +0100, Mats Peterson wrote: I forgot to remove a "fprintf(stderr, "COLOR COUNT: %d\n", color_count);" line in qtpalette.c, but it's easy to find. This will just make people ignore the patch because we don't have enough time

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/16/2015 07:18 PM, Mats Peterson wrote: On 12/16/2015 07:15 PM, Lou Logan wrote: On Wed, 16 Dec 2015 18:13:01 +0100, Mats Peterson wrote: I forgot to remove a "fprintf(stderr, "COLOR COUNT: %d\n", color_count);" line in qtpalette.c, but it's easy to find. This will just make people igno

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Lou Logan
On Wed, 16 Dec 2015 19:18:33 +0100, Mats Peterson wrote: > If you can create a proper patchset out of the archive, you can remove > that single line. That will not happen. > It's unnecessary for me to upload a new archive with such a small > change. It's a whole new file, at that. Another reas

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/16/2015 07:45 PM, Lou Logan wrote: On Wed, 16 Dec 2015 19:18:33 +0100, Mats Peterson wrote: If you can create a proper patchset out of the archive, you can remove that single line. That will not happen. It's unnecessary for me to upload a new archive with such a small change. It's a w

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/16/2015 07:52 PM, Mats Peterson wrote: On 12/16/2015 07:45 PM, Lou Logan wrote: On Wed, 16 Dec 2015 19:18:33 +0100, Mats Peterson wrote: If you can create a proper patchset out of the archive, you can remove that single line. That will not happen. It's unnecessary for me to upload a

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Kieran Kunhya
> I have said before that I'm not going to dwell into the complexities of Git, > since it feels about as wasteful as programming a GUI in my book. If you > can't accept the patches in their current format, so be it. Thanks for your > time and understanding. We accept git patches here and that's th

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, since it feels about as wasteful as programming a GUI in my book. If you can't accept the patches in their current format, so be it. Thanks for your time and understanding.

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/16/2015 08:27 PM, Mats Peterson wrote: On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, since it feels about as wasteful as programming a GUI in my book. If you can't accept the patches in their current format, so be

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Stephan Holljes
On Wed, Dec 16, 2015 at 8:30 PM, Mats Peterson wrote: > On 12/16/2015 08:27 PM, Mats Peterson wrote: >> >> On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, since it feels about as wasteful as programming a

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Tomas Härdin
On Wed, 2015-12-16 at 20:30 +0100, Mats Peterson wrote: > On 12/16/2015 08:27 PM, Mats Peterson wrote: > > On 12/16/2015 08:26 PM, Kieran Kunhya wrote: > >>> I have said before that I'm not going to dwell into the complexities > >>> of Git, > >>> since it feels about as wasteful as programming a GU

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Mats Peterson
On 12/16/2015 08:30 PM, Mats Peterson wrote: On 12/16/2015 08:27 PM, Mats Peterson wrote: On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, since it feels about as wasteful as programming a GUI in my book. If you can't acce

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-17 Thread Paul B Mahol
On 12/17/15, Mats Peterson wrote: > On 12/16/2015 08:30 PM, Mats Peterson wrote: >> On 12/16/2015 08:27 PM, Mats Peterson wrote: >>> On 12/16/2015 08:26 PM, Kieran Kunhya wrote: > I have said before that I'm not going to dwell into the complexities > of Git, > since it feels about as w

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-17 Thread Mats Peterson
On 12/17/2015 09:31 AM, Paul B Mahol wrote: On 12/17/15, Mats Peterson wrote: On 12/16/2015 08:30 PM, Mats Peterson wrote: On 12/16/2015 08:27 PM, Mats Peterson wrote: On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, si

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-17 Thread Mats Peterson
On 12/17/2015 11:53 AM, Mats Peterson wrote: On 12/17/2015 09:31 AM, Paul B Mahol wrote: On 12/17/15, Mats Peterson wrote: On 12/16/2015 08:30 PM, Mats Peterson wrote: On 12/16/2015 08:27 PM, Mats Peterson wrote: On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not g

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-17 Thread Paul B Mahol
On 12/17/15, Mats Peterson wrote: > On 12/17/2015 11:53 AM, Mats Peterson wrote: >> On 12/17/2015 09:31 AM, Paul B Mahol wrote: >>> On 12/17/15, Mats Peterson wrote: On 12/16/2015 08:30 PM, Mats Peterson wrote: > On 12/16/2015 08:27 PM, Mats Peterson wrote: >> On 12/16/2015 08:26 PM,

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-17 Thread Lou Logan
On Thu, 17 Dec 2015 07:58:27 +0100, Mats Peterson wrote: > And based on Michael Niedermayer's statement regarding the goal of > having FFmpeg "support all kinds of odd and broken files", why aren't > you people more interested in fixing this long-standing issue regarding > palettized QuickTime