Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread wm4
On Tue, 18 Apr 2017 16:01:48 +0200 Michael Niedermayer wrote: > On Tue, Apr 18, 2017 at 03:47:29PM +0200, Nicolas George wrote: > > Le nonidi 29 germinal, an CCXXV, Michael Niedermayer a écrit : > > > This contradicts the documentation: (and would be rather rigid

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Michael Niedermayer
On Tue, Apr 18, 2017 at 04:08:43PM +0200, Nicolas George wrote: > Le nonidi 29 germinal, an CCXXV, Michael Niedermayer a écrit : > > Iam not sure you did read the text the patch changes > > I am replying to the issue about threading. ok, iam trying to stay with the topic of this thread which was

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Nicolas George
Le nonidi 29 germinal, an CCXXV, Michael Niedermayer a écrit : > Iam not sure you did read the text the patch changes I am replying to the issue about threading. If you find the documentation inconsistent, your commit message must be changed. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Michael Niedermayer
On Tue, Apr 18, 2017 at 03:47:29PM +0200, Nicolas George wrote: > Le nonidi 29 germinal, an CCXXV, Michael Niedermayer a écrit : > > This contradicts the documentation: (and would be rather rigid design) > > Possible. But it has nothing to do with threading. > > > > threaded decoder will just

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Nicolas George
Le nonidi 29 germinal, an CCXXV, Michael Niedermayer a écrit : > This contradicts the documentation: (and would be rather rigid design) Possible. But it has nothing to do with threading. > > threaded decoder will just start the work and return EAGAIN. > Thats true but this is not permitted by

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Michael Niedermayer
On Tue, Apr 18, 2017 at 03:23:14PM +0200, Nicolas George wrote: > Le nonidi 29 germinal, an CCXXV, Michael Niedermayer a écrit : > > if you cannot send a new packet before you received the output of > > the previous > > You have to TRY TO receive the output before you send a new packet. A This

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Nicolas George
Le nonidi 29 germinal, an CCXXV, Michael Niedermayer a écrit : > if you cannot send a new packet before you received the output of > the previous You have to TRY TO receive the output before you send a new packet. A threaded decoder will just start the work and return EAGAIN. Regards, --

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Michael Niedermayer
On Tue, Apr 18, 2017 at 02:14:47PM +0200, wm4 wrote: > On Tue, 18 Apr 2017 13:30:43 +0200 > Michael Niedermayer wrote: > > > On Tue, Apr 18, 2017 at 06:43:07AM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Tue, Apr 18, 2017 at 6:31 AM, Michael Niedermayer > >

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread wm4
On Tue, 18 Apr 2017 13:30:43 +0200 Michael Niedermayer wrote: > On Tue, Apr 18, 2017 at 06:43:07AM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Apr 18, 2017 at 6:31 AM, Michael Niedermayer > > > > wrote: > > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Michael Niedermayer
On Tue, Apr 18, 2017 at 06:43:07AM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, Apr 18, 2017 at 6:31 AM, Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avcodec.h | 2 +- > > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread wm4
On Tue, 18 Apr 2017 12:31:25 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Ronald S. Bultje
Hi, On Tue, Apr 18, 2017 at 6:31 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding

2017-04-18 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ee133712b5..2ac1523a36 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4960,7