Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-07-03 Thread Zivkovic, Milos
Thanks. Regards, Milos On Fri, Jul 3, 2020 at 12:55 AM Marton Balint wrote: > > > > On Sun, 28 Jun 2020, Marton Balint wrote: > > > > > > > On Mon, 22 Jun 2020, Zivkovic, Milos wrote: > > > >> Hello, > >> > >> I've attached another patch with the latest changes. > >> Sorry for sending it as an a

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-07-02 Thread Marton Balint
On Sun, 28 Jun 2020, Marton Balint wrote: On Mon, 22 Jun 2020, Zivkovic, Milos wrote: Hello, I've attached another patch with the latest changes. Sorry for sending it as an attachment again, I'll figure something out for the future patches. Anyhow, this patch removes the reordering and t

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-28 Thread Marton Balint
On Mon, 22 Jun 2020, Zivkovic, Milos wrote: Hello, I've attached another patch with the latest changes. Sorry for sending it as an attachment again, I'll figure something out for the future patches. Anyhow, this patch removes the reordering and the unused HANC constant. It also checks if PSC

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-22 Thread Zivkovic, Milos
Hello, I've attached another patch with the latest changes. Sorry for sending it as an attachment again, I'll figure something out for the future patches. Anyhow, this patch removes the reordering and the unused HANC constant. It also checks if PSC is in order and renames the option to "enable_kl

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-18 Thread Zivkovic, Milos
Hello, > Please in the future send patches as in-line rather than attachments. git send-email wasn't working for this email. I attached the patch only after asking on #ffmpeg-devel IRC channel if it was okay. Is simply pasting the patch contents enough? > This is referencing the incorrect specif

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-17 Thread Devin Heitmueller
Hello Milos, A few additional comments in addition to what Marton found. Please in the future send patches as in-line rather than attachments. On Sun, Jun 14, 2020 at 10:27 AM Marton Balint wrote: > > > On Tue, 9 Jun 2020, Zivkovic, Milos wrote: > > > Hello, > > > > I've attached a patch that a

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-17 Thread Zivkovic, Milos
Hello, I've attached a new patch with the proposed changes. Thanks, Milos 0001-avdevice-decklink_dec-extracting-and-outputing-klv.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-15 Thread Zivkovic, Milos
> > > Thanks, I found the issue. > Glad to hear it. Regards, Milos On Mon, Jun 15, 2020 at 10:58 PM Marton Balint wrote: > > > On Mon, 15 Jun 2020, Zivkovic, Milos wrote: > > > I'll submit the patch with the proposed changes once that build issue is > > resolved. > > > > I'm not having any bu

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-15 Thread Marton Balint
On Mon, 15 Jun 2020, Zivkovic, Milos wrote: I'll submit the patch with the proposed changes once that build issue is resolved. I'm not having any build issues on multiple compilers, and there's one really weird error in the log that you shared. In file included from /usr/include/c++/7/ext/ne

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-15 Thread Zivkovic, Milos
I'll submit the patch with the proposed changes once that build issue is resolved. I'm not having any build issues on multiple compilers, and there's one really weird error in the log that you shared. In file included from /usr/include/c++/7/ext/new_allocator.h:33:0, > from > /us

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-15 Thread Marton Balint
On Mon, 15 Jun 2020, Zivkovic, Milos wrote: Hello, I appreciate the comments. Missing docs for the new option. Does this refer to .texi files? I'll update the docs. Yes. Avoid these if possible. Yes, this is C++ code but only because the decklink API requires it. Also it gives me

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-15 Thread Zivkovic, Milos
Hello, I appreciate the comments. Missing docs for the new option. > Does this refer to .texi files? I'll update the docs. > Avoid these if possible. Yes, this is C++ code but only because the > decklink > API requires it. Also it gives me a compile error, and I am not familiar > enough > with

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-14 Thread Marton Balint
On Tue, 9 Jun 2020, Zivkovic, Milos wrote: Hello, I've attached a patch that adds support for extraction of KLV data from SDI VANC. Code is enabled with a special *output_klv* option and is otherwise unused. This was tested with an off the shelf UDP -> SDI decoder that preserves KLV and inser

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-09 Thread Zivkovic, Milos
Hello, I've attached a patch that adds support for extraction of KLV data from SDI VANC. Code is enabled with a special *output_klv* option and is otherwise unused. This was tested with an off the shelf UDP -> SDI decoder that preserves KLV and inserts them in VANC, following the guidelines in MI