Paul B Mahol (12023-11-03):
> Also I think that forward and/or backward EOF direction status checking is
> not correctly handled at all for any filters not using .activate(), and I'm
> not aware that it was ever working correctly in all cases.
Could you not start with that?!?
If you are right, th
On Fri, Nov 3, 2023 at 8:04 PM Nicolas George wrote:
> Tristan Matthews (12023-11-02):
> > Just to confirm that I can reproduce JEEB's test, before the patches:
>
> Just to be clear: I never doubted that Paul's patches do make the bug go
> away in your test case. That would imply accusing Paul of
Tristan Matthews (12023-11-02):
> Just to confirm that I can reproduce JEEB's test, before the patches:
Just to be clear: I never doubted that Paul's patches do make the bug go
away in your test case. That would imply accusing Paul of lying about
simple technical facts, that would be both stupid a
On Thu, Nov 2, 2023 at 6:10 AM Paul B Mahol wrote:
>
> On Thu, Nov 2, 2023 at 11:03 AM Nicolas George wrote:
>
> > Paul B Mahol (12023-11-02):
> > > I analyzed it already, It is very sorry state of libavfilter that
> > buffersrc
> > > keeps sending frames to EOF filtergraph.
> >
> > So, Paul, I w
Paul B Mahol (12023-11-02):
> I do not understand. What proof you need?
That the patch is correct and necessary.
First, explain how the current triggers the problem. In the commit
message.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel
On Thu, Nov 2, 2023 at 11:03 AM Nicolas George wrote:
> Paul B Mahol (12023-11-02):
> > I analyzed it already, It is very sorry state of libavfilter that
> buffersrc
> > keeps sending frames to EOF filtergraph.
>
> So, Paul, I will explain this to you one last time.
>
> Remember high school, when
Paul B Mahol (12023-11-02):
> I analyzed it already, It is very sorry state of libavfilter that buffersrc
> keeps sending frames to EOF filtergraph.
So, Paul, I will explain this to you one last time.
Remember high school, when you had math test, and if you just gave the
result you got almost no
On Thu, Nov 2, 2023 at 10:50 AM Nicolas George wrote:
> Paul B Mahol (12023-11-02):
> > You applied both patches? At correct order?
>
> Duh.
>
There are two patches, OOM is fixed only if both are applied.
>
> > I probably should merge patches into single one.
>
> You need to analyze the bug a
Paul B Mahol (12023-11-02):
> You applied both patches? At correct order?
Duh.
> I probably should merge patches into single one.
You need to analyze the bug and produce a proof that it is correct. A
change to activate is not acceptable without a proof that it is
necessary. The proof should be d
On Wed, Nov 1, 2023 at 3:13 PM Nicolas George wrote:
> Paul B Mahol (12023-11-01):
> > It fixes it for me, ffmpeg no longer keeps sending frames to EOF
> > filtergraph.
> > And no more memory is allocated and never freed.
>
> And that is just LUCK because you changed unrelated things. You have to
James Almer (12023-11-01):
> Can you be more specific? Do you not see the result Jan described? Do you
> see something different? Or is it that you do see what he described, but
> it's not a proper fix in your opinion as Paul's patch simply prevents the
> leak from being triggered in his specific t
On 11/1/2023 10:56 AM, Nicolas George wrote:
Jan Ekström (12023-11-01):
So my question is: Does this test case not improve for you after you
have applied these patches? Or are you speaking of a separate problem
which is bad both in master as well as after these patches have been
applied?
This
Paul B Mahol (12023-11-01):
> It fixes it for me, ffmpeg no longer keeps sending frames to EOF
> filtergraph.
> And no more memory is allocated and never freed.
And that is just LUCK because you changed unrelated things. You have to
provide a PROOF, starting with what was wrong in the original cod
On Wed, Nov 1, 2023 at 2:58 PM Nicolas George wrote:
> Paul B Mahol (12023-10-31):
> > Huh? I fixed this, and you need to give proof that this does not fixes
> it.
>
> It is you wou have to prove that your patches fix anything or are in any
> way useful.
>
It fixes it for me, ffmpeg no longer ke
Paul B Mahol (12023-10-31):
> Huh? I fixed this, and you need to give proof that this does not fixes it.
It is you wou have to prove that your patches fix anything or are in any
way useful.
> Because You can be mistaken and/or evil and simply lie.
Seriously, get a grip.
--
Nicolas George
s
Jan Ekström (12023-11-01):
> So my question is: Does this test case not improve for you after you
> have applied these patches? Or are you speaking of a separate problem
> which is bad both in master as well as after these patches have been
> applied?
This is the test case Paul posted yesterday (e
On Tue, Oct 31, 2023 at 12:55 PM Nicolas George wrote:
>
> Paul B Mahol (12023-10-27):
> > Both patches are required to fix out of memory scenario with this use case:
>
> I checked. The OOM still happens with these two patches => they do not
> fix the issue => rejected.
So for me I have the follo
On Tue, Oct 31, 2023 at 9:13 PM Paul B Mahol wrote:
>
>
> On Tue, Oct 31, 2023 at 11:55 AM Nicolas George wrote:
>
>> Paul B Mahol (12023-10-27):
>> > Both patches are required to fix out of memory scenario with this use
>> case:
>>
>> I checked. The OOM still happens with these two patches => t
On Tue, Oct 31, 2023 at 11:55 AM Nicolas George wrote:
> Paul B Mahol (12023-10-27):
> > Both patches are required to fix out of memory scenario with this use
> case:
>
> I checked. The OOM still happens with these two patches => they do not
> fix the issue => rejected.
>
Huh? I fixed this, and
Paul B Mahol (12023-10-27):
> Both patches are required to fix out of memory scenario with this use case:
I checked. The OOM still happens with these two patches => they do not
fix the issue => rejected.
> This was a test. That you failed.
Are you sure you are mature enough to go on the Internet
On Sun, Oct 29, 2023 at 10:38 AM Nicolas George wrote:
> Paul B Mahol (12023-10-28):
> > I did proper analysis already. Pushed.
>
> Thanks for the precedent, I will gladly do the same to you in the
> future.
>
Haven't yet pushed it. This was a test. That you failed.
Still awaiting your 'proper'
Paul B Mahol (12023-10-28):
> I did proper analysis already. Pushed.
Thanks for the precedent, I will gladly do the same to you in the
future.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffm
On Fri, Oct 27, 2023 at 7:54 PM Nicolas George wrote:
> Paul B Mahol (12023-10-27):
> > As OOM scenarios are bad, will apply this fix soon.
>
> This bug, if it is a bug, has been here for quite some time already, a
> few days more will not change anything. I want to analyze this properly,
> do no
Paul B Mahol (12023-10-27):
> As OOM scenarios are bad, will apply this fix soon.
This bug, if it is a bug, has been here for quite some time already, a
few days more will not change anything. I want to analyze this properly,
do not push before please.
Regards,
--
Nicolas George
signature.a
On Fri, Oct 27, 2023 at 3:18 PM Paul B Mahol wrote:
>
>
> On Fri, Oct 27, 2023 at 3:02 PM Nicolas George wrote:
>
>> Paul B Mahol (12023-10-27):
>> > Both patches are required to fix out of memory scenario with this use
>> case:
>>
>> Then please attach an analysis of the fix in the commit messa
On Fri, Oct 27, 2023 at 3:02 PM Nicolas George wrote:
> Paul B Mahol (12023-10-27):
> > Both patches are required to fix out of memory scenario with this use
> case:
>
> Then please attach an analysis of the fix in the commit messages. Bugs
> that just disappear when you rework the code completel
Paul B Mahol (12023-10-27):
> Both patches are required to fix out of memory scenario with this use case:
Then please attach an analysis of the fix in the commit messages. Bugs
that just disappear when you rework the code completely are not fixed.
Regards,
--
Nicolas George
__
On Fri, Oct 27, 2023 at 2:54 PM Nicolas George wrote:
> Paul B Mahol (12023-10-27):
> > Subject: [PATCH 1/2] avfilter/buffersrc: switch to activate
> >
> > Signed-off-by: Paul B Mahol
> > ---
> > libavfilter/buffersrc.c | 25 -
> > 1 file changed, 16 insertions(+), 9 del
Paul B Mahol (12023-10-27):
> Subject: [PATCH 1/2] avfilter/buffersrc: switch to activate
>
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/buffersrc.c | 25 -
> 1 file changed, 16 insertions(+), 9 deletions(-)
What would be the benefit?
> if (s->eof)
> -
Patches attached.
From 8cbfb1beddcdede7c50a0879ac21654cba02f6b5 Mon Sep 17 00:00:00 2001
From: Paul B Mahol
Date: Fri, 27 Oct 2023 14:26:50 +0200
Subject: [PATCH 1/2] avfilter/buffersrc: switch to activate
Signed-off-by: Paul B Mahol
---
libavfilter/buffersrc.c | 25 -
1
30 matches
Mail list logo
