Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-12 Thread Tristan Matthews
On Tue, Apr 12, 2022 at 2:05 PM Paul B Mahol wrote: > On Tue, Apr 12, 2022 at 7:43 PM Tristan Matthews > wrote: > > > Hi, > > > > On Mon, Apr 11, 2022 at 2:02 PM Paul B Mahol wrote: > > > > > On Sat, Apr 9, 2022 at 9:21 PM Paul B Mahol wrote: > > > > > > > > > > > will apply soon > > > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-12 Thread Paul B Mahol
On Tue, Apr 12, 2022 at 7:43 PM Tristan Matthews wrote: > Hi, > > On Mon, Apr 11, 2022 at 2:02 PM Paul B Mahol wrote: > > > On Sat, Apr 9, 2022 at 9:21 PM Paul B Mahol wrote: > > > > > > > > will apply soon > > > > > > > > > Forgot to apply, will apply in next 24h. > > > > Am I missing

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-12 Thread Tristan Matthews
Hi, On Mon, Apr 11, 2022 at 2:02 PM Paul B Mahol wrote: > On Sat, Apr 9, 2022 at 9:21 PM Paul B Mahol wrote: > > > > > will apply soon > > > > > Forgot to apply, will apply in next 24h. > Am I missing something obvious or is there a default that's maybe not set? Getting: ./ffmpeg_g -loglevel

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-11 Thread Paul B Mahol
On Sat, Apr 9, 2022 at 9:21 PM Paul B Mahol wrote: > > will apply soon > Forgot to apply, will apply in next 24h. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-09 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-04-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 37 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/src_avsynctest.c | 401 +++ 4 files changed, 440 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-03-16 Thread Paul B Mahol
On Wed, Mar 16, 2022 at 9:08 PM Nicolas George wrote: > Paul B Mahol (12022-03-09): > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/Makefile | 1 + > > libavfilter/allfilters.c | 1 + > > libavfilter/src_avsynctest.c | 399 +++ > > 3

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-03-16 Thread Nicolas George
Paul B Mahol (12022-03-09): > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/src_avsynctest.c | 399 +++ > 3 files changed, 401 insertions(+) > create mode 100644

[FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-03-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/src_avsynctest.c | 399 +++ 3 files changed, 401 insertions(+) create mode 100644 libavfilter/src_avsynctest.c diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2020-03-12 Thread Nicolas George
Paul B Mahol (12020-03-12): > I changed my mind, I will not follow Nicolas advice at all. > Will apply this filter ASAP. > > I kindly ask Nicolas to stay away from my code for ever. This is not how it works. Re-send the patch for consideration by the whole project. -- Nicolas George

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2020-03-12 Thread Paul B Mahol
On 8/23/17, Nicolas George wrote: > Le sextidi 6 fructidor, an CCXXV, Paul B Mahol a écrit : >> I was asked multiple times to implement this filter. > > I was not referring to the advice of single users with a tunnel vision > of their own use case. > >> What framework? There is only framework for

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-23 Thread Nicolas George
Le sextidi 6 fructidor, an CCXXV, Paul B Mahol a écrit : > I was asked multiple times to implement this filter. I was not referring to the advice of single users with a tunnel vision of their own use case. > What framework? There is only framework for video source filter which > outputs static

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-23 Thread Paul B Mahol
On 8/23/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> You completely ignored and removed other aspects of my reply. > > You still are being vague. > >> Something special, like one can control both audio and video aspect at >> once and

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-23 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > You completely ignored and removed other aspects of my reply. You still are being vague. > Something special, like one can control both audio and video aspect at > once and provide same info to output. On the usability / convenience

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> I like idea of having single A/V filter to do this job, not combinations >> where >> users might become confused. > > I do not agree. Adding yet another filter causes confusion in

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > I like idea of having single A/V filter to do this job, not combinations where > users might become confused. I do not agree. Adding yet another filter causes confusion in itself. Not counting the extra boilerplate code (I suggest you

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> That is not delay between blink and beep. But video timestamps. > > Since the beeps happen every second, the delay is the fractional part, > or the remainder of the frame count divided

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > That is not delay between blink and beep. But video timestamps. Since the beeps happen every second, the delay is the fractional part, or the remainder of the frame count divided by the frame rate. But if you think this arithmetic is too

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> Sorry but where is that present? I nowhere can determine exact delay >> in number of frames versus sine beep. > > In the upper-left corner, you have a microsecond timestamp and a frame >

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > Sorry but where is that present? I nowhere can determine exact delay > in number of frames versus sine beep. In the upper-left corner, you have a microsecond timestamp and a frame counter. > It is not sine but testsrc2 one that would need

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> Exact delay in number of frames and that converted to milliseconds. > > Already present. I asked you if you tested, obviously you did not. Sorry but where is that present? I nowhere can

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > Exact delay in number of frames and that converted to milliseconds. Already present. I asked you if you tested, obviously you did not. > Also one can not set custom delay between beep and blink. I already mentioned that. You can propose a

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> How do you know when beep and blink should happen in your example? >> >> What is blink for testsrc2? Where in testsrc2 you can see delay in numeric >> form? > > Have you tried? You have

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > How do you know when beep and blink should happen in your example? > > What is blink for testsrc2? Where in testsrc2 you can see delay in numeric > form? Have you tried? You have a numeric timestamp and frame counter in the upper left

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> And how would you show delay introduced with video source filter? >> testsrc(2) does not show anything resembling that. > > I do not understand what you mean. The output of "ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > And how would you show delay introduced with video source filter? > testsrc(2) does not show anything resembling that. I do not understand what you mean. The output of "ffmpeg -lavfi 'testsrc2;sine'" looks functionally identical to the

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> So it is. So unless you tell what exactly you mean I can not help you. > > My bad. > >> testsrc(2) are useless for lipsync testing, when one needs to know >> exact time something is

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > So it is. So unless you tell what exactly you mean I can not help you. My bad. > testsrc(2) are useless for lipsync testing, when one needs to know > exact time something is played in wrong time. Yes, testsrc alone is not enough. But you

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> Try harder to explain what you think. > > This "filter" has no input. All similar "filters" are called sources and > implemented in files named accordingly. So it is. So unless you tell

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > Try harder to explain what you think. This "filter" has no input. All similar "filters" are called sources and implemented in files named accordingly. > If you actually tried you would know. I am sorry, but I do not accept that as an

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Paul B Mahol
On 8/19/17, Nicolas George wrote: > Le nonidi 29 thermidor, an CCXXV, Paul B Mahol a écrit : >> Hi, >> >> patch attached. > >> From 8d3876499b93e61ec1aec39adfc3c3be8d622464 Mon Sep 17 00:00:00 2001 >> From: Paul B Mahol >> Date: Fri, 28 Apr 2017 20:18:38 +0200

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-19 Thread Nicolas George
Le nonidi 29 thermidor, an CCXXV, Paul B Mahol a écrit : > Hi, > > patch attached. > From 8d3876499b93e61ec1aec39adfc3c3be8d622464 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Fri, 28 Apr 2017 20:18:38 +0200 > Subject: [PATCH] avfilter: add Audio Video Sync Test

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-17 Thread Paul B Mahol
On 8/17/17, Alex Giladi wrote: > Hi Paul, > Can you please point me to some information how this filter works? > Best, > Alex. How to run: mpv avdevice://lavfi:avsynctest[out1] Are you interested in something else? ___

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-16 Thread Alex Giladi
Hi Paul, Can you please point me to some information how this filter works? Best, Alex. On Wed, Aug 16, 2017 at 12:08 PM, Paul B Mahol wrote: > Hi, > > patch attached. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

[FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-16 Thread Paul B Mahol
Hi, patch attached. 0001-avfilter-add-Audio-Video-Sync-Test-filter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel