Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

Hi Marton, > On Feb 23, 2021, at 3:07 PM, Dave Rice wrote: > >> On Feb 23, 2021, at 2:42 PM, Marton Balint wrote: >> >> On Sat, 20 Feb 2021, Dave Rice wrote: >> >>> Hi, >>> On Oct 31, 2020, at 5:15 PM, Marton Balint >>> > wrote: On Sat, 31 Oct 2020, Dave Rice

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

> On Feb 23, 2021, at 2:42 PM, Marton Balint wrote: > > > > On Sat, 20 Feb 2021, Dave Rice wrote: > >> Hi, >> >>> On Oct 31, 2020, at 5:15 PM, Marton Balint >> > wrote: >>> On Sat, 31 Oct 2020, Dave Rice wrote: > On Oct 31, 2020, at 3:47 PM, Marton Balint

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Sat, 20 Feb 2021, Dave Rice wrote: Hi, On Oct 31, 2020, at 5:15 PM, Marton Balint mailto:c...@passwd.hu>> wrote: On Sat, 31 Oct 2020, Dave Rice wrote: On Oct 31, 2020, at 3:47 PM, Marton Balint mailto:c...@passwd.hu>> wrote: On Sat, 31 Oct 2020, Dave Rice wrote: Hi Marton, On Oct 31, 2

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

Hi, > On Oct 31, 2020, at 5:15 PM, Marton Balint > wrote: > On Sat, 31 Oct 2020, Dave Rice wrote: >>> On Oct 31, 2020, at 3:47 PM, Marton Balint >> > wrote: >>> On Sat, 31 Oct 2020, Dave Rice wrote: Hi Marton, > On Oct 31, 2020, at 12:56 PM,

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Sat, 5 Dec 2020, Michael Niedermayer wrote: On Sun, Nov 15, 2020 at 01:14:55AM +0100, Marton Balint wrote: On Fri, 6 Nov 2020, Michael Niedermayer wrote: On Wed, Nov 04, 2020 at 10:44:56PM +0100, Marton Balint wrote: On Wed, 4 Nov 2020, Michael Niedermayer wrote: we have "millisec

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Sun, Nov 15, 2020 at 01:14:55AM +0100, Marton Balint wrote: > > > On Fri, 6 Nov 2020, Michael Niedermayer wrote: > > > On Wed, Nov 04, 2020 at 10:44:56PM +0100, Marton Balint wrote: > > > > > > > > > On Wed, 4 Nov 2020, Michael Niedermayer wrote: > > > > > > > we have "millisecond" based f

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

> On Nov 14, 2020, at 7:14 PM, Marton Balint wrote: > > On Fri, 6 Nov 2020, Michael Niedermayer wrote: > >> On Wed, Nov 04, 2020 at 10:44:56PM +0100, Marton Balint wrote: >>> >>> >>> On Wed, 4 Nov 2020, Michael Niedermayer wrote: >>> we have "millisecond" based formats, rounded timestam

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Fri, 6 Nov 2020, Michael Niedermayer wrote: On Wed, Nov 04, 2020 at 10:44:56PM +0100, Marton Balint wrote: On Wed, 4 Nov 2020, Michael Niedermayer wrote: we have "millisecond" based formats, rounded timestamps we have "exact" cases, maybe the timebase being 1 packet/frame per tick we h

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

> On Nov 6, 2020, at 4:03 PM, Michael Niedermayer > wrote: > > On Wed, Nov 04, 2020 at 10:44:56PM +0100, Marton Balint wrote: >> >> On Wed, 4 Nov 2020, Michael Niedermayer wrote: >> >>> we have "millisecond" based formats, rounded timestamps >>> we have "exact" cases, maybe the timebase bein

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Wed, Nov 04, 2020 at 10:44:56PM +0100, Marton Balint wrote: > > > On Wed, 4 Nov 2020, Michael Niedermayer wrote: > > > we have "millisecond" based formats, rounded timestamps > > we have "exact" cases, maybe the timebase being 1 packet/frame per tick > > we have "high precission" where the ti

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Wed, 4 Nov 2020, Michael Niedermayer wrote: we have "millisecond" based formats, rounded timestamps we have "exact" cases, maybe the timebase being 1 packet/frame per tick we have "high precission" where the timebase is so precisse it doesnt matter This here though is a bit an oddball, the

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Mon, Nov 02, 2020 at 09:42:21PM +0100, Marton Balint wrote: > > > On Mon, 2 Nov 2020, Michael Niedermayer wrote: > > > > > Please correct me if iam wrong but > > > > in cases where no audio is missing or damaged, this would also ignore > > > > how much > > > > audio is in each packet. So you

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Mon, 2 Nov 2020, Michael Niedermayer wrote: Please correct me if iam wrong but in cases where no audio is missing or damaged, this would also ignore how much audio is in each packet. So you could have lets say a timestamp difference of excatly 1 second between 2 packets while their is actua

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Sun, Nov 01, 2020 at 09:58:43PM +0100, Marton Balint wrote: > > > On Sun, 1 Nov 2020, Michael Niedermayer wrote: > > > On Sat, Oct 31, 2020 at 05:56:24PM +0100, Marton Balint wrote: > > > Fixes out of sync timestamps in ticket #8762. > > > > > > Signed-off-by: Marton Balint > > > --- > > >

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

> On Nov 1, 2020, at 3:58 PM, Marton Balint wrote: > > > > On Sun, 1 Nov 2020, Michael Niedermayer wrote: > >> On Sat, Oct 31, 2020 at 05:56:24PM +0100, Marton Balint wrote: >>> Fixes out of sync timestamps in ticket #8762. >>> >>> Signed-off-by: Marton Balint >>> --- >>> libavformat/dv.c

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Sun, 1 Nov 2020, Michael Niedermayer wrote: On Sat, Oct 31, 2020 at 05:56:24PM +0100, Marton Balint wrote: Fixes out of sync timestamps in ticket #8762. Signed-off-by: Marton Balint --- libavformat/dv.c | 16 ++-- tests/ref/seek/lavf-dv | 18 +- 2 files

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Sat, Oct 31, 2020 at 05:56:24PM +0100, Marton Balint wrote: > Fixes out of sync timestamps in ticket #8762. > > Signed-off-by: Marton Balint > --- > libavformat/dv.c | 16 ++-- > tests/ref/seek/lavf-dv | 18 +- > 2 files changed, 11 insertions(+), 23 deletion

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

> On Oct 31, 2020, at 5:15 PM, Marton Balint wrote: > On Sat, 31 Oct 2020, Dave Rice wrote: >>> On Oct 31, 2020, at 3:47 PM, Marton Balint wrote: >>> On Sat, 31 Oct 2020, Dave Rice wrote: Hi Marton, > On Oct 31, 2020, at 12:56 PM, Marton Balint wrote: > Fixes out of sync timestamp

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Sat, 31 Oct 2020, Dave Rice wrote: On Oct 31, 2020, at 3:47 PM, Marton Balint wrote: On Sat, 31 Oct 2020, Dave Rice wrote: Hi Marton, On Oct 31, 2020, at 12:56 PM, Marton Balint wrote: Fixes out of sync timestamps in ticket #8762. Although Michael’s recent patch does address the i

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

> On Oct 31, 2020, at 3:47 PM, Marton Balint wrote: > On Sat, 31 Oct 2020, Dave Rice wrote: > >> Hi Marton, >> >>> On Oct 31, 2020, at 12:56 PM, Marton Balint wrote: >>> Fixes out of sync timestamps in ticket #8762. >> >> Although Michael’s recent patch does address the issue documented in 87

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

On Sat, 31 Oct 2020, Dave Rice wrote: Hi Marton, On Oct 31, 2020, at 12:56 PM, Marton Balint wrote: Fixes out of sync timestamps in ticket #8762. Although Michael’s recent patch does address the issue documented in 8762, I haven’t found this patch to fix the issue. I tried with -c:a co

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

Am Sa., 31. Okt. 2020 um 19:43 Uhr schrieb Dave Rice : > > Hi Marton, > > > On Oct 31, 2020, at 12:56 PM, Marton Balint wrote: > > > > Fixes out of sync timestamps in ticket #8762. > > Although Michael’s recent patch does address the issue documented in 8762, I > haven’t found this patch to fix t

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

Hi Marton, > On Oct 31, 2020, at 12:56 PM, Marton Balint wrote: > > Fixes out of sync timestamps in ticket #8762. Although Michael’s recent patch does address the issue documented in 8762, I haven’t found this patch to fix the issue. I tried with -c:a copy and with -c:a pcm_s16le with some sa

[FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

Fixes out of sync timestamps in ticket #8762. Signed-off-by: Marton Balint --- libavformat/dv.c | 16 ++-- tests/ref/seek/lavf-dv | 18 +- 2 files changed, 11 insertions(+), 23 deletions(-) diff --git a/libavformat/dv.c b/libavformat/dv.c index 3e0d12c0e3..26a7