> 在 2020年1月31日，下午11:24，Nicolas George 写道：
>
> Liu Steven (12020-01-31):
>> Just more safe than without check.
>
> This is a mistake, a common one: this is not safer, it is less: the
> caller has the incorrect assumption that their pointer is not NULL, and
> you are letting them keep it, and ev
Liu Steven (12020-01-31):
> Just more safe than without check.
This is a mistake, a common one: this is not safer, it is less: the
caller has the incorrect assumption that their pointer is not NULL, and
you are letting them keep it, and even in some extents validating it.
> I think if it return -
> 在 2020年1月31日，下午8:14，Liu Steven 写道：
>
>
>
>> 在 2020年1月31日，下午8:07，Nicolas George 写道：
>>
>> Liu Steven (12020-01-31):
>>> for example: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=250
>>
>> Yes, I saw it shortly afterwards. Seems misguided: same result for a
>> protocol not foun
> 在 2020年1月31日，下午8:07，Nicolas George 写道：
>
> Liu Steven (12020-01-31):
>> for example: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=250
>
> Yes, I saw it shortly afterwards. Seems misguided: same result for a
> protocol not found (normal behavior, must be handled) and for a clumsy
Liu Steven (12020-01-31):
> for example: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=250
Yes, I saw it shortly afterwards. Seems misguided: same result for a
protocol not found (normal behavior, must be handled) and for a clumsy
programmer. I like it better when the core functions are
> 在 2020年1月31日，下午7:13，Nicolas George 写道：
>
> Steven Liu (12020-01-31):
>> Signed-off-by: Steven Liu
>> ---
>> libavformat/protocols.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> In what situation is it useful for the caller?
for example: https://patchwork.ffmpeg.org/project/ffmpeg/list/?ser
Steven Liu (12020-01-31):
> Signed-off-by: Steven Liu
> ---
> libavformat/protocols.c | 2 ++
> 1 file changed, 2 insertions(+)
In what situation is it useful for the caller?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
__
Signed-off-by: Steven Liu
---
libavformat/protocols.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/protocols.c b/libavformat/protocols.c
index 29fb99e7fa..c692342132 100644
--- a/libavformat/protocols.c
+++ b/libavformat/protocols.c
@@ -110,6 +110,8 @@ const char *avio_enum_p
