Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Michael Niedermayer
On Fri, Apr 27, 2018 at 12:39:13PM +0200, Paul B Mahol wrote: > On 4/27/18, Michael Niedermayer wrote: > > On Fri, Apr 27, 2018 at 02:36:05AM +0200, Michael Niedermayer wrote: > >> On Fri, Apr 27, 2018 at 12:08:16AM +0100, Josh de Kock wrote: > >> > The postproc library is

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Carl Eugen Hoyos
2018-04-27 14:40 GMT+02:00, Jean-Baptiste Kempf : > Hello, > > On Fri, 27 Apr 2018, at 12:39, Paul B Mahol wrote: >> No point to have separate library nobody really uses. > > VLC uses libprostproc, but we see many crashes in it Please point us to the bug reports. Thank you,

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Paul B Mahol
On 4/27/18, Jean-Baptiste Kempf wrote: > Hello, > > On Fri, 27 Apr 2018, at 12:39, Paul B Mahol wrote: >> No point to have separate library nobody really uses. > > VLC uses libprostproc, but we see many crashes in it, and the usefulness is > not very obvious/visible depending

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Jean-Baptiste Kempf
Hello, On Fri, 27 Apr 2018, at 12:39, Paul B Mahol wrote: > No point to have separate library nobody really uses. VLC uses libprostproc, but we see many crashes in it, and the usefulness is not very obvious/visible depending on the codec. A general library/filter to "smooth" would be very very

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Nicolas George
Paul B Mahol (2018-04-27): > Perhaps you forgot, but I removed libmpcodecs + wrapper. Yes, but you also spend time writing (probably) useful code. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Paul B Mahol
On 4/27/18, Nicolas George wrote: > Paul B Mahol (2018-04-27): >> Libpostproc was removed from Libav, you failed somehow merge that change? > > Many useful things were removed from libav. > > I find somewhat disturbing the amount of time and effort that some > people (not you)

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Nicolas George
Paul B Mahol (2018-04-27): > Libpostproc was removed from Libav, you failed somehow merge that change? Many useful things were removed from libav. I find somewhat disturbing the amount of time and effort that some people (not you) spend trying to remove harmless code instead of producing useful

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Paul B Mahol
On 4/27/18, Michael Niedermayer wrote: > On Fri, Apr 27, 2018 at 02:36:05AM +0200, Michael Niedermayer wrote: >> On Fri, Apr 27, 2018 at 12:08:16AM +0100, Josh de Kock wrote: >> > The postproc library is only used in a single filter, so should be moved >> > into the filter

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-27 Thread Michael Niedermayer
On Fri, Apr 27, 2018 at 02:36:05AM +0200, Michael Niedermayer wrote: > On Fri, Apr 27, 2018 at 12:08:16AM +0100, Josh de Kock wrote: > > The postproc library is only used in a single filter, so should be moved > > into the filter itself if the filter was to stay, but the filter has all of > >

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Michael Niedermayer
On Fri, Apr 27, 2018 at 12:08:16AM +0100, Josh de Kock wrote: > The postproc library is only used in a single filter, so should be moved into > the filter itself if the filter was to stay, but the filter has all of its > internal filters now in lavfi itself. (Also it's a bit weird to have a >

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Carl Eugen Hoyos
2018-04-27 1:57 GMT+02:00, Josh de Kock : > On 2018/04/27 0:38, Carl Eugen Hoyos wrote: >> Could you explain which filters in libavfilter are the >> equivalents for the functionality of libpostproc? > > deblocking filters -> vf_deblock > deinterlacing filters -> vf_yadif >

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Josh de Kock
On 2018/04/27 0:38, Carl Eugen Hoyos wrote: 2018-04-27 1:28 GMT+02:00, Josh de Kock : On 2018/04/27 0:19, Carl Eugen Hoyos wrote: 2018-04-27 1:08 GMT+02:00, Josh de Kock : The postproc library is only used in a single filter Is libswscale used in more

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Carl Eugen Hoyos
2018-04-27 1:28 GMT+02:00, Josh de Kock : > On 2018/04/27 0:19, Carl Eugen Hoyos wrote: >> 2018-04-27 1:08 GMT+02:00, Josh de Kock : >>> The postproc library is only used in a single filter >> >> Is libswscale used in more filters? Are you planning to >>

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Josh de Kock
On 2018/04/27 0:15, James Almer wrote: On 4/26/2018 8:08 PM, Josh de Kock wrote: The postproc library is only used in a single filter, so should be moved into the filter itself if the filter was to stay, but the filter has all of its internal filters now in lavfi itself. (Also it's a bit

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Josh de Kock
On 2018/04/27 0:19, Carl Eugen Hoyos wrote: 2018-04-27 1:08 GMT+02:00, Josh de Kock : The postproc library is only used in a single filter Is libswscale used in more filters? Are you planning to deprecate it? No, libswscale does not suffer from the same issue of being a

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Carl Eugen Hoyos
2018-04-27 1:08 GMT+02:00, Josh de Kock : > The postproc library is only used in a single filter Is libswscale used in more filters? Are you planning to deprecate it? Seriously: The library is needed for compliance with multimedia standards, it should not be deprecated. Carl

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread James Almer
On 4/26/2018 8:08 PM, Josh de Kock wrote: > The postproc library is only used in a single filter, so should be moved into > the filter itself if the filter was to stay, but the filter has all of its > internal filters now in lavfi itself. (Also it's a bit weird to have a > separate library of

[FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Josh de Kock
The postproc library is only used in a single filter, so should be moved into the filter itself if the filter was to stay, but the filter has all of its internal filters now in lavfi itself. (Also it's a bit weird to have a separate library of filters which is used in a filter in the filter