Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-05 Thread Stefano Sabatini
On date Tuesday 2023-09-05 12:43:35 +, ffmpeg-devel Mailing List wrote: [...] > On date Saturday 2023-09-02 09:20:08 +, Carotti, Elias wrote: > > On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > > > > > > > > > In particular why are you turning on fast_pskip silently base

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-05 Thread Carotti, Elias via ffmpeg-devel
-Original Message- From: ffmpeg-devel On Behalf Of Stefano Sabatini Sent: Saturday, September 2, 2023 5:45 PM To: ffmpeg-devel@ffmpeg.org Cc: kier...@obe.tv; Carotti, Elias Subject: RE: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_i

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 09:20:08 +, Carotti, Elias wrote: > On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > > > > > In particular why are you turning on fast_pskip silently based on a > > > completely different setting? > > > > The patch is fixing the regression intro

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-02 Thread Carotti, Elias via ffmpeg-devel
On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > In particular why are you turning on fast_pskip silently based on a > > completely different setting? > > The patch is fixing the regression introduced by the unconditional > setting of b_fast_pskip. > > Now the question is if

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-31 Thread Stefano Sabatini
; Hi > >> > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> Stefano Sabatini > >> Sent: Friday, August 25, 2023 12:01 PM > >> To: FFmpeg development discussions and patches > >> Cc: Stefano Sabatini > >

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-31 Thread Kieran Kunhya
Sabatini >> Sent: Friday, August 25, 2023 12:01 PM >> To: FFmpeg development discussions and patches >> Cc: Stefano Sabatini >> Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable >> x4->params.analyse.b_fast_pskip if mb_info is set >> >>

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-31 Thread Kieran Kunhya
and patches > Cc: Stefano Sabatini > Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable > x4->params.analyse.b_fast_pskip if mb_info is set > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can c

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-31 Thread Carotti, Elias via ffmpeg-devel
Hi -Original Message- From: ffmpeg-devel On Behalf Of Stefano Sabatini Sent: Friday, August 25, 2023 12:01 PM To: FFmpeg development discussions and patches Cc: Stefano Sabatini Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_i

[FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-25 Thread Stefano Sabatini
x4->params.analyse.b_fast_pskip should only be forced in case mb_info is set. Fix output change introduced in 418c954e318. --- libavcodec/libx264.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 1a7dc7bdd5..a2877d7f75 10064