Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/28/2016 12:22 AM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 09:24:14PM +0100, Mats Peterson wrote: On 02/27/2016 09:21 PM, Mats Peterson wrote: On 02/27/2016 08:42 PM, Reimar Döffinger wrote: Well, then we know I can only blame Mats for "only" making it better instead of perfect :)

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Reimar Döffinger
On Sat, Feb 27, 2016 at 09:24:14PM +0100, Mats Peterson wrote: > On 02/27/2016 09:21 PM, Mats Peterson wrote: > >On 02/27/2016 08:42 PM, Reimar Döffinger wrote: > >>Well, then we know I can only blame Mats for "only" making it > >>better instead of perfect :) > >>___

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 09:33 PM, Michael Niedermayer wrote: On Sat, Feb 27, 2016 at 08:42:25PM +0100, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 07:51:41PM +0100, Michael Niedermayer wrote: should rawvideo AVPackets palette use data[] or sidedata, honestly i do not know, but i dont think it makes a

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Michael Niedermayer
On Sat, Feb 27, 2016 at 08:42:25PM +0100, Reimar Döffinger wrote: > On Sat, Feb 27, 2016 at 07:51:41PM +0100, Michael Niedermayer wrote: > > should rawvideo AVPackets palette use data[] or sidedata, honestly i > > do not know, but i dont think it makes a big difference > > even supporting both, lik

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 09:21 PM, Mats Peterson wrote: On 02/27/2016 08:42 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 07:51:41PM +0100, Michael Niedermayer wrote: should rawvideo AVPackets palette use data[] or sidedata, honestly i do not know, but i dont think it makes a big difference even sup

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 08:42 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 07:51:41PM +0100, Michael Niedermayer wrote: should rawvideo AVPackets palette use data[] or sidedata, honestly i do not know, but i dont think it makes a big difference even supporting both, likely only adds 3-5 lines of co

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 08:44 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 07:52:52PM +0100, Mats Peterson wrote: On 02/27/2016 07:46 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 07:40:44PM +0100, Mats Peterson wrote: On 02/27/2016 07:18 PM, Reimar Döffinger wrote: That's not what e.g. th

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Reimar Döffinger
On Sat, Feb 27, 2016 at 07:52:52PM +0100, Mats Peterson wrote: > On 02/27/2016 07:46 PM, Reimar Döffinger wrote: > >On Sat, Feb 27, 2016 at 07:40:44PM +0100, Mats Peterson wrote: > >>On 02/27/2016 07:18 PM, Reimar Döffinger wrote: > >>>That's not what e.g. the matroska demuxer produces, so stream >

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Reimar Döffinger
On Sat, Feb 27, 2016 at 07:51:41PM +0100, Michael Niedermayer wrote: > should rawvideo AVPackets palette use data[] or sidedata, honestly i > do not know, but i dont think it makes a big difference > even supporting both, likely only adds 3-5 lines of code or so > its more a philosophical question

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 07:51 PM, Michael Niedermayer wrote: On Sat, Feb 27, 2016 at 05:45:57PM +0100, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 04:15:10PM +0100, Mats Peterson wrote: On 02/27/2016 04:13 PM, Mats Peterson wrote: On 02/27/2016 04:08 PM, Mats Peterson wrote: On 02/27/2016 04:07 PM,

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 07:46 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 07:40:44PM +0100, Mats Peterson wrote: On 02/27/2016 07:18 PM, Reimar Döffinger wrote: That's not what e.g. the matroska demuxer produces, so stream copying with some generic remuxing example I am really sure that is NOT ho

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Michael Niedermayer
On Sat, Feb 27, 2016 at 05:45:57PM +0100, Reimar Döffinger wrote: > On Sat, Feb 27, 2016 at 04:15:10PM +0100, Mats Peterson wrote: > > On 02/27/2016 04:13 PM, Mats Peterson wrote: > > >On 02/27/2016 04:08 PM, Mats Peterson wrote: > > >>On 02/27/2016 04:07 PM, Mats Peterson wrote: > > >>>On 02/27/20

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Reimar Döffinger
On Sat, Feb 27, 2016 at 07:40:44PM +0100, Mats Peterson wrote: > On 02/27/2016 07:18 PM, Reimar Döffinger wrote: > >That's not what e.g. the matroska demuxer produces, so stream > >copying with some generic remuxing example I am really sure that is > >NOT how the packets come in. > > > > Stream co

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 07:40 PM, Mats Peterson wrote: On 02/27/2016 07:18 PM, Reimar Döffinger wrote: That's not what e.g. the matroska demuxer produces, so stream copying with some generic remuxing example I am really sure that is NOT how the packets come in. Stream copying of raw palettized data sel

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 07:18 PM, Reimar Döffinger wrote: That's not what e.g. the matroska demuxer produces, so stream copying with some generic remuxing example I am really sure that is NOT how the packets come in. Stream copying of raw palettized data seldom works well, due to different strides of A

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 07:18 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 06:05:20PM +0100, Mats Peterson wrote: On 02/27/2016 05:45 PM, Reimar Döffinger wrote: Not that it couldn't be done with side data packets, though. If it doesn't support side data then the muxers are plain broken. The m

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Reimar Döffinger
On Sat, Feb 27, 2016 at 06:05:20PM +0100, Mats Peterson wrote: > On 02/27/2016 05:45 PM, Reimar Döffinger wrote: > >>Not that it couldn't be done with side data packets, though. > > > >If it doesn't support side data then the muxers are plain broken. > > The muxers should support side data, I agre

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 05:45 PM, Reimar Döffinger wrote: I agree that it should be stored in a side data packet myself normally, and that this is a somewhat weird construction. It probably has to do with the nut format originally, which stores raw palettized data after the video data in the packets. Anywa

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Reimar Döffinger
On Sat, Feb 27, 2016 at 04:15:10PM +0100, Mats Peterson wrote: > On 02/27/2016 04:13 PM, Mats Peterson wrote: > >On 02/27/2016 04:08 PM, Mats Peterson wrote: > >>On 02/27/2016 04:07 PM, Mats Peterson wrote: > >>>On 02/27/2016 04:00 PM, Reimar Döffinger wrote: > On Sat, Feb 27, 2016 at 03:57:06P

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 04:13 PM, Mats Peterson wrote: On 02/27/2016 04:08 PM, Mats Peterson wrote: On 02/27/2016 04:07 PM, Mats Peterson wrote: On 02/27/2016 04:00 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 03:57:06PM +0100, Mats Peterson wrote: On 02/27/2016 03:37 PM, Mats Peterson wrote:

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 04:08 PM, Mats Peterson wrote: On 02/27/2016 04:07 PM, Mats Peterson wrote: On 02/27/2016 04:00 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 03:57:06PM +0100, Mats Peterson wrote: On 02/27/2016 03:37 PM, Mats Peterson wrote:

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 04:07 PM, Mats Peterson wrote: On 02/27/2016 04:00 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 03:57:06PM +0100, Mats Peterson wrote: On 02/27/2016 03:37 PM, Mats Peterson wrote: ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 04:00 PM, Reimar Döffinger wrote: On Sat, Feb 27, 2016 at 03:57:06PM +0100, Mats Peterson wrote: On 02/27/2016 03:37 PM, Mats Peterson wrote: ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Reimar Döffinger
On Sat, Feb 27, 2016 at 03:57:06PM +0100, Mats Peterson wrote: > On 02/27/2016 03:37 PM, Mats Peterson wrote: > > > > > > > >___ > >ffmpeg-devel mailing list > >ffmpeg-devel@ffmpeg.org > >http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > I suppose

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
On 02/27/2016 03:37 PM, Mats Peterson wrote: ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel I suppose this is what you mean, Reimar. Treating the palette, if a packet contains one at the end

[FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

2016-02-27 Thread Mats Peterson
-- Mats Peterson http://matsp888.no-ip.org/~mats/ >From 309ee0932eda48b340f2da9f2bc9ac3ea667edf9 Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Sat, 27 Feb 2016 15:31:08 +0100 Subject: [PATCH 1/2] lavf/avienc: Simplify palette handling --- libavformat/avienc.c |4 ++-- 1 file changed,