Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread James Darnley
On 2015-09-29 21:56, Clément Bœsch wrote: > On Tue, Sep 29, 2015 at 09:21:53PM +0200, Hendrik Leppkes wrote: >> I agree, we have patchcheck for typo checking. > > A lot of people do not run patchcheck (I personally never do, and given > that we fix typo on a regular basis I'm probably not the only

Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread James Almer
On 9/29/2015 5:14 PM, Hendrik Leppkes wrote: > Typos should not be fixed in the merge. Either review and fix them > before they get commited in Libav, or fix them in a separate commit > afterwards. > If I have to start fixing every typo in every commit that I merge from > Libav, then I'm going to g

Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread Hendrik Leppkes
On Tue, Sep 29, 2015 at 10:11 PM, James Almer wrote: > On 9/29/2015 4:21 PM, Hendrik Leppkes wrote: >> On Tue, Sep 29, 2015 at 9:08 PM, wm4 wrote: >>> On Tue, 29 Sep 2015 20:57:31 +0200 >>> Michael Niedermayer wrote: >>> From: Michael Niedermayer Signed-off-by: Michael Niedermaye

Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread James Almer
On 9/29/2015 4:21 PM, Hendrik Leppkes wrote: > On Tue, Sep 29, 2015 at 9:08 PM, wm4 wrote: >> On Tue, 29 Sep 2015 20:57:31 +0200 >> Michael Niedermayer wrote: >> >>> From: Michael Niedermayer >>> >>> Signed-off-by: Michael Niedermayer >>> --- >>> tests/fate/source-check.sh |8 >>>

Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread Hendrik Leppkes
On Tue, Sep 29, 2015 at 9:56 PM, Clément Bœsch wrote: > On Tue, Sep 29, 2015 at 09:21:53PM +0200, Hendrik Leppkes wrote: >> On Tue, Sep 29, 2015 at 9:08 PM, wm4 wrote: >> > On Tue, 29 Sep 2015 20:57:31 +0200 >> > Michael Niedermayer wrote: >> > >> >> From: Michael Niedermayer >> >> >> >> Signed

Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread Clément Bœsch
On Tue, Sep 29, 2015 at 09:21:53PM +0200, Hendrik Leppkes wrote: > On Tue, Sep 29, 2015 at 9:08 PM, wm4 wrote: > > On Tue, 29 Sep 2015 20:57:31 +0200 > > Michael Niedermayer wrote: > > > >> From: Michael Niedermayer > >> > >> Signed-off-by: Michael Niedermayer > >> --- > >> tests/fate/source-c

Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread Hendrik Leppkes
On Tue, Sep 29, 2015 at 9:08 PM, wm4 wrote: > On Tue, 29 Sep 2015 20:57:31 +0200 > Michael Niedermayer wrote: > >> From: Michael Niedermayer >> >> Signed-off-by: Michael Niedermayer >> --- >> tests/fate/source-check.sh |8 >> tests/ref/fate/source |3 +++ >> 2 files chang

Re: [FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread wm4
On Tue, 29 Sep 2015 20:57:31 +0200 Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > tests/fate/source-check.sh |8 > tests/ref/fate/source |3 +++ > 2 files changed, 11 insertions(+) > > diff --git a/tests/fate/source

[FFmpeg-devel] [PATCH 2/2] tests/fate/source-check.sh: Check for common typos

2015-09-29 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- tests/fate/source-check.sh |8 tests/ref/fate/source |3 +++ 2 files changed, 11 insertions(+) diff --git a/tests/fate/source-check.sh b/tests/fate/source-check.sh index fb7af98..ac6bbc0 100755 --- a/tests/f