Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-23 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-07-23 22:14:19) > On Tue, Jul 23, 2024 at 08:52:58AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-07-22 23:14:04) > > > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > > > There is no reason to delay it and this is a more nat

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-23 Thread Michael Niedermayer
On Tue, Jul 23, 2024 at 08:52:58AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-22 23:14:04) > > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > > There is no reason to delay it and this is a more natural place for > > > this code. > > > > There is a reason

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-22 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-07-22 23:14:04) > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > There is no reason to delay it and this is a more natural place for > > this code. > > There is a reason. > By doing it later the surrounding pixels are available and one could >

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-22 Thread Michael Niedermayer
On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > There is no reason to delay it and this is a more natural place for > this code. There is a reason. By doing it later the surrounding pixels are available and one could compute motion vectors from these surroundings and use all kinds

[FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-22 Thread Anton Khirnov
There is no reason to delay it and this is a more natural place for this code. --- libavcodec/ffv1dec.c | 53 ++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index aa2c35880e..5821a4156a 100644