Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-30 Thread Lynne
Apr 30, 2020, 10:52 by d...@lynne.ee: > Apr 29, 2020, 16:00 by mich...@niedermayer.cc: > >> On Tue, Apr 28, 2020 at 07:22:08PM +0200, Lynne wrote: >> >>> Apr 28, 2020, 16:07 by d...@lynne.ee: >>> >>> > Apr 28, 2020, 15:59 by mattias.wad...@gmail.com: >>> > >>> >> >>> >> >>> > Well, I consider CRC

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-30 Thread Lynne
Apr 29, 2020, 16:00 by mich...@niedermayer.cc: > On Tue, Apr 28, 2020 at 07:22:08PM +0200, Lynne wrote: > >> Apr 28, 2020, 16:07 by d...@lynne.ee: >> >> > Apr 28, 2020, 15:59 by mattias.wad...@gmail.com: >> > >> >> >> >> >> > Well, I consider CRC checking a part of correctly parsing ogg, so I

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-29 Thread Michael Niedermayer
On Tue, Apr 28, 2020 at 07:22:08PM +0200, Lynne wrote: > Apr 28, 2020, 16:07 by d...@lynne.ee: > > > Apr 28, 2020, 15:59 by mattias.wad...@gmail.com: > > > >> > >> > > Well, I consider CRC checking a part of correctly parsing ogg, so I think > > its best to leave it on > > all the time. > > > >

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Lynne
Apr 28, 2020, 16:07 by d...@lynne.ee: > Apr 28, 2020, 15:59 by mattias.wad...@gmail.com: > >> >> > Well, I consider CRC checking a part of correctly parsing ogg, so I think its > best to leave it on > all the time. > Did a new version of the patches. The first two are identical, save for some

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Lynne
Apr 28, 2020, 15:59 by mattias.wad...@gmail.com: > On Tue, Apr 28, 2020 at 4:45 PM Lynne wrote: > >> >> Apr 28, 2020, 15:31 by mattias.wad...@gmail.com: >> >> > Nice, test files works fine now >> > >> > Would it make sense to conditionally ignore crc mismatch based on >> > s->error_recognition &

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Lynne
Apr 28, 2020, 15:31 by mattias.wad...@gmail.com: > Nice, test files works fine now > > Would it make sense to conditionally ignore crc mismatch based on > s->error_recognition & AV_EF_CRCCHECK ? > I don't think so. This container specifically relies on CRC matching to identify packets during a

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Mattias Wadman
On Tue, Apr 28, 2020 at 4:45 PM Lynne wrote: > > Apr 28, 2020, 15:31 by mattias.wad...@gmail.com: > > > Nice, test files works fine now > > > > Would it make sense to conditionally ignore crc mismatch based on > > s->error_recognition & AV_EF_CRCCHECK ? > > > > I don't think so. This container

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Mattias Wadman
On Tue, Apr 28, 2020 at 4:12 PM Lynne wrote: > > Apr 28, 2020, 14:05 by mattias.wad...@gmail.com: > > > On Tue, Apr 28, 2020 at 1:59 PM Lynne wrote: > > > >> > >> This makes decoding far more robust, since OggS, the ogg magic, > >> can be commonly found randomly in streams, which previously made

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Lynne
Apr 28, 2020, 14:05 by mattias.wad...@gmail.com: > On Tue, Apr 28, 2020 at 1:59 PM Lynne wrote: > >> >> This makes decoding far more robust, since OggS, the ogg magic, >> can be commonly found randomly in streams, which previously made >> the demuxer think there's a new stream or a change in

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Mattias Wadman
On Tue, Apr 28, 2020 at 1:59 PM Lynne wrote: > > This makes decoding far more robust, since OggS, the ogg magic, > can be commonly found randomly in streams, which previously made > the demuxer think there's a new stream or a change in such. > > Patch attached. Maybe nitpick, could seek back

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Mattias Wadman
On Tue, Apr 28, 2020 at 1:59 PM Lynne wrote: > > This makes decoding far more robust, since OggS, the ogg magic, > can be commonly found randomly in streams, which previously made > the demuxer think there's a new stream or a change in such. > > Patch attached. Should check version after

[FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-28 Thread Lynne
This makes decoding far more robust, since OggS, the ogg magic, can be commonly found randomly in streams, which previously made the demuxer think there's a new stream or a change in such. Patch attached. >From 61759b6b1ef3ca813eb39ee9ace2342eb121b3b0 Mon Sep 17 00:00:00 2001 From: Lynne Date: