Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: support writing iTunes cover image

On Wed, 11 Apr 2018 14:25:15 +0100 Rostislav Pehlivanov wrote: > On 11 April 2018 at 06:22, Timo Teräs wrote: > > > Ping. > > > > Any comments on this? > > > > There was also recently the flacenc support for cover images, and > > the question if some of

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: support writing iTunes cover image

On 11 April 2018 at 06:22, Timo Teräs wrote: > Ping. > > Any comments on this? > > There was also recently the flacenc support for cover images, and the > question if some of this code should be moved to generic code in mux.c so > both can share it: e.g. storing the image

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: support writing iTunes cover image

Ping. Any comments on this? There was also recently the flacenc support for cover images, and the question if some of this code should be moved to generic code in mux.c so both can share it: e.g. storing the image packets to attached_pic - or if that should be moved to the muxer private structs.

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: support writing iTunes cover image

Fixes https://trac.ffmpeg.org/ticket/2798 This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write the associated pictures in iTunes cover atom. This corresponds to how 'mov' demuxer parses and exposes the cover images when reading. Most of the existing track handling loops properly ignore