2017-09-29 5:38 GMT+02:00 Jeyapal, Karthick :
>>On 9/29/17, 7:36 AM, "James Almer" wrote:
>>>
>>> +static inline uint16_t parity (uint16_t x)
>>> +{
>>> +uint16_t i;
>>> +for (i = 4 * sizeof (x); i > 0; i /= 2)
>>> +x ^= x >> i;
>>> +
>On 9/29/17, 7:36 AM, "James Almer" wrote:
>>
>> +static inline uint16_t parity (uint16_t x)
>> +{
>> +uint16_t i;
>> +for (i = 4 * sizeof (x); i > 0; i /= 2)
>> +x ^= x >> i;
>> +return x & 1;
>> +}
>
>Can't you use av_parity() instead?
Yes, I can.
>Applied the series, thanks!
>
>Marton
Thanks a lot!
Regards,
Karthick
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 9/28/2017 1:17 AM, Jeyapal, Karthick wrote:
>> Sorry, still not quite there... Here are some further comments:
> Thanks for your comments and patience. Please find the updated patch
> attached, with all the comments taken.
> Also, I have rebased this patch with the latest ffmpeg, as avcodec
On Thu, 28 Sep 2017, Jeyapal, Karthick wrote:
Sorry, still not quite there... Here are some further comments:
Thanks for your comments and patience. Please find the updated patch attached,
with all the comments taken.
Also, I have rebased this patch with the latest ffmpeg, as avcodec version
>Sorry, still not quite there... Here are some further comments:
Thanks for your comments and patience. Please find the updated patch attached,
with all the comments taken.
Also, I have rebased this patch with the latest ffmpeg, as avcodec version
numbers have changed in the meantime.
>Also
On Wed, 27 Sep 2017, Jeyapal, Karthick wrote:
Sorry for the late reply, the last was busy week. Here are some more
comments:
Thanks for your comments. Please find the updated patch attached with your
comments incorporated.
Sorry, still not quite there... Here are some further comments:
>Sorry for the late reply, the last was busy week. Here are some more
>comments:
Thanks for your comments. Please find the updated patch attached with your
comments incorporated.
Regards,
Karthick
0003-avdevice-decklink_dec-Added-Closed-caption-decode-fr.patch
Description:
On Wed, 20 Sep 2017, Jeyapal, Karthick wrote:
Then please add the relevant copyright line to the file you changed.
(Probably "Rafaël Carré" but please verify yourself)
Carl Eugen
Thanks for the clarification. I have added the copyright line as you
have advised. (Yes, I have verified that
>Then please add the relevant copyright line to the file you changed.
>(Probably "Rafaël Carré" but please verify yourself)
>
>Carl Eugen
Thanks for the clarification. I have added the copyright line as you have
advised. (Yes, I have verified that that “Rafaël Carré” was the original author
of
2017-09-15 11:29 GMT+02:00 Jeyapal, Karthick :
> And I forgot to mention a thing. Some parts of that code in this patch
> was started from VLC’s source code. Source link here
> https://fossies.org/linux/vlc/modules/access/sdi.c
Then please add the relevant copyright line to
>Shoot, then the original code was incorrect :).
>
>I will take a final look at your patches next week.
>
>Regards,
>Marton
Thanks. And I forgot to mention a thing. Some parts of that code in this patch
was started from VLC’s source code. Source link here
On Thu, 14 Sep 2017, Jeyapal, Karthick wrote:
Hi Marton,
Thanks a lot for your comments. I have modified the patch as per all your
comments, except the below one.
+tgt = teletext_data_unit_from_ancillary_packet(buf, buf + 1920, tgt,
cctx->teletext_lines, 0);
this should be
Hi Marton,
Thanks a lot for your comments. I have modified the patch as per all your
comments, except the below one.
>> +tgt = teletext_data_unit_from_ancillary_packet(buf, buf + 1920,
>> tgt, cctx->teletext_lines, 0);
>
>this should be
>tgt =
On Tue, 5 Sep 2017, Jeyapal, Karthick wrote:
On 9/3/17, 8:19 PM, "Marton Balint" >
wrote:
Why don't use you simply use uint16_t here as well? I think we typically
try to avoid unsigned as a type.
Done. Changed it to uint16_t.
This VANC parser
>On 9/3/17, 8:19 PM, "Marton Balint" >
>wrote:
>Why don't use you simply use uint16_t here as well? I think we typically
>try to avoid unsigned as a type.
Done. Changed it to uint16_t.
>This VANC parser does not seem right. VANC header can appear multiple
On Thu, 31 Aug 2017, kjeya...@akamai.com wrote:
From: Karthick J
Signed-off-by: Karthick J
---
libavcodec/avcodec.h | 7 ++
libavdevice/decklink_dec.cpp | 167 ---
2 files changed, 165 insertions(+), 9
From: Karthick J
Signed-off-by: Karthick J
---
libavcodec/avcodec.h | 7 ++
libavdevice/decklink_dec.cpp | 167 ---
2 files changed, 165 insertions(+), 9 deletions(-)
diff --git a/libavcodec/avcodec.h
18 matches
Mail list logo