Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2015-01-31 Thread Michael Niedermayer
On Sat, Jan 31, 2015 at 10:51:05PM +0100, Christophe Gisquet wrote: > Hi, > > 2014-10-30 14:49 GMT+01:00 Christophe Gisquet : > > Hi, > > > > 2014-10-26 19:20 GMT+01:00 Michael Niedermayer : > >> I took the liberty to apply the patch and fix the bug instead of > >> leaving it open until someone su

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2015-01-31 Thread Christophe Gisquet
Hi, 2014-10-30 14:49 GMT+01:00 Christophe Gisquet : > Hi, > > 2014-10-26 19:20 GMT+01:00 Michael Niedermayer : >> I took the liberty to apply the patch and fix the bug instead of >> leaving it open until someone succeeds writing a fate test for it > > Hi, I wonder whether this should be reverted f

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-30 Thread Michael Niedermayer
On Thu, Oct 30, 2014 at 02:49:30PM +0100, Christophe Gisquet wrote: > Hi, > > 2014-10-26 19:20 GMT+01:00 Michael Niedermayer : > > I took the liberty to apply the patch and fix the bug instead of > > leaving it open until someone succeeds writing a fate test for it > > Hi, I wonder whether this s

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-30 Thread Christophe Gisquet
Hi, 2014-10-26 19:20 GMT+01:00 Michael Niedermayer : > I took the liberty to apply the patch and fix the bug instead of > leaving it open until someone succeeds writing a fate test for it Hi, I wonder whether this should be reverted for now (and ticket #2970 reopened at the same time). I have be

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-29 Thread Christophe Gisquet
Hi, 2014-10-25 20:32 GMT+02:00 Christophe Gisquet : > What I meant is I would need someone to: > 1) provide a command line to swap fields to produce an artificially > interlaced image > 2) confirm that -flags ildct sets CODEC_FLAG_INTERLACED_DCT and does > what is needed Unfortunately, I haven't

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-26 Thread Michael Niedermayer
On Sat, Oct 25, 2014 at 06:25:22PM +0200, Reimar Döffinger wrote: > On Sat, Oct 25, 2014 at 05:35:37PM +0200, Christophe Gisquet wrote: > > 2014-10-25 13:35 GMT+02:00 Reimar Döffinger : > > > Could you maybe add e.g. a FATE test that clearly shows the before-after > > > improvements? > > > > I've

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-26 Thread Michael Niedermayer
On Sat, Oct 25, 2014 at 11:19:23AM +, Christophe Gisquet wrote: > The coefficients must be in the appropriate zigzag scan order. > Also fix their values at the same time, as they were pretty wrong. > > Fixes ticket #2970. > --- > libavcodec/dvdata.c | 16 > 1 file changed, 8

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-25 Thread Christophe Gisquet
Hi, 2014-10-25 18:25 GMT+02:00 Reimar Döffinger : > On Sat, Oct 25, 2014 at 05:35:37PM +0200, Christophe Gisquet wrote: >> 2014-10-25 13:35 GMT+02:00 Reimar Döffinger : >> > Could you maybe add e.g. a FATE test that clearly shows the before-after >> > improvements? >> >> I've tried for a small whi

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-25 Thread Reimar Döffinger
On Sat, Oct 25, 2014 at 05:35:37PM +0200, Christophe Gisquet wrote: > 2014-10-25 13:35 GMT+02:00 Reimar Döffinger : > > Could you maybe add e.g. a FATE test that clearly shows the before-after > > improvements? > > I've tried for a small while, by swapping fields on lena and converting to > yuv42[

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-25 Thread Christophe Gisquet
2014-10-25 13:35 GMT+02:00 Reimar Döffinger : > Could you maybe add e.g. a FATE test that clearly shows the before-after > improvements? I've tried for a small while, by swapping fields on lena and converting to yuv42[02]p and feeding it to ffmpeg with: -pix_fmt yuv422p -s 720x576 -i lena.yuv -fla

Re: [FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-25 Thread Reimar Döffinger
On Sat, Oct 25, 2014 at 11:19:23AM +, Christophe Gisquet wrote: > The coefficients must be in the appropriate zigzag scan order. > Also fix their values at the same time, as they were pretty wrong. > > Fixes ticket #2970. Could you maybe add e.g. a FATE test that clearly shows the before-afte

[FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

2014-10-25 Thread Christophe Gisquet
The coefficients must be in the appropriate zigzag scan order. Also fix their values at the same time, as they were pretty wrong. Fixes ticket #2970. --- libavcodec/dvdata.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/dvdata.c b/libavcodec/dvdat