Re: [FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

2017-10-26 Thread Tobias Rapp
On 25.10.2017 20:01, Michael Niedermayer wrote: On Wed, Oct 25, 2017 at 07:55:52PM +0200, Michael Niedermayer wrote: On Tue, Oct 24, 2017 at 11:47:21AM +0200, Tobias Rapp wrote: According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field should contain the absolute position to the

Re: [FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

2017-10-25 Thread Michael Niedermayer
On Wed, Oct 25, 2017 at 07:55:52PM +0200, Michael Niedermayer wrote: > On Tue, Oct 24, 2017 at 11:47:21AM +0200, Tobias Rapp wrote: > > According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field > > should contain the absolute position to the maximum audio sample value, > > but the current

Re: [FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

2017-10-25 Thread Michael Niedermayer
On Tue, Oct 24, 2017 at 11:47:21AM +0200, Tobias Rapp wrote: > According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field > should contain the absolute position to the maximum audio sample value, > but the current implementation writes the relative peak frame index > instead. > > Fix the

[FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

2017-10-24 Thread Tobias Rapp
According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field should contain the absolute position to the maximum audio sample value, but the current implementation writes the relative peak frame index instead. Fix the issue by writing the "unknown" value (-1) for now until the feature is