Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-10 Thread Steven Liu
2017-04-11 4:16 GMT+08:00 Marton Balint : > > > On Mon, 10 Apr 2017, Steven Liu wrote: > > 2017-04-10 7:09 GMT+08:00 Marton Balint : >> >> >>> >>> On Mon, 10 Apr 2017, Steven Liu wrote: >>> >>> 2017-04-10 4:39 GMT+08:00 Nicolas George : >>> Le septidi 17 germinal, an CCXXV, Michael Niede

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-10 Thread Marton Balint
On Mon, 10 Apr 2017, Steven Liu wrote: 2017-04-10 7:09 GMT+08:00 Marton Balint : On Mon, 10 Apr 2017, Steven Liu wrote: 2017-04-10 4:39 GMT+08:00 Nicolas George : Le septidi 17 germinal, an CCXXV, Michael Niedermayer a écrit : > Its in no release, and there seems consensus that it shou

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-09 Thread Steven Liu
2017-04-10 7:09 GMT+08:00 Marton Balint : > > > On Mon, 10 Apr 2017, Steven Liu wrote: > > 2017-04-10 4:39 GMT+08:00 Nicolas George : >> >> Le septidi 17 germinal, an CCXXV, Michael Niedermayer a écrit : >>> > Its in no release, and there seems consensus that it shouldnt be >>> > in a release at t

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-09 Thread Marton Balint
On Mon, 10 Apr 2017, Steven Liu wrote: 2017-04-10 4:39 GMT+08:00 Nicolas George : Le septidi 17 germinal, an CCXXV, Michael Niedermayer a écrit : > Its in no release, and there seems consensus that it shouldnt be > in a release at this point, so id say remove it from release/3.3 branch I th

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-09 Thread Steven Liu
2017-04-10 4:39 GMT+08:00 Nicolas George : > Le septidi 17 germinal, an CCXXV, Michael Niedermayer a écrit : > > Its in no release, and there seems consensus that it shouldnt be > > in a release at this point, so id say remove it from release/3.3 branch > > I think we can say that enough time has

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-09 Thread Nicolas George
Le septidi 17 germinal, an CCXXV, Michael Niedermayer a écrit : > Its in no release, and there seems consensus that it shouldnt be > in a release at this point, so id say remove it from release/3.3 branch I think we can say that enough time has passed, and ideally it should be removed before the a

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread Michael Niedermayer
On Wed, Apr 05, 2017 at 07:49:23PM +0200, Nicolas George wrote: > Le sextidi 16 germinal, an CCXXV, James Almer a écrit : > > > I don't think it would cause any problems for the users in practice. > > > But we can also remove the function alltogether from the release, so > > > anybody who want's to

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread Steven Liu
2017-04-06 1:49 GMT+08:00 Nicolas George : > Le sextidi 16 germinal, an CCXXV, James Almer a écrit : > > > I don't think it would cause any problems for the users in practice. > > > But we can also remove the function alltogether from the release, so > > > anybody who want's to use the function (w

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread James Almer
On 4/5/2017 2:49 PM, Nicolas George wrote: > Le sextidi 16 germinal, an CCXXV, James Almer a écrit : >>> I don't think it would cause any problems for the users in practice. >>> But we can also remove the function alltogether from the release, so >>> anybody who want's to use the function (with the

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread Nicolas George
Le sextidi 16 germinal, an CCXXV, James Almer a écrit : > > I don't think it would cause any problems for the users in practice. > > But we can also remove the function alltogether from the release, so > > anybody who want's to use the function (with the new name) will only > > have to check for a

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread James Almer
On 4/5/2017 2:38 PM, Marton Balint wrote: > > > On Wed, 5 Apr 2017, James Almer wrote: > >> On 4/5/2017 1:49 PM, Marton Balint wrote: >>> >>> >>> On Wed, 5 Apr 2017, James Almer wrote: >>> On 4/5/2017 11:05 AM, Steven Liu wrote: > 2017-04-03 20:32 GMT+08:00 Nicolas George : > >>

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread Marton Balint
On Wed, 5 Apr 2017, James Almer wrote: On 4/5/2017 1:49 PM, Marton Balint wrote: On Wed, 5 Apr 2017, James Almer wrote: On 4/5/2017 11:05 AM, Steven Liu wrote: 2017-04-03 20:32 GMT+08:00 Nicolas George : Le quartidi 14 germinal, an CCXXV, Steven Liu a écrit : change name from av_strre

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread Nicolas George
Le sextidi 16 germinal, an CCXXV, James Almer a écrit : > Library versions and feature sets in diverging branches. When you > branch you do a feature freeze. I do not agree with that. The delay between branching and tagging the release has exactly the purpose of fixing the big mistakes that were i

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread James Almer
On 4/5/2017 1:49 PM, Marton Balint wrote: > > > On Wed, 5 Apr 2017, James Almer wrote: > >> On 4/5/2017 11:05 AM, Steven Liu wrote: >>> 2017-04-03 20:32 GMT+08:00 Nicolas George : >>> Le quartidi 14 germinal, an CCXXV, Steven Liu a écrit : > change name from av_strreplace to av_strirepl

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread Nicolas George
Le sextidi 16 germinal, an CCXXV, James Almer a écrit : > You can't rename the function. It's already in the 3.3 branch. AFAICS, it is only a branch yet, so I see no reason not to push this, provided it is backported to the branch and done before the actual release. Thus, I think this discussion

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread Marton Balint
On Wed, 5 Apr 2017, James Almer wrote: On 4/5/2017 11:05 AM, Steven Liu wrote: 2017-04-03 20:32 GMT+08:00 Nicolas George : Le quartidi 14 germinal, an CCXXV, Steven Liu a écrit : change name from av_strreplace to av_strireplace Use AVBprint to implement av_strireplace add av_strireplace te

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread James Almer
On 4/5/2017 11:05 AM, Steven Liu wrote: > 2017-04-03 20:32 GMT+08:00 Nicolas George : > >> Le quartidi 14 germinal, an CCXXV, Steven Liu a écrit : >>> change name from av_strreplace to av_strireplace >>> Use AVBprint to implement av_strireplace >>> add av_strireplace test case TEST_STRIREPLACE >>>

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-05 Thread Steven Liu
2017-04-03 20:32 GMT+08:00 Nicolas George : > Le quartidi 14 germinal, an CCXXV, Steven Liu a écrit : > > change name from av_strreplace to av_strireplace > > Use AVBprint to implement av_strireplace > > add av_strireplace test case TEST_STRIREPLACE > > > > Signed-off-by: Steven Liu > > --- > >

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-03 Thread Nicolas George
Le quartidi 14 germinal, an CCXXV, Steven Liu a écrit : > change name from av_strreplace to av_strireplace > Use AVBprint to implement av_strireplace > add av_strireplace test case TEST_STRIREPLACE > > Signed-off-by: Steven Liu > --- > libavutil/avstring.c | 76 > +++--

[FFmpeg-devel] [PATCH v3] avutil/avstring: improve av_strreplace implement

2017-04-02 Thread Steven Liu
change name from av_strreplace to av_strireplace Use AVBprint to implement av_strireplace add av_strireplace test case TEST_STRIREPLACE Signed-off-by: Steven Liu --- libavutil/avstring.c | 76 +++--- libavutil/avstring.h | 2 +- libavutil/test