Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Limin Wang
On Tue, Apr 21, 2020 at 04:21:38PM +0200, Nicolas George wrote: > Limin Wang (12020-04-21): > > Thanks, I'll try to build the tool to use. By the ffmpeg trace log, the > > difference is frag flags of tfhd: > > The trace log is still seeing things from the inside. If there is a bug > after the trac

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Limin Wang
On Tue, Apr 21, 2020 at 05:34:09PM +0300, Jan Ekström wrote: > On Tue, Apr 21, 2020 at 5:19 PM Limin Wang wrote: > > > > On Tue, Apr 21, 2020 at 04:52:16PM +0300, Jan Ekström wrote: > > > On Tue, Apr 21, 2020 at 4:19 PM Limin Wang wrote: > > > > > > > > On Tue, Apr 21, 2020 at 01:08:05PM +0200, N

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Jan Ekström
On Tue, Apr 21, 2020 at 5:19 PM Limin Wang wrote: > > On Tue, Apr 21, 2020 at 04:52:16PM +0300, Jan Ekström wrote: > > On Tue, Apr 21, 2020 at 4:19 PM Limin Wang wrote: > > > > > > On Tue, Apr 21, 2020 at 01:08:05PM +0200, Nicolas George wrote: > > > > Limin Wang (12020-04-21): > > > > > OK, belo

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Nicolas George
Limin Wang (12020-04-21): > Thanks, I'll try to build the tool to use. By the ffmpeg trace log, the > difference is frag flags of tfhd: The trace log is still seeing things from the inside. If there is a bug after the trace point, it will not be detected. It is important to test the RESULTING FILE

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Limin Wang
On Tue, Apr 21, 2020 at 04:52:16PM +0300, Jan Ekström wrote: > On Tue, Apr 21, 2020 at 4:19 PM Limin Wang wrote: > > > > On Tue, Apr 21, 2020 at 01:08:05PM +0200, Nicolas George wrote: > > > Limin Wang (12020-04-21): > > > > OK, below is the commit log, please help to review whether it's your > >

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Jan Ekström
On Tue, Apr 21, 2020 at 4:19 PM Limin Wang wrote: > > On Tue, Apr 21, 2020 at 01:08:05PM +0200, Nicolas George wrote: > > Limin Wang (12020-04-21): > > > OK, below is the commit log, please help to review whether it's your > > > expected log: > > > > > > NOTE about the testing effect: > > > subti

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Nicolas George
Limin Wang (12020-04-21): > I have checked with one of non-empty-moov.mp4, and have observed one byte > difference > only(02 and 01). I haven't tool to dump every box in detail. If you think > it's necessary, > I can looked at the movenc muxer further and figure out which field it's. You can

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Limin Wang
On Tue, Apr 21, 2020 at 01:08:05PM +0200, Nicolas George wrote: > Limin Wang (12020-04-21): > > OK, below is the commit log, please help to review whether it's your > > expected log: > > > > NOTE about the testing effect: > > subtitle packet will be marked as keyframe, it'll change below testing

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Nicolas George
Limin Wang (12020-04-21): > OK, below is the commit log, please help to review whether it's your expected > log: > > NOTE about the testing effect: > subtitle packet will be marked as keyframe, it'll change below testing > reference > files: > tests/ref/fate/binsub-movtextenc and tests/ref/fate/

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Limin Wang
On Tue, Apr 21, 2020 at 12:35:39PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-04-21): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/internal.h | 2 + > > libavformat/mux.c| 7 +++- > > tests/ref/fate/binsub-movtexten

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread Nicolas George
lance.lmw...@gmail.com (12020-04-21): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/internal.h | 2 + > libavformat/mux.c| 7 +++- > tests/ref/fate/binsub-movtextenc | 2 +- > tests/ref/fate/movenc| 50 +++ > te

[FFmpeg-devel] [PATCH v3 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-21 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/internal.h | 2 + libavformat/mux.c| 7 +++- tests/ref/fate/binsub-movtextenc | 2 +- tests/ref/fate/movenc| 50 +++ tests/ref/fate/sub2video | 86