Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-08-26 Thread Ramiro Polla
On Sat, Aug 24, 2024 at 1:06 PM Stefan Oltmanns via ffmpeg-devel wrote: > Am 23.08.24 um 14:25 schrieb Ramiro Polla: > > > > I finally managed to test the patches on a real Windows system. > > > > They both look good to me, I'll apply them in a couple of days if > > there are no other comments. A

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-08-24 Thread Stefan Oltmanns via ffmpeg-devel
Am 23.08.24 um 14:25 schrieb Ramiro Polla: I finally managed to test the patches on a real Windows system. They both look good to me, I'll apply them in a couple of days if there are no other comments. It would be helpful to write a page in the trac wiki with a basic howto and common pitfalls.

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-08-23 Thread Ramiro Polla
On Tue, Jul 30, 2024 at 4:12 PM Ramiro Polla wrote: > On Mon, Jul 29, 2024 at 5:56 AM Stefan Oltmanns via ffmpeg-devel > wrote: > > Am 28.07.24 um 15:15 schrieb Ramiro Polla: > > > I think calling win32_dlopen() with a full path will be problematic for > > > systems without KB2533623. win32_dlope

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-08-11 Thread Stefan Oltmanns via ffmpeg-devel
Am 30.07.24 um 16:12 schrieb Ramiro Polla: On Mon, Jul 29, 2024 at 5:56 AM Stefan Oltmanns via ffmpeg-devel wrote: Am 28.07.24 um 15:15 schrieb Ramiro Polla: I think calling win32_dlopen() with a full path will be problematic for systems without KB2533623. win32_dlopen() might need to be fixed

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-30 Thread Ramiro Polla
On Mon, Jul 29, 2024 at 5:56 AM Stefan Oltmanns via ffmpeg-devel wrote: > Am 28.07.24 um 15:15 schrieb Ramiro Polla: > > I think calling win32_dlopen() with a full path will be problematic for > > systems without KB2533623. win32_dlopen() might need to be fixed in a > > separate patch. > > Yes, wi

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-28 Thread Stefan Oltmanns via ffmpeg-devel
Am 28.07.24 um 15:15 schrieb Ramiro Polla: +    void *vslibrary = NULL; +#ifdef _WIN32 +    const HKEY hkeys[] = {HKEY_CURRENT_USER, HKEY_LOCAL_MACHINE}; +    LONG r; +    WCHAR vss_path[512]; +    DWORD buf_size = sizeof(vss_path) - 2; +    char *vss_path_utf8; +    int i; + +    for (i = 0; i <

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-28 Thread Ramiro Polla
On 2024-07-23 16:59, Stefan Oltmanns via ffmpeg-devel wrote: This is the second part for loading the library at runtime, changes compared to previous patch revisions: -No atexit anymore -No global states anymore -Moved the registry read for Windows from a separate function inside the function

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-23 Thread Stefan Oltmanns via ffmpeg-devel
This is the second part for loading the library at runtime, changes compared to previous patch revisions: -No atexit anymore -No global states anymore -Moved the registry read for Windows from a separate function inside the function to load the dynamic library and simplified it, reducing the amou