Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-18 Thread Tobias Rapp
On 17.11.2016 21:34, James Almer wrote: On 11/17/2016 5:11 PM, Carl Eugen Hoyos wrote: 2016-11-16 15:02 GMT+01:00 Michael Niedermayer : On Wed, Nov 16, 2016 at 12:15:28PM +0100, Carl Eugen Hoyos wrote: Hi! Attached patch improves output for some ffv1 files imo. Current slowdown for the existi

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Hendrik Leppkes
Am 17.11.2016 22:16 schrieb "Paul B Mahol" : > > On 11/17/16, Michael Niedermayer wrote: > > On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: > >> 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > >> > On 16 November 2016 at 11:15, Carl Eugen Hoyos > >> > wrote: > >> > > >> >>

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Paul B Mahol
On 11/17/16, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: >> 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : >> > On 16 November 2016 at 11:15, Carl Eugen Hoyos >> > wrote: >> > >> >> Hi! >> >> >> >> Attached patch improves output for some ffv1

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 4:11 PM, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: > > 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > > > On 16 November 2016 at 11:15, Carl Eugen Hoyos > wrote: > > > > > >> Hi! > > >> > > >> Attached patch i

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: > 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > > On 16 November 2016 at 11:15, Carl Eugen Hoyos wrote: > > > >> Hi! > >> > >> Attached patch improves output for some ffv1 files imo. > >> Current slowdown for the existing deco

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi Carl, On Thu, Nov 17, 2016 at 3:10 PM, Carl Eugen Hoyos wrote: > 2016-11-17 19:34 GMT+01:00 Ronald S. Bultje : > > Carl, the reason the patch is wrong is that luma range does not scale up > > from 16< > This is documented in numerous places, see e.g. > > https://msdn.microsoft.com/en-us/libra

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread James Almer
On 11/17/2016 5:11 PM, Carl Eugen Hoyos wrote: > 2016-11-16 15:02 GMT+01:00 Michael Niedermayer : >> On Wed, Nov 16, 2016 at 12:15:28PM +0100, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch improves output for some ffv1 files imo. >>> Current slowdown for the existing decode-line timer is >

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread wm4
On Thu, 17 Nov 2016 21:16:13 +0100 Carl Eugen Hoyos wrote: > 2016-11-17 0:49 GMT+01:00 Kieran Kunhya : > >> > >> It was lossless before and is lossless after the patch but it > >> output the 16bit format that you don't like and of which you > >> claim it breaks with find_best_pix_fmt() - I still

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread wm4
On Thu, 17 Nov 2016 21:10:34 +0100 Carl Eugen Hoyos wrote: > Hi! > > 2016-11-17 19:34 GMT+01:00 Ronald S. Bultje : > > > > On Thu, Nov 17, 2016 at 1:06 PM, Kieran Kunhya wrote: > > >> Furthermore I will be reverting this patch in two hours. > > > > There's no need to wait two hours, the pa

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread wm4
On Thu, 17 Nov 2016 21:06:33 +0100 Carl Eugen Hoyos wrote: > 2016-11-17 19:06 GMT+01:00 Kieran Kunhya : > > On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > > > Furthermore I will be reverting this patch in two hours. > > Please do not revert a patch reviewed by the maintainer. "probab

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
2016-11-16 15:02 GMT+01:00 Michael Niedermayer : > On Wed, Nov 16, 2016 at 12:15:28PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch improves output for some ffv1 files imo. >> Current slowdown for the existing decode-line timer is >> 2%, I wonder if this can be improved through refacto

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
Hi! 2016-11-17 19:34 GMT+01:00 Ronald S. Bultje : > > On Thu, Nov 17, 2016 at 1:06 PM, Kieran Kunhya wrote: >> Furthermore I will be reverting this patch in two hours. > > There's no need to wait two hours, the patch is fundamentally wrong. This is not a helpful comment. > Carl, the reason the

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
2016-11-17 0:49 GMT+01:00 Kieran Kunhya : >> >> It was lossless before and is lossless after the patch but it >> output the 16bit format that you don't like and of which you >> claim it breaks with find_best_pix_fmt() - I still believe this >> should be trivial to fix. >> >> Currently white is gray

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > On 16 November 2016 at 11:15, Carl Eugen Hoyos wrote: > >> Hi! >> >> Attached patch improves output for some ffv1 files imo. >> Current slowdown for the existing decode-line timer is >> 2%, I wonder if this can be improved through refactoring. >>

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
2016-11-17 19:06 GMT+01:00 Kieran Kunhya : > On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > Furthermore I will be reverting this patch in two hours. Please do not revert a patch reviewed by the maintainer. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 1:06 PM, Kieran Kunhya wrote: > On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > > > On Wed, 16 Nov 2016 at 23:49 Kieran Kunhya wrote: > > > > It was lossless before and is lossless after the patch but it > > output the 16bit format that you don't like and of whi

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Kieran Kunhya
On Wed, 16 Nov 2016 at 23:49 Kieran Kunhya wrote: > It was lossless before and is lossless after the patch but it > output the 16bit format that you don't like and of which you > claim it breaks with find_best_pix_fmt() - I still believe this > should be trivial to fix. > > Currently white is gra

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Kieran Kunhya
On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > On Wed, 16 Nov 2016 at 23:49 Kieran Kunhya wrote: > > It was lossless before and is lossless after the patch but it > output the 16bit format that you don't like and of which you > claim it breaks with find_best_pix_fmt() - I still believe this

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Rostislav Pehlivanov
On 16 November 2016 at 11:15, Carl Eugen Hoyos wrote: > Hi! > > Attached patch improves output for some ffv1 files imo. > Current slowdown for the existing decode-line timer is > 2%, I wonder if this can be improved through refactoring. > > Please comment, Carl Eugen > > _

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-16 Thread Kieran Kunhya
> > It was lossless before and is lossless after the patch but it > output the 16bit format that you don't like and of which you > claim it breaks with find_best_pix_fmt() - I still believe this > should be trivial to fix. > > Currently white is gray, the patch tries to fix this. > erm...in what w

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-16 Thread Michael Niedermayer
On Wed, Nov 16, 2016 at 12:15:28PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch improves output for some ffv1 files imo. > Current slowdown for the existing decode-line timer is > 2%, I wonder if this can be improved through refactoring. > > Please comment, Carl Eugen > ffv1dec.c |

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-16 Thread Carl Eugen Hoyos
2016-11-16 12:38 GMT+01:00 Hendrik Leppkes : > On Wed, Nov 16, 2016 at 12:15 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch improves output for some ffv1 files imo. >> Current slowdown for the existing decode-line timer is >> 2%, I wonder if this can be improved through refactoring. >> >>

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-16 Thread Hendrik Leppkes
On Wed, Nov 16, 2016 at 12:15 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch improves output for some ffv1 files imo. > Current slowdown for the existing decode-line timer is > 2%, I wonder if this can be improved through refactoring. > > Please comment, Carl Eugen > Isn't ffv1 lossless? Ho

[FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-16 Thread Carl Eugen Hoyos
Hi! Attached patch improves output for some ffv1 files imo. Current slowdown for the existing decode-line timer is 2%, I wonder if this can be improved through refactoring. Please comment, Carl Eugen From e4e8277d4f0daeb9f61c2da9ebb167a084b1b93c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos D