Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-28 Thread Derek Buitenhuis
On 27/08/2020 19:13, Dale Curtis wrote: > Bump to get this applied. Thanks! Done. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-req

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-27 Thread Dale Curtis
Bump to get this applied. Thanks! - dale On Wed, Aug 19, 2020 at 6:13 AM Michael Niedermayer wrote: > On Tue, Aug 18, 2020 at 02:04:04PM +0100, Derek Buitenhuis wrote: > > On 18/08/2020 04:57, Dale Curtis wrote: > > > Can't be an else statement since the prior clause modifies is_complete. > > >

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-19 Thread Michael Niedermayer
On Tue, Aug 18, 2020 at 02:04:04PM +0100, Derek Buitenhuis wrote: > On 18/08/2020 04:57, Dale Curtis wrote: > > Can't be an else statement since the prior clause modifies is_complete. > > Ah, you're right. > > New version LGTM. if someone applies this, please add a "avformat/mov: " or equivalent

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-18 Thread Derek Buitenhuis
On 18/08/2020 04:57, Dale Curtis wrote: > Can't be an else statement since the prior clause modifies is_complete. Ah, you're right. New version LGTM. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmp

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-17 Thread Dale Curtis
On Mon, Aug 17, 2020 at 12:12 PM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > Patch lacks the context for stream_size here - will it always be > correct? Only asking since the check for the coede below this will > have changed from avio_size(pb) to stream_size. > stream_size == avio_si

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-17 Thread Derek Buitenhuis
On 13/08/2020 23:03, Dale Curtis wrote: > A few popular sites have started generating MP4 files which have a > sidx plus an mfra. The sidx accounts for all size except the mfra, > so the old code did not mark the fragment index as complete. > > Instead we can just check if there's an mfra and if i

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-17 Thread Dale Curtis
Bump. Thanks for consideration! - dale On Thu, Aug 13, 2020 at 3:03 PM Dale Curtis wrote: > A few popular sites have started generating MP4 files which have a > sidx plus an mfra. The sidx accounts for all size except the mfra, > so the old code did not mark the fragment index as complete. > >

[FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-13 Thread Dale Curtis
A few popular sites have started generating MP4 files which have a sidx plus an mfra. The sidx accounts for all size except the mfra, so the old code did not mark the fragment index as complete. Instead we can just check if there's an mfra and if its size makes up the difference we can mark the in