Re: [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-16 Thread Martin Storsjö
> On Feb 16, 2022, at 18:32, nil-admir...@mailo.com wrote: > > Previously there was GetModuleFileNameA. wchartoansi is used to match old > behaviour. I can replace it with wchartoutf8 if you wish. Oh, right. Well yes - if the path later is going to end up in a codepath that expects it to be

Re: [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-16 Thread Martin Storsjö
On Wed, 16 Feb 2022, nihil-admirari wrote: --- fftools/cmdutils.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 4b50e15..ea78897 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -62,6

Re: [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-18 Thread Martin Storsjö
On Thu, 17 Feb 2022, nil-admir...@mailo.com wrote: if the path later is going to end up in a codepath that expects it to be UTF8 (please do check!), then we should go that way instead I checked. datadir ends up in (cmdutils.c:2104) base[2] = datadir; and base[*] are later used in

Re: [FFmpeg-devel] [PATCH] swscale: Take the destination range into account for yuv->rgb->yuv conversions

2022-02-19 Thread Martin Storsjö
On Sat, 19 Feb 2022, Michael Niedermayer wrote: On Fri, Feb 18, 2022 at 04:45:46PM +0200, Martin Storsjö wrote: The range parameters need to be set up before calling sws_init_context (which selects which fastpaths can be used; this gets called by sws_getContext); solely passing them via

[FFmpeg-devel] [PATCH] hevcdec: Correctly signal AVCOL_RANGE_UNSPECIFIED if nothing was set in the bitstream

2022-02-17 Thread Martin Storsjö
This matches what the H264 decoder signals for such a case. Signed-off-by: Martin Storsjö --- libavcodec/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 8d7a4f7147..01d459984f 100644 --- a/libavcodec/hevcdec.c +++ b

Re: [FFmpeg-devel] [PATCH] hevcdec: Correctly signal AVCOL_RANGE_UNSPECIFIED if nothing was set in the bitstream

2022-02-17 Thread Martin Storsjö
On Thu, 17 Feb 2022, Hendrik Leppkes wrote: On Thu, Feb 17, 2022 at 1:54 PM Martin Storsjö wrote: This matches what the H264 decoder signals for such a case. Signed-off-by: Martin Storsjö --- libavcodec/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 05/13] libavcodec: Split version.h

2022-02-25 Thread Martin Storsjö
On Fri, 25 Feb 2022, Michael Niedermayer wrote: On Wed, Feb 23, 2022 at 04:29:43PM +0200, Martin Storsjö wrote: This avoids including version.h in all source files, avoiding unnecessary rebuilds when the version number is bumped. Only version_major.h is included by the main header, which

Re: [FFmpeg-devel] [PATCH 05/13] libavcodec: Split version.h

2022-02-25 Thread Martin Storsjö
On Fri, 25 Feb 2022, Andreas Rheinhardt wrote: Martin Storsjö: On Fri, 25 Feb 2022, Michael Niedermayer wrote: On Wed, Feb 23, 2022 at 04:29:43PM +0200, Martin Storsjö wrote: This avoids including version.h in all source files, avoiding unnecessary rebuilds when the version number is bumped

[FFmpeg-devel] [PATCH] swscale: Take the destination range into account for yuv->rgb->yuv conversions

2022-02-18 Thread Martin Storsjö
ons between different YUV color spaces. Signed-off-by: Martin Storsjö --- libswscale/utils.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 7c8e1bbdde..34f7f0b869 100644 --- a/libswscale/utils.c +++ b/libswscale/util

Re: [FFmpeg-devel] [PATCH] arm64: Add Armv8.3-A PAC support to assembly files

2022-02-22 Thread Martin Storsjö
On Mon, 14 Feb 2022, Andre Kempe wrote: This patch adds optional support for Arm Pointer Authentication Codes. PAC support is turned on or off at compile time using additional compiler flags. Unless any of these is enabled explicitly, no additional code will be emitted at all. Signed-off-by:

Re: [FFmpeg-devel] [PATCH 08/19] avutil/audio_fifo: Avoid avutil.h inclusion

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavutil/audio_fifo.c | 7 +-- libavutil/audio_fifo.h | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) LGTM // Martin ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 16/19] avutil/display: Don't include avutil.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavutil/display.c | 1 + libavutil/display.h | 1 - libavutil/tests/display.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) LGTM // Martin

Re: [FFmpeg-devel] [PATCH 15/19] avutil/integer: Don't include common.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavutil/integer.c | 4 +++- libavutil/integer.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) LGTM // Martin ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 14/19] avutil/pixelutils: Don't include common.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavutil/pixelutils.h | 1 - 1 file changed, 1 deletion(-) LGTM // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 13/19] avutil/samplefmt: Don't include attributes.h, avutil.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavutil/samplefmt.c | 6 -- libavutil/samplefmt.h | 3 --- 2 files changed, 4 insertions(+), 5 deletions(-) LGTM // Martin ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 12/19] avutil/imgutils: Don't include avutil.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: It is a remnant of an FF_API_* inclusion (back from when they were in avutil.h and not in version.h). Signed-off-by: Andreas Rheinhardt --- libavutil/imgutils.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) LGTM // Martin

Re: [FFmpeg-devel] [PATCH 17/19] Remove obsolete version.h inclusions

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Forgotten in e7bd47e657bbf9e1ce9915e93bc80cb1a29fb7f3. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc2enc.c| 2 +- libavcodec/x86/blockdsp_init.c | 2 -- libavfilter/internal.h | 1 - libavfilter/vf_swapuv.c| 1 -

Re: [FFmpeg-devel] [PATCH 18/19] avutil/avassert: Don't include avutil.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavcodec/dct.c | 2 ++ libavcodec/mpegaudiodec_common.c | 1 + libavcodec/mqcenc.c | 2 ++ libavcodec/put_bits.h | 1 + libavcodec/rdft.c | 1 +

[FFmpeg-devel] [PATCH 04/13] libavdevice: Remove unnecessary includes of version.h

2022-02-23 Thread Martin Storsjö
--- libavdevice/android_camera.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavdevice/android_camera.c b/libavdevice/android_camera.c index f089d1b6f9..1934999c18 100644 --- a/libavdevice/android_camera.c +++ b/libavdevice/android_camera.c @@ -43,8 +43,6 @@ #include

[FFmpeg-devel] [PATCH 08/13] libpostproc: Split version.h

2022-02-23 Thread Martin Storsjö
--- fftools/cmdutils.c | 1 + fftools/ffprobe.c | 1 + libpostproc/Makefile| 1 + libpostproc/postprocess.c | 1 + libpostproc/postprocess.h | 2 +- libpostproc/version.h | 3 ++- libpostproc/version_major.h | 31 +++ 7 files

[FFmpeg-devel] [PATCH 06/13] libavformat: Split version.h

2022-02-23 Thread Martin Storsjö
--- fftools/cmdutils.c| 1 + fftools/ffprobe.c | 1 + libavdevice/pulse_audio_dec.c | 1 + libavdevice/pulse_audio_enc.c | 1 + libavformat/Makefile | 1 + libavformat/avformat.h| 2 +- libavformat/avio.h| 2 +- libavformat/flacenc.c

[FFmpeg-devel] [PATCH 05/13] libavcodec: Split version.h

2022-02-23 Thread Martin Storsjö
This avoids including version.h in all source files, avoiding unnecessary rebuilds when the version number is bumped. Only version_major.h is included by the main header, which defines availability of e.g. FF_API_* macros, and which is bumped much less often. --- fftools/cmdutils.c |

[FFmpeg-devel] [PATCH 10/13] libswscale: Split version.h

2022-02-23 Thread Martin Storsjö
--- fftools/cmdutils.c| 1 + fftools/ffprobe.c | 1 + libswscale/Makefile | 1 + libswscale/swscale.h | 2 +- libswscale/swscale_internal.h | 1 - libswscale/utils.c| 1 + libswscale/version.h | 9 ++---

[FFmpeg-devel] [PATCH 09/13] libswresample: Split version.h

2022-02-23 Thread Martin Storsjö
--- fftools/cmdutils.c| 1 + fftools/ffprobe.c | 1 + libswresample/Makefile| 1 + libswresample/swresample.c| 1 + libswresample/swresample.h| 2 +- libswresample/version.h | 3 ++- libswresample/version_major.h | 31

[FFmpeg-devel] [PATCH] Remove mentions of a nonexistent avversion.h

2022-02-23 Thread Martin Storsjö
Signed-off-by: Martin Storsjö --- .gitignore | 1 - Makefile | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 1a5bb29ad5..f06d853edf 100644 --- a/.gitignore +++ b/.gitignore @@ -36,7 +36,6 @@ /config.asm /config.h /coverage.info

Re: [FFmpeg-devel] [PATCH 11/19] avutil/eval: Don't include avutil.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: It has been added for an FF_API_* at a time when these were in avutil.h. Signed-off-by: Andreas Rheinhardt --- libavutil/eval.h | 2 -- 1 file changed, 2 deletions(-) LGTM // Martin ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 09/19] avutil/fifo: Don't include avutil.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavutil/fifo.c | 5 - libavutil/fifo.h | 4 +++- libavutil/threadmessage.c | 2 ++ 3 files changed, 9 insertions(+), 2 deletions(-) LGTM // Martin

Re: [FFmpeg-devel] [PATCH 10/19] avutil/file: Don't include avutil.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavutil/file.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) LGTM // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 19/19] Remove unnecessary libavutil/(avutil|common|internal).h inclusions

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Some of these were made possible by moving several common macros to libavutil/macros.h. While just at it, also improve the other headers a bit. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3.c | 3 ++-

[FFmpeg-devel] [PATCH] configure: Fix detecting/using getauxval

2022-02-23 Thread Martin Storsjö
While trying to detect getauxval, this actually never output HAVE_GETAUXVAL into config.h before. Signed-off-by: Martin Storsjö --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 4f30140221..d4502ba90c 100755 --- a/configure +++ b/configure @@ -2266,6

[FFmpeg-devel] [PATCH 11/13] libavfilter: Split version.h

2022-02-23 Thread Martin Storsjö
--- fftools/cmdutils.c | 1 + fftools/ffprobe.c | 1 + libavfilter/Makefile| 1 + libavfilter/avfilter.c | 1 + libavfilter/avfilter.h | 2 +- libavfilter/internal.h | 1 - libavfilter/version.h | 13 ++-- libavfilter/version_major.h |

[FFmpeg-devel] [PATCH 13/13] configure: Use a separate config_components.h header for $ALL_COMPONENTS

2022-02-23 Thread Martin Storsjö
This avoids unnecessary rebuilds of most source files if only the list of enabled components has changed, but not the other properties of the build, set in config.h. --- configure | 17 +++-- fftools/ffplay.c | 1 + libavcodec/8svx.c

[FFmpeg-devel] [PATCH 07/13] libavdevice: Split version.h

2022-02-23 Thread Martin Storsjö
--- fftools/cmdutils.c | 1 + fftools/ffprobe.c | 1 + libavdevice/Makefile| 1 + libavdevice/avdevice.c | 1 + libavdevice/avdevice.h | 2 +- libavdevice/version.h | 10 ++ libavdevice/version_major.h | 37

[FFmpeg-devel] [PATCH 12/13] doc: Add an entry to APIchanges about no longer implicitly including version.h

2022-02-23 Thread Martin Storsjö
--- doc/APIchanges | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index ea402f6118..adbfc79e13 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -14,6 +14,12 @@ libavutil: 2021-04-27 API changes, most recent first: +2022-*-* - xx - all

Re: [FFmpeg-devel] [PATCH 07/19] avutil/log: Don't include avutil.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: It has been included since af5f434f8c0fb3b4ee3b206ebc1946ca660a8abe for deprecation reasons, but removing it has been forgotten after it had served is purpose. So remove it. For convenience, include version.h instead as LIBAVUTIL_VERSION_INT is

[FFmpeg-devel] [PATCH v2] swscale: Take the destination range into account for yuv->rgb->yuv conversions

2022-02-23 Thread Martin Storsjö
ons between different YUV color spaces. Signed-off-by: Martin Storsjö --- libswscale/utils.c| 11 --- tests/fate/libswscale.mak | 16 tests/ref/fate/sws-yuv-colorspace | 6 ++ tests/ref/fate/sws-yuv-range | 6 ++ 4 files changed,

Re: [FFmpeg-devel] [PATCH 17/19] Remove obsolete version.h inclusions

2022-02-23 Thread Martin Storsjö
On Wed, 23 Feb 2022, Andreas Rheinhardt wrote: Martin Storsjö: On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Forgotten in e7bd47e657bbf9e1ce9915e93bc80cb1a29fb7f3. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc2enc.c    | 2 +- libavcodec/x86/blockdsp_init.c | 2 -- libavfilter

[FFmpeg-devel] [PATCH v2] configure: Fix detecting/using getauxval

2022-02-23 Thread Martin Storsjö
While trying to detect getauxval, this actually never output HAVE_GETAUXVAL into config.h before. Signed-off-by: Martin Storsjö --- Fixed the alphabetical ordering. --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 4f30140221..e8fdb3813d 100755

[FFmpeg-devel] [PATCH 00/13] [RFC] Reduce unnecessary recompilation

2022-02-23 Thread Martin Storsjö
dependencies that I haven't tested.) In practice, this reduces the number of rebuilt source files from 1979 to 193, if there's a change to the list of enabled components but not to the rest of config.h. What do you think - is it worth the slight churn to avoid pointless rebuilds? Martin

[FFmpeg-devel] [PATCH 01/13] libavutil: Remove leftover uses of version.h

2022-02-23 Thread Martin Storsjö
These headers probably have used defines like FF_API_* before, but no longer do that, and doesn't directly seem to use anything else from that header either. --- libavutil/common.h | 1 - libavutil/internal.h | 1 - 2 files changed, 2 deletions(-) diff --git a/libavutil/common.h

[FFmpeg-devel] [PATCH 03/13] libavformat: Remove unnecessary includes of version.h

2022-02-23 Thread Martin Storsjö
This header probably has used defines like FF_API_* before, but no longer do that, and doesn't directly seem to use anything else from that header either. --- libavformat/url.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/url.h b/libavformat/url.h index a129150d76..3cfe3ecc5c

[FFmpeg-devel] [PATCH 02/13] libavcodec: Remove unnecessary includes of version.h

2022-02-23 Thread Martin Storsjö
These files probably have used defines like FF_API_* before, but no longer do that, and doesn't directly seem to use anything else from that header either. --- libavcodec/mediacodec.c | 1 - libavcodec/mediacodec_wrapper.c | 1 - libavcodec/x86/blockdsp_init.c | 1 - libavcodec/xvmc.h

Re: [FFmpeg-devel] [PATCH 06/19] avformat/avio: Don't include common.h

2022-02-23 Thread Martin Storsjö
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/avio.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index cd63322a62..ca970b1ce3 100644 --- a/libavformat/avio.h +++

Re: [FFmpeg-devel] [PATCH] fix build, avcodec: update OpenH264 header path

2022-03-01 Thread Martin Storsjö
On Tue, 1 Mar 2022, Daniel Pocock wrote: On 01/03/2022 14:27, Martin Storsjö wrote: On Tue, 1 Mar 2022, Daniel Pocock wrote: On 01/03/2022 10:19, Hendrik Leppkes wrote: On Tue, Mar 1, 2022 at 9:16 AM Daniel Pocock wrote: This updates the locations searched for the OpenH264 headers

Re: [FFmpeg-devel] [PATCH] fix build, avcodec: update OpenH264 header path

2022-03-01 Thread Martin Storsjö
On Tue, 1 Mar 2022, Daniel Pocock wrote: On 01/03/2022 10:19, Hendrik Leppkes wrote: On Tue, Mar 1, 2022 at 9:16 AM Daniel Pocock wrote: This updates the locations searched for the OpenH264 headers to be consistent with upstream Discussed here:

[FFmpeg-devel] [PATCH] libavfilter: vf_scale: Properly take in->color_range into account

2022-03-03 Thread Martin Storsjö
on the latest frame (which should trigger reconfiguring the scaler if the input frame ranges change). Signed-off-by: Martin Storsjö --- To test this (without risking running many conflicting swscale filters in one filter pipeline), we'd need to be able to tag the incoming raw yuv data with colorsp

Re: [FFmpeg-devel] [PATCH v2] configure: Fix detecting/using getauxval

2022-03-04 Thread Martin Storsjö
On Wed, 23 Feb 2022, Martin Storsjö wrote: While trying to detect getauxval, this actually never output HAVE_GETAUXVAL into config.h before. Signed-off-by: Martin Storsjö --- Fixed the alphabetical ordering. --- configure | 1 + 1 file changed, 1 insertion(+) Pushed. // Martin

Re: [FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations

2022-03-21 Thread Martin Storsjö
On Mon, 21 Mar 2022, Ben Avison wrote: On 19/03/2022 23:06, Martin Storsjö wrote: As you are writing assembly for these functions, I would very much appreciate if you could add checkasm tests for all the functions you're implementing. I see that there exists a test for the blockdsp functions

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/vc1: Introduce fast path for unescaping bitstream buffer

2022-03-21 Thread Martin Storsjö
On Mon, 21 Mar 2022, Ben Avison wrote: On 18/03/2022 19:10, Andreas Rheinhardt wrote: Ben Avison: +static int vc1_unescape_buffer_neon(const uint8_t *src, int size, uint8_t *dst) +{ +/* Dealing with starting and stopping, and removing escape bytes, are + * comparatively less

Re: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs

2022-03-25 Thread Martin Storsjö
On Tue, 22 Mar 2022, ke...@muxable.com wrote: From: Kevin Wang 7-bit PictureIDs are not supported by WebRTC: https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA In practice, 15-bit PictureIDs offer better compatibility. Signed-off-by: Kevin Wang --- libavformat/rtpenc_vp8.c | 3 ++- 1

Re: [FFmpeg-devel] [PATCH 06/10] avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths

2022-03-25 Thread Martin Storsjö
On Fri, 25 Mar 2022, Lynne wrote: 25 Mar 2022, 19:52 by bavi...@riscosopen.org: +@ VC-1 in-loop deblocking filter for 4 pixel pairs at boundary of vertically-neighbouring blocks +@ On entry: +@ r0 -> top-left pel of lower block +@ r1 = row stride, bytes +@ r2 = PQUANT bitstream

Re: [FFmpeg-devel] [GAS-PP PATCH] Handle the aarch64 tbnz intruction in the same way as tbz, for armasm64

2022-03-25 Thread Martin Storsjö
On Mon, 21 Mar 2022, Martin Storsjö wrote: --- I'll apply in a couple days if there's no comments. --- gas-preprocessor.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Pushed. // Martin ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/10] checkasm: Add vc1dsp in-loop deblocking filter tests

2022-03-25 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: Note that the benchmarking results for these functions are highly dependent upon the input data. Therefore, each function is benchmarked twice, corresponding to the best and worst case complexity of the reference C implementation. The performance of a real

[FFmpeg-devel] [PATCH] test: tiny_ssim: Don't include config.h

2022-03-26 Thread Martin Storsjö
NULL". Signed-off-by: Martin Storsjö --- tests/tiny_ssim.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/tiny_ssim.c b/tests/tiny_ssim.c index 08f8e92a03..9740652288 100644 --- a/tests/tiny_ssim.c +++ b/tests/tiny_ssim.c @@ -27,7 +27,6 @@ * overlapped 8x8 block sums, rather than th

Re: [FFmpeg-devel] [PATCH] test: tiny_ssim: Don't include config.h

2022-03-30 Thread Martin Storsjö
On Sun, 27 Mar 2022, Martin Storsjö wrote: tiny_ssim is built for the build host, not for the target platform. Therefore, it mustn't include the config.h header, which is set up specifically for the target platform and compiler. This fixes cross building for older WinStore platforms, where

Re: [FFmpeg-devel] [PATCH] vc1dsp: Change remaining stride parameters to ptrdiff_t

2022-03-30 Thread Martin Storsjö
On Tue, 29 Mar 2022, Ben Avison wrote: On 29/03/2022 13:44, Martin Storsjö wrote: The existing x86 assembly for loop filters uses the stride as a full register without clearing/sign extending the upper half of the registers on x86_64. This avoids crashes if the caller would have passed

Re: [FFmpeg-devel] [PATCH 06/10] avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. Note that the C version can still outperform the NEON version in specific cases. The balance between different code paths is stream-dependent, but in practice the best case happens about 5% of the

Re: [FFmpeg-devel] [PATCH 05/10] avcodec/vc1: Arm 64-bit NEON deblocking filter fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. Note that the C version can still outperform the NEON version in specific cases. The balance between different code paths is stream-dependent, but in practice the best case happens about 5% of the

Re: [FFmpeg-devel] [PATCH 06/10] avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. Note that the C version can still outperform the NEON version in specific cases. The balance between different code paths is stream-dependent, but in practice the best case happens about 5% of the

Re: [FFmpeg-devel] [PATCH 08/10] avcodec/idctdsp: Arm 64-bit NEON block add and clamp fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. idctdsp.add_pixels_clamped_c: 323.0 idctdsp.add_pixels_clamped_neon: 41.5 idctdsp.put_pixels_clamped_c: 243.0 idctdsp.put_pixels_clamped_neon: 30.0 idctdsp.put_signed_pixels_clamped_c: 225.7

Re: [FFmpeg-devel] [PATCH 07/10] avcodec/vc1: Arm 64-bit NEON inverse transform fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. vc1dsp.vc1_inv_trans_4x4_c: 158.2 vc1dsp.vc1_inv_trans_4x4_neon: 65.7 vc1dsp.vc1_inv_trans_4x4_dc_c: 86.5 vc1dsp.vc1_inv_trans_4x4_dc_neon: 26.5 vc1dsp.vc1_inv_trans_4x8_c: 335.2

Re: [FFmpeg-devel] [PATCH 07/10] avcodec/vc1: Arm 64-bit NEON inverse transform fast paths

2022-03-30 Thread Martin Storsjö
On Wed, 30 Mar 2022, Martin Storsjö wrote: On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. vc1dsp.vc1_inv_trans_4x4_c: 158.2 vc1dsp.vc1_inv_trans_4x4_neon: 65.7 vc1dsp.vc1_inv_trans_4x4_dc_c: 86.5 vc1dsp.vc1_inv_trans_4x4_dc_neon: 26.5

Re: [FFmpeg-devel] [PATCH 10/10] avcodec/vc1: Arm 32-bit NEON unescape fast path

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. vc1dsp.vc1_unescape_buffer_c: 918624.7 vc1dsp.vc1_unescape_buffer_neon: 142958.0 Signed-off-by: Ben Avison --- libavcodec/arm/vc1dsp_init_neon.c | 61 +++ libavcodec/arm/vc1dsp_neon.S

Re: [FFmpeg-devel] [PATCH 09/10] avcodec/vc1: Arm 64-bit NEON unescape fast path

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. vc1dsp.vc1_unescape_buffer_c: 655617.7 vc1dsp.vc1_unescape_buffer_neon: 118237.0 Signed-off-by: Ben Avison --- libavcodec/aarch64/vc1dsp_init_aarch64.c | 61

Re: [FFmpeg-devel] [PATCH 04/10] avcodec/vc1: Introduce fast path for unescaping bitstream buffer

2022-03-29 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: void ff_vc1dsp_init(VC1DSPContext* c); diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c index 0823ccad31..0ab5892403 100644 --- a/tests/checkasm/vc1dsp.c +++ b/tests/checkasm/vc1dsp.c @@ -286,6 +286,20 @@ static matrix

Re: [FFmpeg-devel] [PATCH 03/10] checkasm: Add idctdsp add/put-pixels-clamped tests

2022-03-29 Thread Martin Storsjö
On Tue, 29 Mar 2022, Ben Avison wrote: Thirdly - the added test also occasionally fails for the other existing functions (armv6, neon) and the newly added aarch64 neon version. If you have e.g. src[] = 32767, dst[] = 255, then the widening 8->16 addition will overflow, as there's no operation

[FFmpeg-devel] [PATCH v2] vc1dsp: Change remaining stride parameters to ptrdiff_t

2022-03-29 Thread Martin Storsjö
-by: Martin Storsjö --- Updated function signatures in the mips code too, updated the left_stride/right_stride parameters in the vc1_h_s_overlap function too, updated the comments in the x86 assembly. --- libavcodec/mips/vc1dsp_mips.h| 20 ++-- libavcodec/mips/vc1dsp_mmi.c

Re: [FFmpeg-devel] [PATCH 04/10] avcodec/vc1: Introduce fast path for unescaping bitstream buffer

2022-03-31 Thread Martin Storsjö
On Thu, 31 Mar 2022, Ben Avison wrote: On 29/03/2022 21:37, Martin Storsjö wrote: On Fri, 25 Mar 2022, Ben Avison wrote: As with the rest of the checkasm tests - please unmacro most things where possible (except for the RANDOMIZE_* macros, those are ok to keep macroed if you want

Re: [FFmpeg-devel] [PATCH 07/10] avcodec/vc1: Arm 64-bit NEON inverse transform fast paths

2022-03-31 Thread Martin Storsjö
On Thu, 31 Mar 2022, Ben Avison wrote: On 30/03/2022 14:49, Martin Storsjö wrote: Looks generally reasonable. Is it possible to factorize out the individual transforms (so that you'd e.g. invoke the same macro twice in the 8x8 and 4x4 functions) without too much loss? There is a close

Re: [FFmpeg-devel] [PATCH 05/10] avcodec/vc1: Arm 64-bit NEON deblocking filter fast paths

2022-03-31 Thread Martin Storsjö
On Thu, 31 Mar 2022, Ben Avison wrote: On 30/03/2022 13:35, Martin Storsjö wrote: Overall, the code looks sensible to me. Would it make sense to share the core of the filter between the horizontal/vertical cases with e.g. a macro? (I didn't check in detail if there's much differences

Re: [FFmpeg-devel] [PATCH 08/10] avcodec/idctdsp: Arm 64-bit NEON block add and clamp fast paths

2022-03-31 Thread Martin Storsjö
On Thu, 31 Mar 2022, Ben Avison wrote: On 30/03/2022 15:14, Martin Storsjö wrote: On Fri, 25 Mar 2022, Ben Avison wrote: +// Clamp 16-bit signed block coefficients to signed 8-bit (biased by 128) +// On entry: +//   x0 -> array of 64x 16-bit coefficients +//   x1 -> 8-bit results +/

Re: [FFmpeg-devel] [PATCH v3 00/10] avcodec/vc1: Arm optimisations

2022-03-31 Thread Martin Storsjö
On Thu, 31 Mar 2022, Ben Avison wrote: The VC1 decoder was missing lots of important fast paths for Arm, especially for 64-bit Arm. This submission fills in implementations for all functions where a fast path already existed and the fallback C implementation was taking 1% or more of the

Re: [FFmpeg-devel] [PATCH v3 00/10] avcodec/vc1: Arm optimisations

2022-04-01 Thread Martin Storsjö
On Fri, 1 Apr 2022, Martin Storsjö wrote: On Thu, 31 Mar 2022, Ben Avison wrote: The VC1 decoder was missing lots of important fast paths for Arm, especially for 64-bit Arm. This submission fills in implementations for all functions where a fast path already existed and the fallback C

Re: [FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations

2022-03-19 Thread Martin Storsjö
Hi Ben, On Thu, 17 Mar 2022, Ben Avison wrote: The VC1 decoder was missing lots of important fast paths for Arm, especially for 64-bit Arm. This submission fills in implementations for all functions where a fast path already existed and the fallback C implementation was taking 1% or more of

Re: [FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations

2022-03-19 Thread Martin Storsjö
On Sun, 20 Mar 2022, Martin Storsjö wrote: The other main issue I'd like to request is to indent the assembly similarly to the rest of the existing assembly. For the 32 bit assembly, your patches do match the surrounding code, but for the 64 bit assembly, your patches align the operands

Re: [FFmpeg-devel] [PATCH 01/10] checkasm: Add vc1dsp in-loop deblocking filter tests

2022-03-29 Thread Martin Storsjö
On Mon, 28 Mar 2022, Ben Avison wrote: On 25/03/2022 22:53, Martin Storsjö wrote: On Fri, 25 Mar 2022, Ben Avison wrote: +#define CHECK_LOOP_FILTER(func) \ +    do

Re: [FFmpeg-devel] [PATCH 02/10] checkasm: Add vc1dsp inverse transform tests

2022-03-29 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: This test deliberately doesn't exercise the full range of inputs described in the committee draft VC-1 standard. It says: input coefficients in frequency domain, D, satisfy -2048 <= D < 2047 intermediate coefficients, E, satisfy-4096 <=

[FFmpeg-devel] [PATCH] vc1dsp: Change remaining stride parameters to ptrdiff_t

2022-03-29 Thread Martin Storsjö
-by: Martin Storsjö --- libavcodec/vc1dsp.c | 20 ++-- libavcodec/vc1dsp.h | 16 libavcodec/x86/vc1dsp_init.c | 16 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/libavcodec/vc1dsp.c b/libavcodec/vc1dsp.c index

Re: [FFmpeg-devel] [PATCH 01/10] checkasm: Add vc1dsp in-loop deblocking filter tests

2022-03-29 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: Note that the benchmarking results for these functions are highly dependent upon the input data. Therefore, each function is benchmarked twice, corresponding to the best and worst case complexity of the reference C implementation. The performance of a real

Re: [FFmpeg-devel] [PATCH 03/10] checkasm: Add idctdsp add/put-pixels-clamped tests

2022-03-29 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: Disable ff_add_pixels_clamped_arm, which was found to fail the test. As this is normally only used for Arms prior to Armv6 (ARM11) it seems quite unlikely that anyone is still using this, so I haven't put in the effort to debug it. I had a look at this

Re: [FFmpeg-devel] [PATCH 01/10] checkasm: Add vc1dsp in-loop deblocking filter tests

2022-03-29 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: Note that the benchmarking results for these functions are highly dependent upon the input data. Therefore, each function is benchmarked twice, corresponding to the best and worst case complexity of the reference C implementation. The performance of a real

Re: [FFmpeg-devel] [PATCH 03/10] checkasm: Add idctdsp add/put-pixels-clamped tests

2022-03-29 Thread Martin Storsjö
On Tue, 29 Mar 2022, Martin Storsjö wrote: On Fri, 25 Mar 2022, Ben Avison wrote: Disable ff_add_pixels_clamped_arm, which was found to fail the test. As this is normally only used for Arms prior to Armv6 (ARM11) it seems quite unlikely that anyone is still using this, so I haven't put

[FFmpeg-devel] [GAS-PP PATCH] Handle the aarch64 tbnz intruction in the same way as tbz, for armasm64

2022-03-21 Thread Martin Storsjö
--- I'll apply in a couple days if there's no comments. --- gas-preprocessor.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 67b130e..59c93c1 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -943,7 +943,7 @@

Re: [FFmpeg-devel] [PATCH] avutil: use getauxval on linux/android for CPU capabilities

2022-02-04 Thread Martin Storsjö
On Fri, 4 Feb 2022, Aman Karmani wrote: From: Aman Karmani fixes #6578 Signed-off-by: Aman Karmani --- libavutil/arm/cpu.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) It would be good if the commit message actually explained the upsides to doing this. It's

Re: [FFmpeg-devel] [PATCH] configure: Fix Microsoft tools detection

2022-02-03 Thread Martin Storsjö
On Thu, 3 Feb 2022, Marvin Scholz wrote: On 3 Feb 2022, at 13:33, Martin Storsjö wrote: On Thu, 3 Feb 2022, Marvin Scholz wrote: On 3 Feb 2022, at 12:55, Hendrik Leppkes wrote: On Thu, Feb 3, 2022 at 12:34 PM Martin Storsjö wrote: I remember that there has been some variance

Re: [FFmpeg-devel] [PATCH] configure: Fix Microsoft tools detection

2022-02-03 Thread Martin Storsjö
On Thu, 3 Feb 2022, Marvin Scholz wrote: On 3 Feb 2022, at 12:55, Hendrik Leppkes wrote: On Thu, Feb 3, 2022 at 12:34 PM Martin Storsjö wrote: I remember that there has been some variance throughout the versions for exactly what MSVC prints as the identification thoughout the versions

Re: [FFmpeg-devel] [PATCH] configure: Fix Microsoft tools detection

2022-02-03 Thread Martin Storsjö
On Thu, 3 Feb 2022, Kacper Michajlow wrote: On Wed, 26 Jan 2022 at 15:00, Martin Storsjö wrote: Hi, On Sat, 22 Jan 2022, Kacper Michajłow wrote: LLVM tools print installation path upon execution. If one uses LLVM tools bundled with Microsoft Visual Studio installation, they would

Re: [FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end

2022-02-03 Thread Martin Storsjö
On Fri, 21 Jan 2022, Andreas Rheinhardt wrote: Interesting: There is indeed a delay at the start (720 samples in a quick test) compared to the native AAC decoder. Furthermore, the current code is buggy, as it believes that avcodec->time_base to be the time_base of the returned AVFrames (it is

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/aarch64: add hevc epel assembly

2022-02-07 Thread Martin Storsjö
On Thu, 3 Feb 2022, J. Dekker wrote: Thanks: Rafal Dabrowa --- libavcodec/aarch64/Makefile |3 +- libavcodec/aarch64/hevcdsp_epel_neon.S| 2501 + libavcodec/aarch64/hevcdsp_init_aarch64.c | 52 + 3 files changed, 2555 insertions(+), 1 deletion(-) create

Re: [FFmpeg-devel] [PATCH] configure: Fix Microsoft tools detection

2022-02-07 Thread Martin Storsjö
On Thu, 3 Feb 2022, Marvin Scholz wrote: On 3 Feb 2022, at 12:55, Hendrik Leppkes wrote: On Thu, Feb 3, 2022 at 12:34 PM Martin Storsjö wrote: On Thu, 3 Feb 2022, Kacper Michajlow wrote: On Wed, 26 Jan 2022 at 15:00, Martin Storsjö wrote: Hi, On Sat, 22 Jan 2022, Kacper Michajłow

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/aarch64: add hevc qpel assembly

2022-02-07 Thread Martin Storsjö
On Thu, 3 Feb 2022, J. Dekker wrote: Thanks: Rafal Dabrowa --- libavcodec/aarch64/Makefile |1 + libavcodec/aarch64/hevcdsp_init_aarch64.c | 67 + libavcodec/aarch64/hevcdsp_qpel_neon.S| 2799 + 3 files changed, 2867 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH] aarch64: h264dsp: Fix incorrectly indented code

2022-02-07 Thread Martin Storsjö
Signed-off-by: Martin Storsjö --- This should reduce the risk of anyone accidentally writing new code based on an incorrect example. --- libavcodec/aarch64/h264dsp_neon.S | 176 +++--- 1 file changed, 88 insertions(+), 88 deletions(-) diff --git a/libavcodec/aarch64

Re: [FFmpeg-devel] [PATCH] aarch64: h264dsp: Fix incorrectly indented code

2022-02-11 Thread Martin Storsjö
On Mon, 7 Feb 2022, Martin Storsjö wrote: Signed-off-by: Martin Storsjö --- This should reduce the risk of anyone accidentally writing new code based on an incorrect example. --- libavcodec/aarch64/h264dsp_neon.S | 176 +++--- 1 file changed, 88 insertions(+), 88

[FFmpeg-devel] [GASPP PATCH] Filter out -D parameters from the call to GCC/Clang to assemble

2022-01-18 Thread Martin Storsjö
Clang warns about unused -D parameters when operating on .s files (or if invoked with "-x assembler") while GCC doesn't. --- As noobdy else than me essentially maintains gas-preprocessor, I'll go ahead and push this after a couple days if nobody speaks up. --- gas-preprocessor.pl | 4 1 file

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix endian-dependent parsing

2022-01-21 Thread Martin Storsjö
On Fri, 21 Jan 2022, Andreas Rheinhardt wrote: MOVAtom.type is always read as a little-endian number (despite MOV/ISOBMFF being big-endian). Fixes the matroska-dovi-write-config8 FATE-test on big-endian arches (which runs into the "index out of range" warning message). Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end

2022-01-21 Thread Martin Storsjö
On Fri, 21 Jan 2022, Andreas Rheinhardt wrote: Martin Storsjö: Also trim off delay samples at the start instead of adjusting pts to compensate for them; this avoids unwanted offsets if working with raw samples without considering their pts. --- libavcodec/libfdk-aacdec.c | 80

Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

2022-01-07 Thread Martin Storsjö
On Fri, 7 Jan 2022, Martin Storsjö wrote: On Wed, 5 Jan 2022, Martin Storsjö wrote: While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630d31fb7db02

Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

2022-01-06 Thread Martin Storsjö
On Wed, 5 Jan 2022, Martin Storsjö wrote: While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630d31fb7db02, which later was reverted). --- libavcodec

[FFmpeg-devel] [PATCH 2/2] libfdk-aacdec: Flush delayed samples at the end

2022-01-19 Thread Martin Storsjö
Also trim off delay samples at the start instead of adjusting pts to compensate for them; this avoids unwanted offsets if working with raw samples without considering their pts. --- libavcodec/libfdk-aacdec.c | 80 +++--- 1 file changed, 65 insertions(+), 15

[FFmpeg-devel] [PATCH 1/2] libfdk-aacdec: Add an option for setting the decoder's DRC album mode

2022-01-19 Thread Martin Storsjö
--- libavcodec/libfdk-aacdec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libfdk-aacdec.c b/libavcodec/libfdk-aacdec.c index ffa1fdcce3..93b52023b0 100644 --- a/libavcodec/libfdk-aacdec.c +++ b/libavcodec/libfdk-aacdec.c @@ -56,6 +56,7 @@ typedef struct

<    2   3   4   5   6   7   8   9   10   11   >