Re: globalValue in parallel

2016-04-27 Thread Keller, Trevor (Fed)
Looking into the rest of the FiPy source, we're already calling allgather(sendobj) in several places, and rarely calling allgather(sendobj, recvobj). To preserve the existing function calls (all of which are lower-case) and mess with the code the least, removing the recvobj argument appears to b

Re: globalValue in parallel

2016-04-27 Thread Guyer, Jonathan E. Dr. (Fed)
It sounds like you're volunteering to put together the pull request with appropriate tests > On Apr 27, 2016, at 4:06 PM, Keller, Trevor (Fed) > wrote: > > The mpi4py commit mentions that the receive object is no longer needed for > the lower-case form of the commands. Browsing the full sourc

Re: globalValue in parallel

2016-04-27 Thread Keller, Trevor (Fed)
The mpi4py commit mentions that the receive object is no longer needed for the lower-case form of the commands. Browsing the full source shows that the upper-case commands retain both the send and receive objects. To avoid deviating too far from the MPI standard, I'd like to suggest changing the

Re: globalValue in parallel

2016-04-27 Thread Guyer, Jonathan E. Dr. (Fed)
It looks like 'recvobj' was removed from mpi4py about two years ago: https://bitbucket.org/mpi4py/mpi4py/commits/3d8503a11d320dd1c3030ec0dbce95f63b0ba602 but I'm not sure when it made it into the released version. It looks like you can safely edit fipy/tools/comms/mpi4pyCommWrapper.py to rem

Re: understanding convection terms

2016-04-27 Thread Daniel Wheeler
On Tue, Apr 26, 2016 at 10:57 AM, Kris Kuhlman wrote: > Daniel, > > Thank you. I am a bit surprised that the CentralDifference basically matches > the hybrid method, and is more accurate than upwind. Remember that central difference is second order accurate. The other schemes are first order. Of

globalValue in parallel

2016-04-27 Thread Kris Kuhlman
I built the trilinos-capable version of fipy. It seems to work for serial (even for a non-trivial case), but I am getting errors with more than one processor with a simple call to globalValue(), which I was trying to use to make a plot by gathering the results to procID==0 I used the latest git ve