Re: Slope limiter methods in FiPy & VanLeerConvectionTerm

2013-03-25 Thread Daniel Wheeler
Jason, FYI, the changes have been committed back to the "develop" branch. See http://matforge.org/fipy/ticket/564 and http://matforge.org/fipy/changeset/5b1957aad/fipy. On Thu, Mar 21, 2013 at 12:39 PM, Jason Furtney wrote: > Daniel, > > Thanks for the reply and go ahead and make the changes.

Re: Slope limiter methods in FiPy & VanLeerConvectionTerm

2013-03-21 Thread Jason Furtney
Daniel, Thanks for the reply and go ahead and make the changes. Also the lines, self.CFL = interiorCFL / vol1 self.CFL = numerix.maximum(interiorCFL / vol2, self.CFL) in VanLeerConvectionTerm._getOldAdjacentValues() do not seem to do anything. I will have a look at the Riemann b

Re: Slope limiter methods in FiPy & VanLeerConvectionTerm

2013-03-21 Thread Daniel Wheeler
On Thu, Mar 21, 2013 at 8:59 AM, Jonathan Guyer wrote: > > > File a ticket at http://matforge.org/fipy/newticket. If you're fixing a > bug, then file a "defect" ticket about the bug; if you're adding a new > feature, then an "enhancement" ticket; etc. Then paste the result of `git > request-pull

Re: Slope limiter methods in FiPy & VanLeerConvectionTerm

2013-03-21 Thread Daniel Wheeler
On Wed, Mar 20, 2013 at 6:06 PM, Jason Furtney wrote: > Hi, > > Thanks again for the great software. I have been looking at linear > advection problems with FiPy and I ran into a couple issues. > > The FiPy VanLeerConvectionTerm seems to implement the MinMod slope > limiter as described in "Finit

Re: Slope limiter methods in FiPy & VanLeerConvectionTerm

2013-03-21 Thread Jonathan Guyer
On Mar 20, 2013, at 6:06 PM, Jason Furtney wrote: > Thanks again for the great software. I have been looking at linear > advection problems with FiPy and I ran into a couple issues. > > The FiPy VanLeerConvectionTerm seems to implement the MinMod slope > limiter as described in "Finite Volume Me