Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-09 Thread Ben Allison
Dave Yeo wrote: Yes that makes sense. Requiring a C99 compliant compiler seems quite reasonable. Well I'm actually going to be even more reasonable than that. The only bits of C99 that flac will really require is header file with C99 standard width integers (int8_t, uint8_t, int16_t etc). Erik

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-09 Thread LRN
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09.02.2012 21:41, Ben Allison wrote: Dave Yeo wrote: Yes that makes sense. Requiring a C99 compliant compiler seems quite reasonable. Well I'm actually going to be even more reasonable than that. The only bits of C99 that flac will really

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-09 Thread JonY
On 2/10/2012 02:14, LRN wrote: On 09.02.2012 21:41, Ben Allison wrote: Dave Yeo wrote: Yes that makes sense. Requiring a C99 compliant compiler seems quite reasonable. Well I'm actually going to be even more reasonable than that. The only bits of C99 that flac will really require is header

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-08 Thread Dave Yeo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/08/12 01:32 am, Erik de Castro Lopo wrote: Dave Yeo wrote: Another try Actually there are still some issues with this patch, mainly around your changes to incluce/FLAC/ordinals.h. This file is a public header file and hence, your

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-08 Thread Erik de Castro Lopo
Dave Yeo wrote: Yes that makes sense. Requiring a C99 compliant compiler seems quite reasonable. Well I'm actually going to be even more reasonable than that. The only bits of C99 that flac will really require is header file with C99 standard width integers (int8_t, uint8_t, int16_t etc).

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-07 Thread JonY
On 2/8/2012 03:33, Dave Yeo wrote: On 02/07/12 12:03 am, Erik de Castro Lopo wrote: Dave Yeo wrote: This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that klibc contains so many improvements I

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-07 Thread Erik de Castro Lopo
JonY wrote: On 2/8/2012 03:33, Dave Yeo wrote: On 02/07/12 12:03 am, Erik de Castro Lopo wrote: Dave Yeo wrote: This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that klibc contains so

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-07 Thread Dave Yeo
On 02/07/12 02:08 pm, JonY wrote: On 2/8/2012 03:33, Dave Yeo wrote: On 02/07/12 12:03 am, Erik de Castro Lopo wrote: Dave Yeo wrote: This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that

[flac-dev] [PATCH] Remove even more CPP hackery

2012-02-06 Thread Dave Yeo
This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that klibc contains so many improvements I think this is exceptable. --- include/FLAC/ordinals.h | 17 + src/flac/main.c