Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-05-06 Thread Josh Coalson
> From: Josh Coalson >To: Earl Chew ; "flac-dev@xiph.org" >Sent: Tuesday, May 1, 2012 8:25:34 PM >Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to >completion > > >Ah, I don't remember but it might have been a ne

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-05-02 Thread Earl Chew
25:34 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Ah, I don't remember but it might have been a negative test that was supposed to give an error when used with the wrong sample rate. Anyway, could you do another patch that updates

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-05-01 Thread Josh Coalson
on ; "flac-dev@xiph.org" >Sent: Thursday, April 26, 2012 3:12 PM >Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to >completion > > >Josh, > > >I see my name is mentioned in passing ;-) > > >I submitted that patch becaus

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-04-26 Thread Earl Chew
From: Earl Chew >To: "flac-dev@xiph.org" >Sent: Thursday, January 5, 2012 8:27 PM >Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to >completion > > >When reading the INDEX from the cue sheet, the format MM:SS:FF format is >disallowed

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-04-25 Thread Erik de Castro Lopo
Josh Coalson wrote: > > From: Erik de Castro Lopo > > To: flac-dev@xiph.org > > Cc: Josh Coalson > > Sent: Wednesday, April 25, 2012 4:30 PM > > Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to > > completion > > > >

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-04-25 Thread Josh Coalson
> From: Erik de Castro Lopo > To: flac-dev@xiph.org > Cc: Josh Coalson > Sent: Wednesday, April 25, 2012 4:30 PM > Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to > completion > > Josh Coalson wrote: > >> I haven't checked git

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-04-25 Thread Erik de Castro Lopo
Josh Coalson wrote: > I haven't checked git yet but I hope this patch has not gone in.  I > don't like the special case that this is creating. > > It would be better to allow MM:SS everywhere but I consider that low priority. I modified version of that patch did go in. See the following commits:

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-04-25 Thread Josh Coalson
ac-dev@xiph.org" >Sent: Thursday, January 5, 2012 8:27 PM >Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to >completion > > >When reading the INDEX from the cue sheet, the format MM:SS:FF format is >disallowed if the sample frequency is not a multiple o

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-02-03 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > Ok, using a bit of git bisect magic, I find that if your cuesheet patch > had been applied on top of commit 19e3918d4e, then this patch: > > commit ce8a75134cace056f6c436d54b57bad1a1d93797 > Author: Erik de Castro Lopo > Date: Wed Feb 1 20:34:04 2012 +1

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-02-03 Thread Erik de Castro Lopo
Earl Chew wrote: > Erik, > > My working view has this as the last commit: > > commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16 > Author: David Schleef > Date:   Thu Aug 25 18:40:29 2011 -0700 > >     Fix md5 structure clearing in previous commit > > > > Using this, test_metaflac.sh runs clea

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-02-03 Thread Earl Chew
have any more insight ? Earl From: Earl Chew To: "flac-dev@xiph.org" Sent: Thursday, February 2, 2012 8:50:17 AM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Erik, I'll resync and have anot

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-02-02 Thread Earl Chew
Erik, I'll resync and have another look. Earl From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Wednesday, February 1, 2012 10:30:21 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Earl

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-02-01 Thread Erik de Castro Lopo
Earl Chew wrote: > When reading the INDEX from the cue sheet, the format MM:SS:FF format > is disallowed if the sample frequency is not a multiple of 75 because > the index would only be approximate. However, 00:00:00 is _exact_ because > it denotes the start of the track, so allow it as a special

[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-01-11 Thread Earl Chew
When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows meta

[Flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-01-06 Thread Earl Chew
When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows meta