zero checkstyle/findbugs warnings!!

2011-01-19 Thread Glenn Adams
i just fast forwarded 31 checkins into my copy of trunk and built, tested, checked styles and ran findbugs, and ZERO style errors or findbugs warnings are reported!! i'm very happy to see that we are now paying attention to code quality testing in a real way, so congratulations dev team! best rega

DO NOT REPLY [Bug 50483] [PATCH] Full font embedding and Subset embedding in Post Script

2011-01-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483 Mehdi Houshmand changed: What|Removed |Added Attachment #26504|0 |1 is obsolete|

Re: OpenType font library [was: Re: How much work is needed for FOP to support OpenType fonts?]

2011-01-19 Thread Glenn Adams
I think we are taking the only reasonable route available w.r.t. complex script support, namely reading the OTF font directly to extract and use the advanced typographic tables. The same mechanisms can be used for the TTF AAT tables as well. The inquiry that started this thread seems most interest

RE: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread Eric Douglas
Did you read what I wrote? The simple answer is don't use postscript. Is there a particular reason you must use the postscript format? I tried getting the output in postscript format and it didn't turn out well. I believe they said to use that format you should only use type 1 fonts. If you ge

Re: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread mehdi houshmand
Hi Eric, I'm afraid it's not that simple, PostScript doens't accept a byte stream as PDF does. In order to embed fonts into a PostScript document, the font must be streamed to an ASCII hexadecimal stream. As you can imagine, this bloats the size quite significantly, and imagine if you have several

RE: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread Eric Douglas
I'd like to know what sort of document you're trying to print and what sort of printer you're using if it won't accept a truetype font. I only print truetype fonts (lucida typewriter) with FOP and I have no problems printing to brand new lasers or dot matrix which are at least 10 years old. I don't

Re: color issues [was: OpenType font library]

2011-01-19 Thread Craig Ringer
On 19/01/11 19:13, Jeremias Maerki wrote: > Craig, you might want to try out the color branches for which I've just > started to vote to merge it into trunk. The color branch adds Named > Color (separation, spot color) support and CIE Lab support. > > However, ICC and device CMYK colors should alr

Re: color issues [was: OpenType font library]

2011-01-19 Thread Jeremias Maerki
Craig, you might want to try out the color branches for which I've just started to vote to merge it into trunk. The color branch adds Named Color (separation, spot color) support and CIE Lab support. However, ICC and device CMYK colors should already work in FOP Trunk/1.0. Could you maybe elaborat

Re: OpenType font library [was: Re: How much work is needed for FOP to support OpenType fonts?]

2011-01-19 Thread Jeremias Maerki
I agree, native libraries would be a pain. BTW, interested parties could take a look at Apache FontBox's CFF support. That's part of Apache PDFBox. Maybe that could be used or adapted. On 19.01.2011 11:59:18 Craig Ringer wrote: > On 19/01/11 16:35, Simon Pepping wrote: > > I take this discussion t

Re: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread Craig Ringer
On 19/01/11 18:38, Chris Bowditch wrote: > On 18/01/2011 23:11, Glenn Adams wrote: > > Hi Glenn/Ivan, > > Most of the Open type Fonts I come across seem to have CFF glyph data > which FOP cannot currently support. We find this limitation very > annoying and have looked into developing this featur

Re: OpenType font library [was: Re: How much work is needed for FOP to support OpenType fonts?]

2011-01-19 Thread Craig Ringer
On 19/01/11 16:35, Simon Pepping wrote: > I take this discussion to express my worries that FOP needs to create > its own support for fonts, among which Open Type Fonts. FOP's core > task is the layout and printing of FO files. If FOP could rely on good > font libraries, that would make our code ba

[VOTE] Merge FOP color branch into trunk

2011-01-19 Thread Jeremias Maerki
I've cleaned up the color branch, tweaked a few things and did some more testing. I'm happy with the current state, so I'm calling for a vote to merge the current FOP color branch into trunk. https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_Color +1 from me, obviously. Jeremias Mae

Re: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread Chris Bowditch
On 18/01/2011 23:11, Glenn Adams wrote: Hi Glenn/Ivan, Most of the Open type Fonts I come across seem to have CFF glyph data which FOP cannot currently support. We find this limitation very annoying and have looked into developing this feature. We haven't started the work though, but did esti

Re: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread mehdi houshmand
Jeremias, They are with your /GlyphDirectory mechanism, and for full font embedding but not for subsetting with the /sfnts in my patch. And the /GlyphDirectory system was causing issues with some printers (I think IBM printers if memory serves), so it depends what you mean by supported. You'll be

Re: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread Jeremias Maerki
Mehdi, TrueType collections are supported! On 19.01.2011 10:17:11 mehdi houshmand wrote: > Hi Ivan, > > I've been looking quite a bit at the fonts packages recently, and you > are correct neither CFF nor True Type collections are currently > supported. They both need to be implemented. In terms o

Re: OpenType font library [was: Re: How much work is needed for FOP to support OpenType fonts?]

2011-01-19 Thread mehdi houshmand
Hi Simon, The FOP font library doesn't actually render or paint any fonts, it does 1 of 2 things. Either it a) creates a subset of the font, and streams the subset (as a byte stream) to the PDF/PS document or b) it streams the whole font to the document (I think this is what is done for AFP, I don

Re: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread mehdi houshmand
Oops, I seem to have copy/pasted that link twice, my apologies, it probably doesn't deserve 2 mentions. Mehdi On 19 January 2011 09:17, mehdi houshmand wrote: > Hi Ivan, > > I've been looking quite a bit at the fonts packages recently, and you > are correct neither CFF nor True Type collections

Re: How much work is needed for FOP to support OpenType fonts?

2011-01-19 Thread mehdi houshmand
Hi Ivan, I've been looking quite a bit at the fonts packages recently, and you are correct neither CFF nor True Type collections are currently supported. They both need to be implemented. In terms of how long it would take, that's a very speculative question and not quite as simple to answer as it

OpenType font library [was: Re: How much work is needed for FOP to support OpenType fonts?]

2011-01-19 Thread Simon Pepping
I take this discussion to express my worries that FOP needs to create its own support for fonts, among which Open Type Fonts. FOP's core task is the layout and printing of FO files. If FOP could rely on good font libraries, that would make our code base so much smaller and our development tasks so