https://issues.apache.org/bugzilla/show_bug.cgi?id=52089
Bug #: 52089
Summary: [PATCH] Embedding JPEG support in AFP
Product: Fop
Version: 1.0
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
On 21/10/11 08:29, Glenn Adams wrote:
On Thu, Oct 20, 2011 at 10:31 PM, Peter Hancock
peter.hanc...@gmail.comwrote:
From the surface I would have been very much in favor of supporting a
merge in the near future, however I have had the chance to review some
areas of the complex script
On 24/10/11 14:05, Glenn Adams wrote:
On Mon, Oct 24, 2011 at 8:26 PM, Georg Datterl georg.datt...@geneon.dewrote:
Hello Glenn,
(2) there is no standard for symbol length documented in FOP practice
or enforced by checkstyle; I decline to exchange my choice of symbols
with longer symbols
inline
On Wed, Oct 26, 2011 at 6:49 PM, Vincent Hennebert vhenneb...@gmail.comwrote:
On 21/10/11 08:29, Glenn Adams wrote:
On Thu, Oct 20, 2011 at 10:31 PM, Peter Hancock peter.hanc...@gmail.com
wrote:
From the surface I would have been very much in favor of supporting a
merge in the
On Mon, Oct 24, 2011 at 09:05:34PM +0800, Glenn Adams wrote:
are you claiming my code is not maintainable by other developers? if so,
then please prove it objectively; otherwise, let's stop talking about this,
and move on with the merge vote
How would one go about proving objectively that code
On Wed, Oct 26, 2011 at 8:36 PM, Peter Hancock peter.hanc...@gmail.comwrote:
On Mon, Oct 24, 2011 at 09:05:34PM +0800, Glenn Adams wrote:
are you claiming my code is not maintainable by other developers? if so,
then please prove it objectively; otherwise, let's stop talking about
this,
BTW, sometimes I choose to use longer names for local variables: see my
reimplementation of number to string conversion in
o.a.f.util.NumberConverter, which is a new (and large) class I added in the
CS branch. I use a few short names here, but not as many as longer names. So
you can see that
While you are at it, Peter, you may also take note that I have made liberal
use of *assert* in the file I reference below (NumberConverter). If we are
going to improve not only understandability but also real quality, how about
a campaign to maximize use of assertions to document code assumptions?
I wonder what you think about the code in o.a.f.hyphenation.TernaryTree,
where the author apparently did not know Java, and introduces the libc
functions strcmp, strcpy, and strlen, and which uses the Java char type
(within the String type) for coding tree pointers!
My apprehension about
On Wed, Oct 26, 2011 at 2:13 PM, Glenn Adams gl...@skynav.com wrote:
Notice also the considerable use of nested classes (and interfaces), which
tends to make the file longer, but nevertheless encapsulates abstractions in
smaller units. True, this file could be sub-divided into smaller files,
On Wed, Oct 26, 2011 at 9:34 PM, Peter Hancock peter.hanc...@gmail.comwrote:
I wonder what you think about the code in o.a.f.hyphenation.TernaryTree,
where the author apparently did not know Java, and introduces the libc
functions strcmp, strcpy, and strlen, and which uses the Java char
I haven't looked at the code in question on this particular discussion
so this is not to criticize.
Overly concise variables names should be acceptable within limited
scope.
Calling an ObjectOutputStream oos may be sufficient when it's created
and destroyed within one little method.
Using i or z
On Tue, October 25, 2011 11:29 pm, Glenn Adams wrote:
They (latin ligatures) are already enabled, so no extra work is needed.
Though this could benefit by adding support for some of the more recent
CSS3
font properties related to the use of AATs, e.g., see [1] for:
font-variant-alternates
Thanks Tony! I'll look into that. And nice to hear from you after many
years.
Best,
Glenn
On Wed, Oct 26, 2011 at 10:46 PM, Tony Graham tgra...@mentea.net wrote:
On Tue, October 25, 2011 11:29 pm, Glenn Adams wrote:
They (latin ligatures) are already enabled, so no extra work is needed.
14 matches
Mail list logo
