Re: [foreman-dev] Re: Database and Service Actions in RPM Post Scripts

2017-09-25 Thread Ivan Necas
The script sounds like a good start. If every rpm in post runs the script, and the script would be clever enough to know it it needs to run it twice or was already run in the transaction. We would have a win. Also we could have there some check (such as properly placed file somewhere), that could i

Re: [foreman-dev] Re: Database and Service Actions in RPM Post Scripts

2017-09-25 Thread Ohad Levy
On Mon, Sep 25, 2017 at 9:30 AM, Lukas Zapletal wrote: > I am all for pulling all complex changes out of post scriplets. > > On the other hand, I like that not calling an installer was always an > option, at least for minor releases. We have lots of users (mainly in > downstream) who did not buy

Re: [foreman-dev] Re: Database and Service Actions in RPM Post Scripts

2017-09-24 Thread Lukas Zapletal
I am all for pulling all complex changes out of post scriplets. On the other hand, I like that not calling an installer was always an option, at least for minor releases. We have lots of users (mainly in downstream) who did not buy into Puppet and they tend to modify lots of configs manually tryin

Re: [foreman-dev] Re: Database and Service Actions in RPM Post Scripts

2017-09-24 Thread Marek Hulán
I'd be in favor of a change and avoid running scripts in post scripts. This is the reason why we added "Optional Step 3 (C) - Run foreman-installer" to our manual [1] a long time ago. We recommend running installer after upgrade if users use it for initial setup. If this is too heavy step, maybe

[foreman-dev] Re: Database and Service Actions in RPM Post Scripts

2017-09-24 Thread Andrew Schofield
[I'm a user, not a developer] I'd suggest that the RPM's *simply* drop the files onto the file system and the installer then does the required actions. There are a lot of moving parts to foreman and restarting one component can have impact on other components. They also duplicate actions which