Re: [PATCH,Fortran 1/7] Fortran: make some trans* functions static

2021-10-24 Thread Tobias Burnus
Hi Thomas, On 25.10.21 07:47, Thomas Koenig via Fortran wrote: what you're doing seems a useful clean-up, thanks. One point for discussion: -match +static match gfc_match_label (void) I have generally understood that the gfc_ prefix is for global variables and functions only. We do not alw

Re: [PATCH,Fortran 1/7] Fortran: make some trans* functions static

2021-10-24 Thread Thomas Koenig via Fortran
Hi Bernhard, what you're doing seems a useful clean-up, thanks. One point for discussion: -match +static match gfc_match_label (void) I have generally understood that the gfc_ prefix is for global variables and functions only. We do not always adhere to it (also since some global functi

Re: [PATCH,Fortran 0/7] delete some unused decls, make static

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
On Mon, 25 Oct 2021 00:30:16 +0200 Bernhard Reutner-Fischer wrote: > Hi! > > Quickly skimming through the frontend headers. I'm also attaching the other view for the fortran FE after the header cleanup: python3 $topsrc/contrib/unused_functions.py gcc/fortran/ \ grep -v "gt_" for a guesstima

[PATCH,Fortran 1/7] Fortran: make some trans* functions static

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
From: Bernhard Reutner-Fischer This makes some trans* functions static and deletes declarations of functions that either do not exist anymore like gfc_get_function_decl or that are unused like gfc_check_any_c_kind. gcc/fortran/ChangeLog: * expr.c (is_non_empty_structure_constructor): Ma

[PATCH,Fortran 2/7] Fortran: make some match* functions static

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
From: Bernhard Reutner-Fischer gfc_match_small_int_expr was unused, delete it. gfc_match_gcc_unroll should use gfc_match_small_literal_int and then gfc_match_small_int can be deleted since it will be unused. gcc/fortran/ChangeLog: * decl.c (gfc_match_old_kind_spec, set_com_block_bind_c,

[PATCH,Fortran 5/7] Fortran: Delete unused decl in trans-stmt.h

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: * trans-stmt.h (gfc_trans_deallocate_array): Delete. --- gcc/fortran/trans-stmt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/fortran/trans-stmt.h b/gcc/fortran/trans-stmt.h index 1a24d9b4cdc..e824caf4d08 100644 --- a/gcc/

[PATCH,Fortran 4/7] Fortran: make some trans-array functions static

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: * trans-array.c (gfc_trans_scalarized_loop_end): Make static. * trans-array.h (gfc_trans_scalarized_loop_end, gfc_conv_tmp_ref, gfc_conv_array_transpose): Delete declaration. --- gcc/fortran/trans-array.c | 2 +- gcc/

[PATCH,Fortran 6/7] Fortran: Delete unused decl in trans-types.h

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: * trans-types.h (gfc_convert_function_code): Delete. --- gcc/fortran/trans-types.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/gcc/fortran/trans-types.h b/gcc/fortran/trans-types.h index 1b43503092b..3bc236cad0d 100644 ---

[PATCH,Fortran 7/7] Fortran: Delete unused decl in intrinsic.h

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: * intrinsic.h (gfc_check_sum, gfc_resolve_atan2d, gfc_resolve_kill, gfc_resolve_kill_sub): Delete declaration. --- gcc/fortran/intrinsic.h | 4 1 file changed, 4 deletions(-) diff --git a/gcc/fortran/intrinsic.h b/gcc/f

[PATCH,Fortran 3/7] Fortran: make some constructor* functions static

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
From: Bernhard Reutner-Fischer gfc_constructor_expr_foreach and gfc_constructor_swap were just stubs. gcc/fortran/ChangeLog: * constructor.c (gfc_constructor_get_base): Make static. (gfc_constructor_expr_foreach, (gfc_constructor_swap): Delete. * constructor.h (gfc_const

[PATCH,Fortran 0/7] delete some unused decls, make static

2021-10-24 Thread Bernhard Reutner-Fischer via Fortran
Hi! Quickly skimming through the frontend headers. There are a couple of declarations for functions that do not have definitions. And there are a couple of functions that can be static. Notes i took while at it / TODOs: - get rid of VTAB_GET_FIELD_GEN and unused extern decls - The last block of

Re: [PATCH] PR fortran/102917 - PDT type parameters are not restricted to default integer

2021-10-24 Thread Steve Kargl via Fortran
On Sun, Oct 24, 2021 at 09:00:52PM +0200, Harald Anlauf wrote: > Dear Fortranners, Steve, > > I've created PR 102917 for tracking this issue and packaged > the attached patch. > > Regtested on x86_64-pc-linux-gnu. OK mainline? > Thanks for picking this up. The patch looks good to me, but you

[PATCH] PR fortran/102917 - PDT type parameters are not restricted to default integer

2021-10-24 Thread Harald Anlauf via Fortran
Dear Fortranners, Steve, I've created PR 102917 for tracking this issue and packaged the attached patch. Regtested on x86_64-pc-linux-gnu. OK mainline? Thanks, Harald > Gesendet: Freitag, 22. Oktober 2021 um 22:25 Uhr > Von: "Steve Kargl" > An: "Harald Anlauf" > Cc: fortran@gcc.gnu.org > Bet