[PATCH v7 3/5] OpenMP: Pointers and member mappings

2023-08-18 Thread Julian Brown
This patch changes the mapping node arrangement used for array components of derived types in order to accommodate for changes made in the previous patch, particularly the use of "GOMP_MAP_ATTACH_DETACH" for pointer-typed derived-type members instead of "GOMP_MAP_ALWAYS_POINTER". We change the map

Re: [PATCH v7 3/5] OpenMP: Pointers and member mappings

2023-12-06 Thread Tobias Burnus
Hi Julian, LGTM, except for: * The 'target exit data' handling - comments below - looks a bit fishy/inconsistent. I intent to have a closer look with more code context, but maybe you should have a look at it as well. BTW: Fortran deep-mapping is not yet on mainline. Are you aware of changes or

Re: [PATCH v7 3/5] OpenMP: Pointers and member mappings

2023-12-07 Thread Julian Brown
Hi Tobias! On Wed, 6 Dec 2023 12:36:34 +0100 Tobias Burnus wrote: > Hi Julian, > > LGTM, except for: > > * The 'target exit data' handling - comments below - looks a bit > fishy/inconsistent. > > I intent to have a closer look with more code context, but maybe you > should have a look at it a

Re: [PATCH v7 3/5] OpenMP: Pointers and member mappings

2023-12-11 Thread Tobias Burnus
Hi Julian, On 07.12.23 18:24, Julian Brown wrote: On Wed, 6 Dec 2023 12:36:34 +0100 Tobias Burnus wrote: LGTM, except for: * The 'target exit data' handling - comments below - looks a bit fishy/inconsistent. ... Thus, I wonder whether that shouldn't be instead OMP_CLAUSE_MAP_KIND (node