zel...@holobit.net escreveu:
Quoting Luiz Americo Pereira Camara :
Mattias Gaertner escreveu:
On Tue, 26 Oct 2010 17:31:48 +0200
zeljko wrote:
One note: IntersectRect in lazarus worked OK until we decided to
use Types.IntersectRect, old implementation from GraphType looks
much better th
On Tue, Oct 26, 2010 at 8:05 PM, wrote:
> No, why ? I've fixed problems inside widgetsets.Let's propose patch for
> improving Types.IntersectRect().
I already fixed this in FPC 2.5.1+ Please verify.
--
Felipe Monteiro de Carvalho
___
fpc-devel mailli
Quoting Luiz Americo Pereira Camara :
Mattias Gaertner escreveu:
On Tue, 26 Oct 2010 17:31:48 +0200
zeljko wrote:
One note: IntersectRect in lazarus worked OK until we decided to
use Types.IntersectRect, old implementation from GraphType looks
much better than current fpc one.
Then
Quoting Mattias Gaertner :
On Tue, 26 Oct 2010 17:31:48 +0200
zeljko wrote:
On Tuesday 26 October 2010 16:57, Sergei Gorelkin wrote:
>
> Well, maybe. For me, it is rather hard to think about the
opposite - that a
> const may be passed *not* by reference - due to long-term Delphi/Windows
Mattias Gaertner escreveu:
On Tue, 26 Oct 2010 17:31:48 +0200
zeljko wrote:
One note: IntersectRect in lazarus worked OK until we decided to use
Types.IntersectRect, old implementation from GraphType looks much better than
current fpc one.
Then it is probably better to undo the chan
On Tue, 26 Oct 2010 17:31:48 +0200
zeljko wrote:
> On Tuesday 26 October 2010 16:57, Sergei Gorelkin wrote:
>
> >
> > Well, maybe. For me, it is rather hard to think about the opposite - that a
> > const may be passed *not* by reference - due to long-term Delphi/Windows
> > experience.
> >
> > B
On Tue, 26 Oct 2010, Sergei Gorelkin wrote:
Jonas Maebe пишет:
With a little testing, here are two facts:
1) Delphi 7 also shows this bug.
2) Windows.IntersectRect() does not show it, allowing 'misuses'.
So, whoever wrote the FPC function, must have been trying really hard to
achieve bug-t
On Tuesday 26 October 2010 16:57, Sergei Gorelkin wrote:
>
> Well, maybe. For me, it is rather hard to think about the opposite - that a
> const may be passed *not* by reference - due to long-term Delphi/Windows
> experience.
>
> But, after all, Types.IntersectRect and surrounding stuff were intro
Jonas Maebe пишет:
With a little testing, here are two facts:
1) Delphi 7 also shows this bug.
2) Windows.IntersectRect() does not show it, allowing 'misuses'.
So, whoever wrote the FPC function, must have been trying really hard
to achieve bug-to-bug compatibility with Delphi... or simply cop
On 26 Oct 2010, at 16:12, Sergei Gorelkin wrote:
zeljko пишет:
On Tuesday 26 October 2010 15:13, Felipe Monteiro de Carvalho wrote:
On Tue, Oct 26, 2010 at 3:14 PM, zeljko wrote:
No, I've opened an issue and Jonas closed with good explanation -
we had
misusage of IntersectRect in gtk/gtk2
zeljko пишет:
On Tuesday 26 October 2010 15:13, Felipe Monteiro de Carvalho wrote:
On Tue, Oct 26, 2010 at 3:14 PM, zeljko wrote:
No, I've opened an issue and Jonas closed with good explanation - we had
misusage of IntersectRect in gtk/gtk2 interfaces (I've fixed both) ... so
not bug.
I guess
On Tuesday 26 October 2010 15:13, Felipe Monteiro de Carvalho wrote:
> On Tue, Oct 26, 2010 at 3:14 PM, zeljko wrote:
> > No, I've opened an issue and Jonas closed with good explanation - we had
> > misusage of IntersectRect in gtk/gtk2 interfaces (I've fixed both) ... so
> > not bug.
>
> I guess
On Tue, Oct 26, 2010 at 3:14 PM, zeljko wrote:
> No, I've opened an issue and Jonas closed with good explanation - we had
> misusage of IntersectRect in gtk/gtk2 interfaces (I've fixed both) ... so not
> bug.
I guess it depends on how you see it.
Anyway, the solution would be trivial, just store
On Tuesday 26 October 2010 14:02, Felipe Monteiro de Carvalho wrote:
> IMHO it is
>
> > 2.FPC Types.IntersectRect() have bug
No, I've opened an issue and Jonas closed with good explanation - we had
misusage of IntersectRect in gtk/gtk2 interfaces (I've fixed both) ... so not
bug.
zeljko
___
On Tuesday 26 October 2010 14:02, Felipe Monteiro de Carvalho wrote:
> IMHO it is
>
> > 2.FPC Types.IntersectRect() have bug
And it's very ugly :)
I've grepped complete lazarus tree for such "misusage" of IntersectRect, but
found only same problematic code in gtk dir and fixed that.
zeljko
_
IMHO it is
> 2.FPC Types.IntersectRect() have bug
--
Felipe Monteiro de Carvalho
___
fpc-devel maillist - fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel
Hi all,
Someone reported bug in gtk2lcl which crashes lazarus ide. I've found that
intersectRect usage from types (from r 27870) makes that.
So imagine next code:
var
R, SrcRect: TRect;
begin
R := Rect(0, 0, 22, 22);
SrcRect := Rect(0, 0, 24, 24);
Types.IntersectRect(R, SrcRect, R);
e
17 matches
Mail list logo
