Re: [fpc-devel] Warning: Constructor should be public

2009-04-07 Thread Léo Willian Kölln
So, what can we do? Fill a bug report? There is one here about this: http://bugs.freepascal.org/view.php?id=11526 Closed. I see the status "resolved => closed " as wrong! It´s not resolved even if it is known and proposed! I can´t make a path now, no time... Someone here can? I don´t see this as

Re: [fpc-devel] Warning: Constructor should be public

2009-04-07 Thread Vinzent Höfler
On Mon, Apr 6, 2009 at 10:15 PM, Graeme Geldenhuys wrote: > And, i don't put an override to the constructor, so in my class the > constructor is really a virtual override of the TObject.Create? No, it's not and IMO this warning is indeed a questionable one. There are valid ("non-hack") use-case

Re: [fpc-devel] Warning: Constructor should be public

2009-04-07 Thread Léo Willian Kölln
Just to clarify the bloated code, i'm using the same code to compile on Delphi (Windows) and FPC (*nix). > I have a much easier "lazy man's" singleton for you... It's not 100%, > but then, I have *never* seen a singleton implementation in Delphi or > FPC that is 100%. Simply access the singleton

Re: [fpc-devel] Warning: Constructor should be public

2009-04-07 Thread Léo Willian Kölln
On Mon, Apr 6, 2009 at 10:15 PM, Graeme Geldenhuys wrote: > 2009/4/6 Flávio Etrusco : >> Actually, your constructor has the same signature as 'TObject.Create', >> so it should show a 'lower visibility' warning in Delphi, doesn't it? > > Correct, Delphi should also give this warning. If it was a v

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Graeme Geldenhuys
2009/4/6 Flávio Etrusco : > Actually, your constructor has the same signature as 'TObject.Create', > so it should show a 'lower visibility' warning in Delphi, doesn't it? Correct, Delphi should also give this warning. > But, indeed, FPC shows the warning (should be public) for all > constructors,

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Graeme Geldenhuys
On Mon, Apr 6, 2009 at 10:37 PM, Léo Willian Kölln wrote: > No. > See my singleton example: How did I guess it was going to be about implementing a Singleton. This issue has been raised a thousand times in FPC and Delphi circles. :) > > TLoggerGeral = class Which means you are descending from T

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Flávio Etrusco
Actually, your constructor has the same signature as 'TObject.Create', so it should show a 'lower visibility' warning in Delphi, doesn't it? But, indeed, FPC shows the warning (should be public) for all constructors, even if you're not hiding from the parent class, and I always found this a (minor)

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Léo Willian Kölln
No. See my singleton example: TLoggerGeral = class private {$IFDEF WINDOWS} class var FInstance : TLoggerGeral; {$ELSE} {$STATIC on} FInstance : TLoggerGeral; static; {$ENDIF} constructor Create; protected pCritSection: TCriticalSection; pLogarDatas : bo

Re: [fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Graeme Geldenhuys
> Simply question. Why? What did you do, try and lower the visibility of the constructor? If so, that is also not allowed in Delphi as far as I know. Regards, - Graeme - ___ fpGUI - a cross-platform Free Pascal GUI toolkit http://opensoft.homeip.n

[fpc-devel] Warning: Constructor should be public

2009-04-06 Thread Léo Willian Kölln
Simply question. Why? In Delphi i don´t need this, and on ObjPascal i don´t see why this is necessary... This warning happens even when i use the Delphi compatibility mode! Léo Willian Kölln ___ fpc-devel maillist - fpc-devel@lists.freepascal.org htt