Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-27 Thread Tomas Hajny
On Wed, March 26, 2008 14:43, Marco van de Voort wrote: On Wed, 26 Mar 2008, Graeme Geldenhuys wrote: On 26/03/2008, Michael Van Canneyt [EMAIL PROTECTED] wrote: Yes, use fully qualified names. windows.tcriticalsection. syncobjs.tcriticalsection. Why doesn't Delphi

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-27 Thread Graeme Geldenhuys
On 27/03/2008, Tomas Hajny [EMAIL PROTECTED] wrote: Maybe we could mark the declaration in unit Windows deprecated and later remove in 2.5.x (or whatever that becomes)? I think this would be a good idea. It makes no sense having two TCriticalSection definitions. Plus it's much harder to

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-27 Thread Graeme Geldenhuys
On 27/03/2008, Marco van de Voort [EMAIL PROTECTED] wrote: Yes and no, that would be the last resort solution yes, but I think here direct Delphi compat _and_ platform independence should weigh heavier than a misplaced backwards compability for which we have no indications. So my final

[fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Graeme Geldenhuys
Hi, I've noticed this ages ago and found a work-around, but never reported it. I hit the same error again today and thought this time I would mention it. In tiOPF we have some IFDEF's for the 'Windows' unit. Some units also use the 'SyncObjs' unit for critical section handling. If 'SyncObjs'

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Graeme Geldenhuys
On 26/03/2008, Michael Van Canneyt [EMAIL PROTECTED] wrote: Yes, use fully qualified names. windows.tcriticalsection. syncobjs.tcriticalsection. That should work For lower level stuff, you should use TRTLCriticalSection, never TCriticalSection. It has the advantage of being

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Michael Van Canneyt
On Wed, 26 Mar 2008, Graeme Geldenhuys wrote: Hi, I've noticed this ages ago and found a work-around, but never reported it. I hit the same error again today and thought this time I would mention it. In tiOPF we have some IFDEF's for the 'Windows' unit. Some units also use the

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Graeme Geldenhuys
On 26/03/2008, Michael Van Canneyt [EMAIL PROTECTED] wrote: Yes, use fully qualified names. windows.tcriticalsection. syncobjs.tcriticalsection. Why doesn't Delphi compiler complain about it? A quick search revealed that Delphi's Windows.pas unit doesn't contain a TCriticalSection type

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Michael Van Canneyt
On Wed, 26 Mar 2008, Graeme Geldenhuys wrote: On 26/03/2008, Michael Van Canneyt [EMAIL PROTECTED] wrote: Yes, use fully qualified names. windows.tcriticalsection. syncobjs.tcriticalsection. Why doesn't Delphi compiler complain about it? A quick search revealed that Delphi's

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Graeme Geldenhuys
On 26/03/2008, Marco van de Voort [EMAIL PROTECTED] wrote: Hmm, didn't older (6) versions simply have this, and did synobjs get introduced later? In that case, if Delphi can break compat, so can we. I think I still have my copy of Delphi 5 lying around. If I can find it, I'll see if

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Pete Cervasio
On Wednesday 26 March 2008 08:51:53 Graeme Geldenhuys wrote: On 26/03/2008, Marco van de Voort [EMAIL PROTECTED] wrote: Hmm, didn't older (6) versions simply have this, and did synobjs get introduced later? In that case, if Delphi can break compat, so can we. I think I still have my copy

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Joao Morais
Marco van de Voort wrote: On Wed, 26 Mar 2008, Graeme Geldenhuys wrote: On 26/03/2008, Michael Van Canneyt [EMAIL PROTECTED] wrote: Yes, use fully qualified names. windows.tcriticalsection. syncobjs.tcriticalsection. Why doesn't Delphi compiler complain about it? A quick search revealed

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Joao Morais
Graeme Geldenhuys wrote: For lower level stuff, you should use TRTLCriticalSection, never TCriticalSection. It has the advantage of being portable. I'm surprised you actually use the windows unit. That is Evil(tm). The code in question is the tiOPF project which is shared with Delphi

Re: [fpc-pascal] Windows unit and SyncObjs unit clash

2008-03-26 Thread Graeme Geldenhuys
On 26/03/2008, Joao Morais [EMAIL PROTECTED] wrote: What about use uses Windows under ifndef fpc? That will work for some units, but not all of them. Some units reference things in Windows unit not related to Critical Section, but I am definitely going to give this a try and see how far it