> * Running the tests of plone.app.controlpanel on a vanilla checkout of the
> plip buildout generated one failure for me (Ubuntu/packaged uncustomized
> Python 2.4):
>
> ...
>
> Set up Products.PloneTestCase.layer.PloneSite in 18.665 seconds.
> Running:
> ..
On Jan 18, 2009, at 2:44 PM, Hanno Schlichting wrote:
I'm somewhat late with creating the review buildout for PLIP 237
(Minor
i18n upgrades) at:
https://svn.plone.org/svn/plone/review/plip237-minor-i18n-upgrades/
The review notes and detailed explanation is found in the review
buildout's READM
On Fri, Jan 30, 2009 at 21:00, Ethan Jucovy wrote:
> * after seeing your reply, I tried running the tests in the PLIP buildout's
> environment with `bin/instance test -s z3c.autoinclude` and did see failures
> * i've now fixed them
Yay! :-)
> * can you reconfirm that the failures you saw were
Previously Tom Lazar wrote:
> FYI i have completed my two remaining reviews and have additionally
> reviewed #243 which was without a review.
I've fixed the problems you saw with #243.
Might I request that review comments are emailed to the PLIP author?
Wichert.
--
Wichert Akkerman It i
On Fri, Jan 30, 2009 at 20:47, Tom Lazar wrote:
> there are still outstanding reviews from raphael, witsch and mj (or have
> they perhaps not updated the pliptallies page[1]?) and IMO #243 would also
> warrant a UI review!
Hopefully I'll have some time tomorrow to finish the RR enhancements
revie
I just spent three hours writing a detailed email explaining the situation,
but gmail seems to have completely swallowed it, drafts and all, when I hit
"send". I'm travelling right now and have very limited internet
connectivity here, so I'm just going to try to briefly summarize my original
reply
FYI i have completed my two remaining reviews and have additionally
reviewed #243 which was without a review.
there are still outstanding reviews from raphael, witsch and mj (or
have they perhaps not updated the pliptallies page[1]?) and IMO #243
would also warrant a UI review!
i have inc
