On Fri, Jan 30, 2009 at 21:00, Ethan Jucovy <ethan.juc...@gmail.com> wrote: > * after seeing your reply, I tried running the tests in the PLIP buildout's > environment with `bin/instance test -s z3c.autoinclude` and did see failures > * i've now fixed them
Yay! :-) > * can you reconfirm that the failures you saw were from utils.txt? the ones > i saw were from plugin.txt (though the assertion that was triggered was > indeed the alarming one in utils.py) > * briefly, the problem was that the "foo" module in the demonstration > package i provided collided with another "foo" module that's installed in > z3c.autoinclude's test environment > (z3c.autoinclude/src/z3c/autoinclude/tests/FooPackage is the egg). moral: > namespaces are indeed a good idea. :) i've renamed the demo package to > plip247.foo and will also namespace z3c.autoinclude's test packages before > the next release so this doesn't happen again I've updated the foo.cfg buildout config to reflect this. > * the reason that assertion was so alarming and vague is because, when i > wrote the code, i had no idea what sort of situation could possibly trigger > it. so i figured i might as well throw in an assertion, even if // because i > couldn't imagine what its failure would mean. now that it's actually popped > up i think i understand it: it's asserting that no more than one > non-empty-virtual-namespace-module named "foo" (for any string "foo") will > be importable simultaneously. i'll make the assertion less alarming and > more informative as soon as i figure out a concise way to say that. Great! It's a good idea to explicitly warn about this. > * do the tests pass for you now in a fresh buildout // if you svn up and > re-install the "foo" demo package? again, they are passing for me now in > this environment, let me know if you're seeing different failures. The tests now all pass, I've upgraded my review verdict to a +1. :-) > Thanks again for taking the time to look at this, I really appreciate all of > your notes (and the buildout help!) & I'll try to be as responsive as I > possibly can. np! Thanks for your hard work on implementing the PLIP! -- Martijn Pieters _______________________________________________ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
