Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Mark Millard
On Apr 13, 2023, at 21:44, Charlie Li wrote: > Mark Millard wrote: >> FYI: in my original report for a context that has never had >> block_cloning enabled, I reported BOTH missing files and >> file content corruption in the poudriere-devel bulk build >> testing. This predates: >>

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Charlie Li
Mark Millard wrote: FYI: in my original report for a context that has never had block_cloning enabled, I reported BOTH missing files and file content corruption in the poudriere-devel bulk build testing. This predates: https://people.freebsd.org/~pjd/patches/brt_revert.patch but had the

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Mark Millard
On Apr 13, 2023, at 21:27, Charlie Li wrote: > > Pawel Jakub Dawidek wrote: >> On 4/14/23 09:23, Charlie Li wrote: >>> Pawel Jakub Dawidek wrote: Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Charlie Li
Pawel Jakub Dawidek wrote: On 4/14/23 09:23, Charlie Li wrote: Pawel Jakub Dawidek wrote: Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned blocks and keeps block_cloning feature around, so upgraded pools

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Pawel Jakub Dawidek
On 4/14/23 09:23, Charlie Li wrote: Pawel Jakub Dawidek wrote: Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned blocks and keeps block_cloning feature around, so upgraded pools can be imported and

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Mateusz Guzik
On 4/14/23, Charlie Li wrote: > Pawel Jakub Dawidek wrote: >> On 4/14/23 07:52, Charlie Li wrote: >>> Pawel Jakub Dawidek wrote: thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who already upgraded their pools.

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Charlie Li
Pawel Jakub Dawidek wrote: Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned blocks and keeps block_cloning feature around, so upgraded pools can be imported and existing cloned blocks freed. It does not

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Charlie Li
Pawel Jakub Dawidek wrote: On 4/14/23 07:52, Charlie Li wrote: Pawel Jakub Dawidek wrote: thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who already upgraded their pools. Testing with mjg@ earlier today revealed that

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Pawel Jakub Dawidek
On 4/14/23 07:52, Charlie Li wrote: Pawel Jakub Dawidek wrote: thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who already upgraded their pools. Testing with mjg@ earlier today revealed that block_cloning was not the

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Pawel Jakub Dawidek
On 4/14/23 07:40, Pawel Jakub Dawidek wrote: On 4/13/23 22:56, Cy Schubert wrote: I'm in the process of building a branch reverting the merge altogether and will test it on my sandbox machine later today. Cy, thank you for your testing and patience so far. I'm working on a patch to revert

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Charlie Li
Pawel Jakub Dawidek wrote: thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who already upgraded their pools. Testing with mjg@ earlier today revealed that block_cloning was not the cause of poudriere bulk build (and

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Charlie Li
Shawn Webb wrote: Does the ZFS project have some sort of automated testing to catch data-gobbling, pool killing bugs? It seems like this would have been caught with some CI/CD stress testing automation scripts. I can't speak about how the OpenZFS project does things, but this particular

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Pawel Jakub Dawidek
On 4/13/23 22:56, Cy Schubert wrote: I'm in the process of building a branch reverting the merge altogether and will test it on my sandbox machine later today. Cy, thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Pawel Jakub Dawidek
On 4/13/23 23:05, Shawn Webb wrote: I've learned over the years downstream that it's not really my place to tell upstream what to do or how to do it. However, I think given the seriousness of this, upstream might do well to revert the commit until a solid fix is in place. Upstream might want to

Re: aarch64: lang/gcc1* build regression between Mar-28 and Apr-8

2023-04-13 Thread Dimitry Andric
On 13 Apr 2023, at 23:42, Dima Panov wrote: > Somethings changed in main branch between Mar, 28 and Apr, 8 which causes > permanent build error for lang/gcc1[012] on aarch64 (exactly VMWare container > on M1Pro mac) > > during RTL pass: sched1 > gimple-match.cc: In function 'bool

aarch64: lang/gcc1* build regression between Mar-28 and Apr-8

2023-04-13 Thread Dima Panov
Moin-moin! Somethings changed in main branch between Mar, 28 and Apr, 8 which causes permanent build error for lang/gcc1[012] on aarch64 (exactly VMWare container on M1Pro mac) during RTL pass: sched1 gimple-match.cc: In function 'bool gimple_nop_atomic_bit_test_and_p(tree, tree_node**,

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Shawn Webb
On Thu, Apr 13, 2023 at 06:56:35AM -0700, Cy Schubert wrote: > In message om> > , Mateusz Guzik writes: > > On 4/13/23, Cy Schubert wrote: > > > On Thu, 13 Apr 2023 19:54:42 +0900 > > > Pawe=C5=82 Jakub Dawidek wrote: > > > > > >> On Apr 13, 2023, at 16:10, Cy Schubert wrote= > > : > > >> > >

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Cy Schubert
In message , Mateusz Guzik writes: > On 4/13/23, Cy Schubert wrote: > > On Thu, 13 Apr 2023 19:54:42 +0900 > > Pawe=C5=82 Jakub Dawidek wrote: > > > >> On Apr 13, 2023, at 16:10, Cy Schubert wrote= > : > >> > > >> > =EF=BB=BFIn message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Sc= >

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Mateusz Guzik
On 4/13/23, Cy Schubert wrote: > On Thu, 13 Apr 2023 19:54:42 +0900 > Paweł Jakub Dawidek wrote: > >> On Apr 13, 2023, at 16:10, Cy Schubert wrote: >> > >> > In message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Schubert >> > writes: >> > In message

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Cy Schubert
On Thu, 13 Apr 2023 19:54:42 +0900 Paweł Jakub Dawidek wrote: > On Apr 13, 2023, at 16:10, Cy Schubert wrote: > > > > In message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Schubert writes: > > In message <20230413064252.1e5c1...@slippy.cwsent.com>, Cy Schubert writes: > >> In message ,

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Mark Millard
On Apr 13, 2023, at 04:04, Charlie Li wrote: > Paweł Jakub Dawidek wrote: >> Can you please try this patch: >> >> Unfortunately I don’t see how this can happen with block cloning disabled. > This patch made no difference in poudriere; corruption still

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Charlie Li
Danilo Egea Gondolfo wrote: I'm having a funny issue here and I'm wondering if it is related. When building one of my ports I will, eventually, not always, get a file full of zeros as a result. The build will create copies of crispy-setup and, every once in a while, one of them will be a

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Charlie Li
Paweł Jakub Dawidek wrote: Can you please try this patch: Unfortunately I don’t see how this can happen with block cloning disabled. This patch made no difference in poudriere; corruption still rolled in. -- Charlie Li …nope, still don't have an

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Danilo Egea Gondolfo
On 13/04/2023 06:28, Mark Millard wrote: From: Charlie Li wrote on Date: Wed, 12 Apr 2023 20:11:16 UTC : Charlie Li wrote: Mateusz Guzik wrote: can you please test poudriere with https://github.com/openzfs/zfs/pull/14739/files After applying, on the md(4)-backed pool regardless of

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Mark Millard
On Apr 12, 2023, at 23:52, Alexander Leidinger wrote: > Quoting Mark Millard (from Wed, 12 Apr 2023 22:28:13 > -0700): > >> A fair number of errors are of the form: the build >> installing a previously built package for use in the >> builder but later the builder can not find some file >>

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Cy Schubert
In message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Schubert writes: > In message <20230413064252.1e5c1...@slippy.cwsent.com>, Cy Schubert writes: > > In message , Mark Millard > > write > > s: > > > [This just puts my prior reply's material into Cy's > > > adjusted resend of the original.

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Cy Schubert
In message <20230413064252.1e5c1...@slippy.cwsent.com>, Cy Schubert writes: > In message , Mark Millard > write > s: > > [This just puts my prior reply's material into Cy's > > adjusted resend of the original. The To/Cc should > > be coomplete this time.] > > > > On Apr 12, 2023, at 22:52, Cy

Re: Status of Alder and Raptor lake on FreeBSD Current

2023-04-13 Thread Stephane Rochoy
Dries Michiels writes: I was wondering what the status of Alder/Raptor lake support is on FreeBSD? Does it boot? Integrated graphics are supported from what I recall with the newest drm drivers. Are there any plans for changes to our scheduler to account for efficiency and performance

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Alexander Leidinger
Quoting Mark Millard (from Wed, 12 Apr 2023 22:28:13 -0700): A fair number of errors are of the form: the build installing a previously built package for use in the builder but later the builder can not find some file from the package's installation. As a data point, last year I had such

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Cy Schubert
In message , Mark Millard write s: > [This just puts my prior reply's material into Cy's > adjusted resend of the original. The To/Cc should > be coomplete this time.] > > On Apr 12, 2023, at 22:52, Cy Schubert = > wrote: > > > In message , Mark = > Millard=20 > > write > > s: > >> From: Charlie

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

2023-04-13 Thread Mark Millard
[This just puts my prior reply's material into Cy's adjusted resend of the original. The To/Cc should be coomplete this time.] On Apr 12, 2023, at 22:52, Cy Schubert wrote: > In message , Mark Millard > write > s: >> From: Charlie Li wrote on >> Date: Wed, 12 Apr 2023 20:11:16 UTC : >> >>>