Re: Heads up: checking in change to ata-card.c

2003-08-14 Thread John Birrell
On Mon, Aug 04, 2003 at 10:45:39PM -0700, Stephen Casner wrote: I tried what I thought might be the equivalent patch (eliminating an else clause), but it did not solve the problem. In 4.8-RELEASE I sometimes get a system hang and sometimes not, but even when it does not hang, I just get

Re: Heads up: checking in change to ata-card.c

2003-08-14 Thread Stephen Casner
On Tue, 5 Aug 2003, John Birrell wrote: On Mon, Aug 04, 2003 at 10:45:39PM -0700, Stephen Casner wrote: I tried what I thought might be the equivalent patch (eliminating an else clause), but it did not solve the problem. In 4.8-RELEASE I sometimes get a system hang and sometimes not, but

Re: Heads up: checking in change to ata-card.c

2003-08-07 Thread Stephen Casner
My question is really about -STABLE rather than -CURRENT, but it involves a problem recently resolved in -CURRENT. On Thu, 26 Jun 2003, Bill Paul started this thread regarding failed support for the Sony PCMCIA CD-ROM drive (NinjaATA-) in releases since 4.5, including 4.8 and 5.1. You folks

Re: Heads up: checking in change to ata-card.c

2003-06-27 Thread Soeren Schmidt
It seems Bill Paul wrote: In message [EMAIL PROTECTED], M. Warner Losh writes: Here's a better patch, basesd on wpaul's input. Bill, can you try it an see if it works for you? If so, i would be better to commit this one. If not, I'll work with you to fix it. FYI, I have a no-name

Re: Heads up: checking in change to ata-card.c

2003-06-27 Thread Terry Lambert
Soeren Schmidt wrote: I do have problems with the wording you use in the comments in that patch mentioned below, I will even say that I will remove that as soon as it appears *and* shoot the committer so it doesn't happen again to use your choice of wording.. While you are making those

Heads up: checking in change to ata-card.c

2003-06-26 Thread Bill Paul
A long time ago, circa FreeBSD 4.3, my Sony PCMCIA CD-ROM drive with brain-damaged Teac ATA controller drive worked, and the people were content and all was right with the land. Then my 4.4 CD set arrived, and I was disappointed to find the install kernel would lock up after the driver was

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread M. Warner Losh
Lose the attitude in the patch and email. otherwise it looks good. I'd rather that we had a table rather than doing the string coparison, but I can fix that after your commit. Warner ___ [EMAIL PROTECTED] mailing list

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread Soeren Schmidt
I do have problems with the wording you use in the comments in that patch mentioned below, I will even say that I will remove that as soon as it appears *and* shoot the committer so it doesn't happen again to use your choice of wording.. Now, I dont think this way is productive at all, and would

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread M. Warner Losh
Here's a better patch, basesd on wpaul's input. Bill, can you try it an see if it works for you? If so, i would be better to commit this one. If not, I'll work with you to fix it. If you are uninterested in working with us to get things in, then your patch will not lasts the evening as such

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread M. Warner Losh
In message: [EMAIL PROTECTED] [EMAIL PROTECTED] (Bill Paul) writes: : P.S.: Be sure to join us next time when I ream out whoever it was that : broke support for my 3Com 3c575C cardbus ethernet NIC. It looks like my 3ccfe575ct is working well as of lasts week's current. Any

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread Julian Elischer
On Thu, 26 Jun 2003, Bill Paul wrote: A long time ago, circa FreeBSD 4.3, my Sony PCMCIA CD-ROM drive with brain-damaged Teac ATA controller drive worked, and the people were content and all was right with the land. Then my 4.4 CD set arrived, and I was disappointed to find the install

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread Bill Paul
Here's a better patch, basesd on wpaul's input. Bill, can you try it an see if it works for you? If so, i would be better to commit this one. If not, I'll work with you to fix it. Close, but this doesn't quite do it. I thought something didn't look right when I read it, and I tested it

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread David Xu
- Original Message - From: Soeren Schmidt [EMAIL PROTECTED] To: Bill Paul [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Friday, June 27, 2003 3:03 AM Subject: Re: Heads up: checking in change to ata-card.c I do have problems with the wording you use

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread Wilko Bulte
Schmidt [EMAIL PROTECTED] To: Bill Paul [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Friday, June 27, 2003 3:03 AM Subject: Re: Heads up: checking in change to ata-card.c I do have problems with the wording you use in the comments in that patch

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread Ian Dowse
In message [EMAIL PROTECTED], M. Warner Losh writes: Here's a better patch, basesd on wpaul's input. Bill, can you try it an see if it works for you? If so, i would be better to commit this one. If not, I'll work with you to fix it. FYI, I have a no-name (PCMCIA/CD-ROM) drive that also

RE: Heads up: checking in change to ata-card.c

2003-06-26 Thread Will Saxon
-Original Message- From: David Xu [mailto:[EMAIL PROTECTED] Sent: Thursday, June 26, 2003 6:30 PM To: Soeren Schmidt; Bill Paul Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: Heads up: checking in change to ata-card.c I have another problem different with Bill Paul's

RE: Heads up: checking in change to ata-card.c

2003-06-26 Thread Julian Elischer
Schmidt; Bill Paul Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: Heads up: checking in change to ata-card.c I have another problem different with Bill Paul's. I have a Tyan Tiger 230T dual CPU MB. On second IDE, there are MITSUBISHI 52X CDROM as master and a SONY CD-RW

RE: Heads up: checking in change to ata-card.c

2003-06-26 Thread Will Saxon
-Original Message- From: Julian Elischer [mailto:[EMAIL PROTECTED] Sent: Thursday, June 26, 2003 7:26 PM To: Will Saxon Cc: David Xu; Soeren Schmidt; Bill Paul; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: RE: Heads up: checking in change to ata-card.c Nvidia (I previously

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread Bill Paul
In message [EMAIL PROTECTED], M. Warner Losh writes: Here's a better patch, basesd on wpaul's input. Bill, can you try it an see if it works for you? If so, i would be better to commit this one. If not, I'll work with you to fix it. FYI, I have a no-name (PCMCIA/CD-ROM) drive that also

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread David O'Brien
On Thu, Jun 26, 2003 at 01:20:04PM -0600, M. Warner Losh wrote: In message: [EMAIL PROTECTED] [EMAIL PROTECTED] (Bill Paul) writes: : P.S.: Be sure to join us next time when I ream out whoever it was that : broke support for my 3Com 3c575C cardbus ethernet NIC. It looks

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread M. Warner Losh
This works for all my ata-like cards. I've gone ahead and committed it... Warner ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]

Re: Heads up: checking in change to ata-card.c

2003-06-26 Thread Wilko Bulte
On Thu, Jun 26, 2003 at 05:04:10PM -0700, David O'Brien wrote: On Thu, Jun 26, 2003 at 01:20:04PM -0600, M. Warner Losh wrote: In message: [EMAIL PROTECTED] [EMAIL PROTECTED] (Bill Paul) writes: : P.S.: Be sure to join us next time when I ream out whoever it was that :