Re: panic after r244584

2013-01-24 Thread Jaakko Heinonen
On 2013-01-23, Vitalij Satanivskij wrote: VS JH http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff VS VS Ok that patch work's too. Is there any chance, that one of this patches will be merged to head? Committed as r245891. Thanks for reporting and testing! -- Jaakko

Re: panic after r244584

2013-01-24 Thread Vitalij Satanivskij
Jaakko Heinonen wrote: JH On 2013-01-23, Vitalij Satanivskij wrote: JH VS JH http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff JH VS JH VS Ok that patch work's too. JH JH Is there any chance, that one of this patches will be merged to head? JH JH Committed as r245891.

Re: panic after r244584

2013-01-23 Thread Jaakko Heinonen
On 2013-01-23, Vitalij Satanivskij wrote: VS Jaakko Heinonen wrote: VS JH I see two possible solutions for the problem. VS JH VS JH 1) Replace non-printable, space and '/' characters for example with '_'. VS JH '/' should be replaced anyway. VS JH VS JH 2) Apply the patches in

Re: panic after r244584

2013-01-23 Thread Alexander Motin
On 23.01.2013 21:51, Jaakko Heinonen wrote: On 2013-01-23, Vitalij Satanivskij wrote: VS Jaakko Heinonen wrote: VS JH I see two possible solutions for the problem. VS JH VS JH 1) Replace non-printable, space and '/' characters for example with '_'. VS JH '/' should be replaced

Re: panic after r244584

2013-01-23 Thread Justin T. Gibbs
On Jan 23, 2013, at 1:39 PM, Alexander Motin m...@freebsd.org wrote: On 23.01.2013 21:51, Jaakko Heinonen wrote: On 2013-01-23, Vitalij Satanivskij wrote: VS Jaakko Heinonen wrote: VS JH I see two possible solutions for the problem. VS JH VS JH 1) Replace non-printable, space and '/'

Re: panic after r244584

2013-01-22 Thread Vitalij Satanivskij
Vitalij Satanivskij wrote: VS Jaakko Heinonen wrote: VS JH On 2013-01-19, Jaakko Heinonen wrote: VS JH On 2013-01-18, Alexander Motin wrote: VS JH At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are VS JH impossible there, as previous name components are unique. Special VS

Re: panic after r244584

2013-01-21 Thread Vitalij Satanivskij
Jaakko Heinonen wrote: JH On 2013-01-18, Alexander Motin wrote: JH At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are JH impossible there, as previous name components are unique. Special JH characters haven't yet seen, but I think theoretically possible. JH JH I see two

Re: panic after r244584

2013-01-21 Thread Jaakko Heinonen
On 2013-01-19, Jaakko Heinonen wrote: On 2013-01-18, Alexander Motin wrote: At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are impossible there, as previous name components are unique. Special characters haven't yet seen, but I think theoretically possible. I see two

Re: panic after r244584

2013-01-21 Thread Vitalij Satanivskij
Jaakko Heinonen wrote: JH On 2013-01-19, Jaakko Heinonen wrote: JH On 2013-01-18, Alexander Motin wrote: JH At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are JH impossible there, as previous name components are unique. Special JH characters haven't yet seen, but I think

Re: panic after r244584

2013-01-19 Thread Jaakko Heinonen
On 2013-01-18, Alexander Motin wrote: At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are impossible there, as previous name components are unique. Special characters haven't yet seen, but I think theoretically possible. I see two possible solutions for the problem. 1)

Re: panic after r244584

2013-01-18 Thread Gleb Smirnoff
On Fri, Jan 18, 2013 at 09:36:00AM +0200, Vitalij Satanivskij wrote: V Hello. V V After upgrading server from old hardware/software to freebsd current (## SVN ## Exported commit - http://svnweb.freebsd.org/changeset/base/245479), V system hung's with message - V panic: make_dev_alias_v: bad

Re: panic after r244584

2013-01-18 Thread Vitalij Satanivskij
Alexander Motin wrote: AM On 18.01.2013 11:44, Gleb Smirnoff wrote: AM On Fri, Jan 18, 2013 at 09:36:00AM +0200, Vitalij Satanivskij wrote: AM V After upgrading server from old hardware/software to freebsd current (## SVN ## Exported commit - http://svnweb.freebsd.org/changeset/base/245479), AM

Re: panic after r244584

2013-01-18 Thread Alexander Motin
On 18.01.2013 13:39, Vitalij Satanivskij wrote: Alexander Motin wrote: AM On 18.01.2013 11:44, Gleb Smirnoff wrote: AM On Fri, Jan 18, 2013 at 09:36:00AM +0200, Vitalij Satanivskij wrote: AM V After upgrading server from old hardware/software to freebsd current (## SVN ## Exported commit -

Re: panic after r244584

2013-01-18 Thread Alexander Motin
On 18.01.2013 11:44, Gleb Smirnoff wrote: On Fri, Jan 18, 2013 at 09:36:00AM +0200, Vitalij Satanivskij wrote: V After upgrading server from old hardware/software to freebsd current (## SVN ## Exported commit - http://svnweb.freebsd.org/changeset/base/245479), V system hung's with message -

Re: panic after r244584

2013-01-18 Thread Jaakko Heinonen
On 2013-01-18, Alexander Motin wrote: AM V panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) AM The panic is triggered by the check added by the recent r244584 change. AM The space in device name came from the enclosure

Re: panic after r244584

2013-01-18 Thread Alexander Motin
On 18.01.2013 15:19, Jaakko Heinonen wrote: On 2013-01-18, Alexander Motin wrote: AM V panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) AM The panic is triggered by the check added by the recent r244584 change. AM The space

Re: panic after r244584

2013-01-18 Thread Vitalij Satanivskij
Jaakko Heinonen wrote: JH On 2013-01-18, Alexander Motin wrote: JH AM V panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) JH JH AM The panic is triggered by the check added by the recent r244584 change. JH AM The space in

Re: panic after r244584

2013-01-18 Thread Vitalij Satanivskij
May be just do sanitizing for elmpriv-descr? something like change whitespace to _ or just delete it? Vitalij Satanivskij wrote: VS Jaakko Heinonen wrote: VS JH On 2013-01-18, Alexander Motin wrote: VS JH AM V panic: make_dev_alias_v: bad si_name (error=22

Re: panic after r244584

2013-01-18 Thread Alexander Motin
On 18.01.2013 15:49, Vitalij Satanivskij wrote: May be just do sanitizing for elmpriv-descr? something like change whitespace to _ or just delete it? Yes, that is not difficult. The only question is how to stay consistent, compatible, user-readable. Vitalij Satanivskij wrote: VS Jaakko

Re: panic after r244584

2013-01-18 Thread Vitalij Satanivskij
Alexander Motin wrote: AM On 18.01.2013 15:49, Vitalij Satanivskij wrote: AM May be just do sanitizing for elmpriv-descr? AM AM something like change whitespace to _ or just delete it? AM AM Yes, that is not difficult. The only question is how to stay consistent, AM compatible, user-readable.

Re: panic after r244584

2013-01-18 Thread Vitalij Satanivskij
Vitalij Satanivskij wrote: VS Alexander Motin wrote: VS AM On 18.01.2013 15:49, Vitalij Satanivskij wrote: VS AM May be just do sanitizing for elmpriv-descr? VS AM VS AM something like change whitespace to _ or just delete it? VS AM VS AM Yes, that is not difficult. The only question is how

panic after r244584

2013-01-17 Thread Vitalij Satanivskij
Hello. After upgrading server from old hardware/software to freebsd current (## SVN ## Exported commit - http://svnweb.freebsd.org/changeset/base/245479), system hung's with message - panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot