CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-16 Thread Kimmo Paasiala
Hello list. I just updated my stable/9 system after clang3.2 was added. My system is amd64, both world and kernel are compiled with clang3.2 and the default compiler is clang. I'm tracking the sources with GIT and the version I have corresponds to SVN revision r245451. Everything else seems to wo

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-16 Thread Dimitry Andric
On 2013-01-16 13:05, Kimmo Paasiala wrote: I just updated my stable/9 system after clang3.2 was added. My system is amd64, both world and kernel are compiled with clang3.2 and the default compiler is clang. I'm tracking the sources with GIT and the version I have corresponds to SVN revision r2454

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-16 Thread Kimmo Paasiala
On Wed, Jan 16, 2013 at 6:15 PM, Dimitry Andric wrote: > On 2013-01-16 13:05, Kimmo Paasiala wrote: >> >> I just updated my stable/9 system after clang3.2 was added. My system >> is amd64, both world and kernel are compiled with clang3.2 and the >> default compiler is clang. I'm tracking the sourc

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-16 Thread Brooks Davis
On Wed, Jan 16, 2013 at 08:01:00PM +0200, Kimmo Paasiala wrote: > On Wed, Jan 16, 2013 at 6:15 PM, Dimitry Andric wrote: > > On 2013-01-16 13:05, Kimmo Paasiala wrote: > >> > >> I just updated my stable/9 system after clang3.2 was added. My system > >> is amd64, both world and kernel are compiled

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-16 Thread Kimmo Paasiala
On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: > On Wed, Jan 16, 2013 at 08:01:00PM +0200, Kimmo Paasiala wrote: >> On Wed, Jan 16, 2013 at 6:15 PM, Dimitry Andric wrote: >> > On 2013-01-16 13:05, Kimmo Paasiala wrote: >> >> >> >> I just updated my stable/9 system after clang3.2 was added.

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-16 Thread Kimmo Paasiala
On Wed, Jan 16, 2013 at 8:01 PM, Kimmo Paasiala wrote: > On Wed, Jan 16, 2013 at 6:15 PM, Dimitry Andric wrote: >> On 2013-01-16 13:05, Kimmo Paasiala wrote: >>> >>> I just updated my stable/9 system after clang3.2 was added. My system >>> is amd64, both world and kernel are compiled with clang3.

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-16 Thread Ben Morrow
Quoth Kimmo Paasiala : > > Doesn't the change to strnvis() break the ABI on FreeBSD 9.X? I > thought you could always compile a binary on an earlier version of > FreeBSD 9.X and trust it to work without recompiling on any later > minor version of the same major version line. No, it doesn't. No ex

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-16 Thread Kimmo Paasiala
On Thu, Jan 17, 2013 at 9:33 AM, Ben Morrow wrote: > Quoth Kimmo Paasiala : >> >> Doesn't the change to strnvis() break the ABI on FreeBSD 9.X? I >> thought you could always compile a binary on an earlier version of >> FreeBSD 9.X and trust it to work without recompiling on any later >> minor vers

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-17 Thread Kimmo Paasiala
On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: > On Wed, Jan 16, 2013 at 08:01:00PM +0200, Kimmo Paasiala wrote: >> On Wed, Jan 16, 2013 at 6:15 PM, Dimitry Andric wrote: >> > On 2013-01-16 13:05, Kimmo Paasiala wrote: >> >> >> >> I just updated my stable/9 system after clang3.2 was added.

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-17 Thread Brooks Davis
On Thu, Jan 17, 2013 at 09:06:27AM +0200, Kimmo Paasiala wrote: > On Wed, Jan 16, 2013 at 8:01 PM, Kimmo Paasiala wrote: > > On Wed, Jan 16, 2013 at 6:15 PM, Dimitry Andric wrote: > >> On 2013-01-16 13:05, Kimmo Paasiala wrote: > >>> > >>> I just updated my stable/9 system after clang3.2 was adde

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-17 Thread Dimitry Andric
On 2013-01-17 14:07, Kimmo Paasiala wrote: On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: ... NetBSD and OpenBSD use different signatures for strnvis(). :( pam_ssh_agent_auth assumes that if the system has one it is the OpenBSD one but ours is the NetBSD one. The port will need to be pa

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-17 Thread Mike Tancsa
On 1/17/2013 10:15 AM, Dimitry Andric wrote: > CONFIGURE_ENV=ac_cv_func_strnvis="no" Still segfaults for me. ---Mike -- --- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, m...@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, O

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-17 Thread Kimmo Paasiala
On Thu, Jan 17, 2013 at 5:15 PM, Dimitry Andric wrote: > On 2013-01-17 14:07, Kimmo Paasiala wrote: >> >> On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: > > ... >>> >>> NetBSD and OpenBSD use different signatures for strnvis(). :( >>> pam_ssh_agent_auth assumes that if the system has one it

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-29 Thread Mike Tancsa
On 1/17/2013 4:35 PM, Kimmo Paasiala wrote: > On Thu, Jan 17, 2013 at 5:15 PM, Dimitry Andric wrote: >> On 2013-01-17 14:07, Kimmo Paasiala wrote: >>> >>> On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: >> >> ... >> >> Please try the following patch, which tells configure that HAVE_STRNVIS >

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-29 Thread Kimmo Paasiala
On Tue, Jan 29, 2013 at 9:08 PM, Mike Tancsa wrote: > On 1/17/2013 4:35 PM, Kimmo Paasiala wrote: >> On Thu, Jan 17, 2013 at 5:15 PM, Dimitry Andric wrote: >>> On 2013-01-17 14:07, Kimmo Paasiala wrote: On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: >>> >>> ... >>> >>> Please try

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-29 Thread James
I was able to correct the problem as well by prefixing strnvis, avoiding the symbol collision. I also found PR: ports/172941 which also has a fix. Using my patch or the patch in ports/172941 fixes the segfault for me in stable/9. However, I quickly ran into another problem. I can't remember the er

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-29 Thread Kimmo Paasiala
On Wed, Jan 30, 2013 at 7:27 AM, James wrote: > I was able to correct the problem as well by prefixing strnvis, avoiding the > symbol collision. I also found PR: ports/172941 which also has a fix. > > Using my patch or the patch in ports/172941 fixes the segfault for me in > stable/9. However, I q

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-30 Thread James
Hi Kimmo. Thanks for this. Your patch works great in stable/9. -- James. ___ freebsd-stable@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-30 Thread Mike Tancsa
On 1/30/2013 1:21 AM, Kimmo Paasiala wrote: > On Wed, Jan 30, 2013 at 7:27 AM, James wrote: >> I was able to correct the problem as well by prefixing strnvis, avoiding the >> symbol collision. I also found PR: ports/172941 which also has a fix. >> >> Using my patch or the patch in ports/172941 fix

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-01-31 Thread Mark Linimon
On Thu, Jan 17, 2013 at 09:15:02AM -0600, Brooks Davis wrote: > Not unless you consider adding new functions in a reserved namespace > (str*) to be ABI breakage. Well, what often happens is that when we add new functions, ports break. I think deciding whether this is or is not "ABI breakage" is se

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-02-01 Thread Brooks Davis
On Thu, Jan 31, 2013 at 10:22:44PM -0600, Mark Linimon wrote: > On Thu, Jan 17, 2013 at 09:15:02AM -0600, Brooks Davis wrote: > > Not unless you consider adding new functions in a reserved namespace > > (str*) to be ABI breakage. > > Well, what often happens is that when we add new functions, port

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-02-02 Thread Stefan Bethke
Am 30.01.2013 um 07:21 schrieb Kimmo Paasiala : > On Wed, Jan 30, 2013 at 7:27 AM, James wrote: >> I was able to correct the problem as well by prefixing strnvis, avoiding the >> symbol collision. I also found PR: ports/172941 which also has a fix. >> >> Using my patch or the patch in ports/1729

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-02-02 Thread Mark Linimon
On Fri, Feb 01, 2013 at 11:53:03AM -0600, Brooks Davis wrote: > I'm not sure why I'm being jumped on in this weeks old report of a > now-fixed problem. I'm sorry, I'm that far behind in email. I did not realize the problem had already been solved. More often than not the problem is simply "throw

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-02-02 Thread Kimmo Paasiala
On Sun, Feb 3, 2013 at 4:06 AM, Mark Linimon wrote: > On Fri, Feb 01, 2013 at 11:53:03AM -0600, Brooks Davis wrote: >> I'm not sure why I'm being jumped on in this weeks old report of a >> now-fixed problem. > > I'm sorry, I'm that far behind in email. I did not realize the problem > had already

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-02-03 Thread Chris Rees
On 3 February 2013 03:55, Kimmo Paasiala wrote: > On Sun, Feb 3, 2013 at 4:06 AM, Mark Linimon wrote: >> On Fri, Feb 01, 2013 at 11:53:03AM -0600, Brooks Davis wrote: >>> I'm not sure why I'm being jumped on in this weeks old report of a >>> now-fixed problem. >> >> I'm sorry, I'm that far behind

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-02-03 Thread Kimmo Paasiala
On Sun, Feb 3, 2013 at 11:57 AM, Chris Rees wrote: > On 3 February 2013 03:55, Kimmo Paasiala wrote: >> On Sun, Feb 3, 2013 at 4:06 AM, Mark Linimon wrote: >>> On Fri, Feb 01, 2013 at 11:53:03AM -0600, Brooks Davis wrote: I'm not sure why I'm being jumped on in this weeks old report of a >>

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-02-03 Thread Stefan Bethke
Am 03.02.2013 um 10:57 schrieb Chris Rees : > On 3 February 2013 03:55, Kimmo Paasiala wrote: >> >> There is no PR yet with my fix and therefor no commit to ports tree >> that would fix the problem. I'll file a PR soon (TM). > > The problem was in base, and is fixed there. Huh? With -current

Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

2013-02-03 Thread Chris Rees
On 3 February 2013 17:15, Stefan Bethke wrote: > > Am 03.02.2013 um 10:57 schrieb Chris Rees : > >> On 3 February 2013 03:55, Kimmo Paasiala wrote: >>> >>> There is no PR yet with my fix and therefor no commit to ports tree >>> that would fix the problem. I'll file a PR soon (TM). >> >> The probl

Re: stable/9 r245439 breaks security/pam_ssh_agent_auth on stable/9 (WAS: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9)

2013-02-04 Thread Kimmo Paasiala
On Sun, Feb 3, 2013 at 7:22 PM, Chris Rees wrote: > On 3 February 2013 17:15, Stefan Bethke wrote: >> >> Am 03.02.2013 um 10:57 schrieb Chris Rees : >> >>> On 3 February 2013 03:55, Kimmo Paasiala wrote: There is no PR yet with my fix and therefor no commit to ports tree that woul

Re: stable/9 r245439 breaks security/pam_ssh_agent_auth on stable/9 (WAS: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9)

2013-02-05 Thread Kimmo Paasiala
On Tue, Feb 5, 2013 at 12:36 AM, Kimmo Paasiala wrote: > On Sun, Feb 3, 2013 at 7:22 PM, Chris Rees wrote: >> On 3 February 2013 17:15, Stefan Bethke wrote: >>> >>> Am 03.02.2013 um 10:57 schrieb Chris Rees : >>> On 3 February 2013 03:55, Kimmo Paasiala wrote: > > There is no PR ye

Re: stable/9 r245439 breaks security/pam_ssh_agent_auth on stable/9 (WAS: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9)

2013-02-20 Thread Kimmo Paasiala
On Wed, Feb 6, 2013 at 12:28 AM, Stefan Bethke wrote: > > Am 05.02.2013 um 23:06 schrieb Stefan Bethke : > >> Am 05.02.2013 um 19:09 schrieb Kimmo Paasiala : >> >>> On Tue, Feb 5, 2013 at 12:36 AM, Kimmo Paasiala wrote: On Sun, Feb 3, 2013 at 7:22 PM, Chris Rees wrote: > On 3 February 2