Re: [Freeciv-Dev] 2.1.5

2008-06-15 Thread Daniel Markstedt
On Sat, 07 Jun 2008 02:47:35 +0900, Marko Lindqvist [EMAIL PROTECTED] wrote: 2008/6/6 Madeline Book: What might be nice is to release 2.1.5 so it can be used for the first 2.1.x longturn game (which will probably start in a week or two), Then I suggest that we postpone 2.1.5 one week,

Re: [Freeciv-Dev] (PR#38372) [Bug] AI tries to trade unreachable techs

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=38372 2008/6/13 Marko Lindqvist: 2007/3/18 Marko Lindqvist: 1: Treaty: The White Horde can't have tech Asian Architecture Per's patch updated for S2_2. Committed to TRUNK (r14758) and S2_2 (r14759). S2_1 will wait until 2.1.5 has

[Freeciv-Dev] (PR#40279) [Patch] Disabled military bases

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40279 Current military base code requires exactly two bases defined. Civ1 ruleset should have no airbase. Currently used attempt to disable airbase from civ1 rules does not work. Attached patch adds 'disabled' field to military base

[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 Discussion about this started in #38372. Attached patch renames: player_invention_is_ready() - player_invention_reachable() TECH_REACHABLE - TECH_PREREQS COLOR_REQTREE_REACHABLE_GOAL - COLOR_REQTREE_PREREQS_GOAL

[Freeciv-Dev] (PR#40281) [Patch] Fix winsock compiler warning

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40281 $subject - ML diff -Nurd -X.diff_ignore freeciv/server/sernet.c freeciv/server/sernet.c --- freeciv/server/sernet.c 2008-05-04 16:48:09.0 +0300 +++ freeciv/server/sernet.c 2008-06-15 19:43:41.0 +0300 @@

[Freeciv-Dev] (PR#40282) Re: Patch: CMA fix when loading saved game

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40282 Forwarding to tracker so patch is not ignored and lost. 2008/6/10 Patrick Smith: Hi, The attached patch seems to fix some CMA problems when loading a saved game. The city report still indicates fairly random CMA choices for cities,

Re: [Freeciv-Dev] (PR#40282) Re: Patch: CMA fix when loading saved game

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40282 2008/6/10 Patrick Smith: Hi, The attached patch seems to fix some CMA problems when loading a saved game. The city report still indicates fairly random CMA choices for cities, but some messages about the governor being confused

Re: [Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 2008/6/15 Madeline Book: If the goal is to make the names more intuitive from the point of view of an English speaker, then in my opinion HAS_PREREQS (or maybe even HAVE to implicitly indicate that it is I/you/we the player that has

[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 [EMAIL PROTECTED] - Sun Jun 15 14:01:02 2008]: Discussion about this started in #38372. Attached patch renames: TECH_REACHABLE - TECH_PREREQS COLOR_REQTREE_REACHABLE - COLOR_REQTREE_PREREQS COLOR_REQTREE_REACHABLE_GOAL -

[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 [EMAIL PROTECTED] - Sun Jun 15 19:07:47 2008]: Actually, HAS_PREREQS sounds like technology that has prereqs defined, not one that somebody has prereqs researched for. Yes that ambiguity is a little annoying. :/ How about

Re: [Freeciv-Dev] (PR#40278) [Patch] Dangerous danger tweaking

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40278 2008/6/15 Marko Lindqvist: Cleanup to function providing us dangerous danger -logmessages, assess_danger() - Danger is always positive in this function. Made danger counter unsigned to make one more bit usable - Moved overflow

[Freeciv-Dev] (PR#40285) [Patch] log_set_callback() returns old callback

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40285 $subject Minor change to make it easier to add extra debug functionality; to chain log callbacks. My public server uses this to attach handler to store backtraces about all LOG_FATAL and LOG_ERROR messages. - ML diff -Nurd

Re: [Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 2008/6/15 Madeline Book: This gave me another idea along the same lines: PREREQS_KNOWN. I were worried this would turn out too long, but in the end I'm quite happy with it. In addition to this change, I moved word GOAL before

Re: [Freeciv-Dev] (PR#40234) [Patch] Start button sensitivity

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40234 2008/5/8 Marko Lindqvist: 2008/5/8 Madeline Book: [cazfi - Wed May 07 21:59:32 2008]: GTK-2 Current Start button sensitivity checks against global observer, but observer attached to player cannot start game either.

Re: [Freeciv-Dev] (PR#40254) [PATCH] Cancel AI mode when attaching to aifill player.

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40254 2008/6/5 Marko Lindqvist: 2008/5/30 Madeline Book: When a user connected to a server with some AI players created by aifill, they were attached to an existing AI player but AI mode was not reset. So when the game started the

[Freeciv-Dev] (PR#40283) [Patch] Skip base specials in tile_special_type_iterate

2008-06-15 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40283 [EMAIL PROTECTED] - Sun Jun 15 23:02:28 2008]: 2008/6/16 Madeline Book: I have also written the code with the future feature of more than one base type being allowed per tile in mind. This should be possible (since indeed it

Re: [Freeciv-Dev] (PR#40167) Client crash on scenario load

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40167 2008/3/29 Marko Lindqvist: On 24/03/2008, Marko Lindqvist wrote: With #40166 fixing server crash, scenario load now ends to client crash. Actually, this is not limited to scenario load. Same happens quite often for any