Re: [Freeciv-Dev] (PR#40764) AutoReply: update the default ruleset

2009-04-12 Thread Matthias Pfafferodt
http://bugs.freeciv.org/Ticket/Display.html?id=40764 > > There are a lot of new things are possible but they are not activated in > the default ruleset. Perhaps a 'new' default should be defined, which uses > all the new goodies? I tried to activate some options but I don't know > enough about th

Re: [Freeciv-Dev] (PR#40763) AutoReply: [patch] economic report

2009-04-12 Thread Matthias Pfafferodt
http://bugs.freeciv.org/Ticket/Display.html?id=40763 > > if the upkeep for all units is calculated each turn, this information can > be used for the economic report > > depends on ticket 40619, 40759 > > compile tested and also with a short game similar simplification are possible(?) in client/

Re: [Freeciv-Dev] (PR#40619) gold upkeep

2009-04-12 Thread Matthias Pfafferodt
http://bugs.freeciv.org/Ticket/Display.html?id=40619 > Am Sunday 12 April 2009 04:16:10 schrieb Madeline Book: > http://bugs.freeciv.org/Ticket/Display.html?id=40619 > > > I committed gold_upkeep_v4.patch; is unit_upkeep.patch.diff > intended to be applied on top of it as part of this ticket? > O

Re: [Freeciv-Dev] (PR#40761) AutoReply: [patch] shield2gold_basics

2009-04-12 Thread Matthias Pfafferodt
http://bugs.freeciv.org/Ticket/Display.html?id=40761 > > add an effect which changes shield upkeep to gold upkeep; it is activated > if 'The Corporation' is researched > > depends on ticket 40619, 40759, 40760 > > compile tested and also with a short game In this patch the effect EFT_SHIELD2GOLD

Re: [Freeciv-Dev] (PR#40759) AutoReply: [patch] calc_city_units_upkeep

2009-04-12 Thread Matthias Pfafferodt
http://bugs.freeciv.org/Ticket/Display.html?id=40759 > > calculate the upkeep for all units of all cities at the start of the turn > and save it in the unit struct > > depends on ticket 40619 > > compile tested and also with a short game If unitgold is changed to unit_list or similar take into a

[Freeciv-Dev] You must #define preprocessor constants before using them.

2009-04-12 Thread James Supancic
I have recently updated my local copy of the freeciv trunk. I have noticed that the following: GAME_DEFAULT_GOLD_UPKEEP_STYLE GAME_MAX_GOLD_UPKEEP_STYLE GAME_MIN_GOLD_UPKEEP_STYLE Are used in ruleset.c but not #defined anywhere. I suspect someone commited ruelset.c but failed to commit ruleset.h?

Re: [Freeciv-Dev] You must #define preprocessor constants before using them.

2009-04-12 Thread Daniil Ivanov
Hi! I see they are defined in common/game.h. Thanks, Daniil. On Sun, Apr 12, 2009 at 1:51 PM, James Supancic wrote: > I have recently updated my local copy of the freeciv trunk. I have > noticed that the following: > GAME_DEFAULT_GOLD_UPKEEP_STYLE > GAME_MAX_GOLD_UPKEEP_STYLE > GAME_MIN_GOLD_

Re: [Freeciv-Dev] You must #define preprocessor constants before using them.

2009-04-12 Thread Madeline Book
On 12/04/2009, James Supancic wrote: > I have recently updated my local copy of the freeciv trunk. I have > noticed that the following: > GAME_DEFAULT_GOLD_UPKEEP_STYLE > GAME_MAX_GOLD_UPKEEP_STYLE > GAME_MIN_GOLD_UPKEEP_STYLE > Are used in ruleset.c but not #defined anywhere. > > I suspect someon

Re: [Freeciv-Dev] You must #define preprocessor constants before using them.

2009-04-12 Thread James Supancic
I removed game.h and then did svn up again and now it is working. I guess I should have double checked before posting here... sorry for the confusion. Thank you for your time, James Steven Supancic III ___ Freeciv-dev mailing list Freeciv-dev@gna.org ht

[Freeciv-Dev] (PR#40759) [patch] calc_city_units_upkeep

2009-04-12 Thread guest
http://bugs.freeciv.org/Ticket/Display.html?id=40759 > > > - Perhaps the values of the unit upkeep field should be > > sent in unit info packets so that they do not have to > > be recomputed at the client side. > > I will look into this. Should this be something like in the attached file (uni

[Freeciv-Dev] (PR#40759) [patch] calc_city_units_upkeep

2009-04-12 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40759 > > [guest - Sun Apr 12 18:29:01 2009]: > > > > - Perhaps the values of the unit upkeep field should be > > > sent in unit info packets so that they do not have to > > > be recomputed at the client side. > > > > I will look into this. > > S