[Freeciv-Dev] [patch #3756] RFC: UI for building generic roads, bases, etc

Follow-up Comment #3, patch #3756 (project freeciv): Could some of this be integrated with the concept in patch #2721? Provide, say, 5 keystrokes for players to allocate (e.g. EFIMR), which the ruleset author would then define as different types in the ruleset and provide test labels for use in m

[Freeciv-Dev] [patch #3839] Low hanging nativity fixes

URL: Summary: Low hanging nativity fixes Project: Freeciv Submitted by: persia Submitted on: Mon 08 Apr 2013 04:58:06 PM JST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

Follow-up Comment #141, patch #3469 (project freeciv): OK, this is the patch fixing the typo. Should be god for both S2_4 and trunk. (file #17714) ___ Additional Item Attachment: File name: 0001-fix-rates-dialog-typo.patch Size:0 KB

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

Follow-up Comment #142, patch #3469 (project freeciv): > OK, this is the patch fixing the typo. Ah, we already raised a new ticket (bug #20706), sorry for not mentioning it here. ___ Reply to this item at:

[Freeciv-Dev] [patch #3840] tile_roads() to return tile roads vector

URL: Summary: tile_roads() to return tile roads vector Project: Freeciv Submitted by: cazfi Submitted on: Mon 08 Apr 2013 01:46:16 PM EEST Category: general Priority: 5 - Normal

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

Follow-up Comment #2, bug #20706 (project freeciv): Ah, no. 110% is deliberate - not by my design, it's freeciv that reports 110% to indicate a special condition. I remember stumbling upon this back when I was writing those patches, but I no longer recall what condition exactly was it. __

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

Follow-up Comment #3, bug #20706 (project freeciv): I don't think player should be ever allowed to set rates higher than 100%. I assume that you're referring to the fact that max rates effect can have any value coming from the ruleset. The fact that this code appears to have a bug of not cropping

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

Follow-up Comment #4, bug #20706 (project freeciv): Well, it would be much easier if I could remember where I've seen that special condition (IIRC, 110% was not a real value, but an indicator of a special status (civil war ?)), nevertheless 110% was already valid before my patch - the marks just m

[Freeciv-Dev] [patch #3841] Add strings for negated requirements

URL: Summary: Add strings for negated requirements Project: Freeciv Submitted by: persia Submitted on: Mon 08 Apr 2013 11:03:29 PM JST Category: client Priority: 5 - Normal

[Freeciv-Dev] [patch #3832] Allow BaseFlag and RoadFlag in reqs lists

Follow-up Comment #4, patch #3832 (project freeciv): Updated patch applies over patch #3841 and includes the !preq->negated documentation for baseflag/roadflag requirements. Also includes the Adjacnet fix (inherited from rebasing above patch #3836). (file #17717)

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

Follow-up Comment #5, bug #20706 (project freeciv): I gave Democracy Max_Rates effect of 110 and tested the dialog with that. Value displayed remained as 100% when I moved between 100 and 110 (and neither of the two other rates went negative). I noticed no effects, and I think the value gets cropp

[Freeciv-Dev] [patch #3842] Ensure use of boolean TRUE/FALSE in reqs specifications

URL: Summary: Ensure use of boolean TRUE/FALSE in reqs specifications Project: Freeciv Submitted by: persia Submitted on: Tue 09 Apr 2013 03:34:15 AM JST Category: rulesets Prio

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

Follow-up Comment #6, bug #20706 (project freeciv): > open rates dialog and rates setting icons in left panel are no way linked They never were AFAIK. Rates dialog checks the values only upon its creation. Trying to synchronize them would make the code much more complicated for very little gain.

[Freeciv-Dev] [bug #20728] Pointer to barbarian leader who has died while moving used afterwards

URL: Summary: Pointer to barbarian leader who has died while moving used afterwards Project: Freeciv Submitted by: cazfi Submitted on: Mon 08 Apr 2013 11:42:55 PM EEST Category: None

[Freeciv-Dev] [patch #1449] [Metaticket] Don't exit the server on ruleset loading failure

Update of patch #1449 (project freeciv): Depends on: => patch #3842 ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [bug #20728] Pointer to barbarian leader who has died while moving used afterwards

Update of bug #20728 (project freeciv): Category:None => ai Status:None => Ready For Test Planned Release: => 2.3.5, 2.4.0, 2.5.0 __

[Freeciv-Dev] [patch #3842] Ensure use of boolean TRUE/FALSE in reqs specifications

Follow-up Comment #1, patch #3842 (project freeciv): > This should be a dependency of patch #1449 , but I can't figure > out how to make that true from the GNA interface: if someone > would be willing to so mark it, I would appreciate that. You have to go to the other gna page, and search for thi

[Freeciv-Dev] [bug #20710] Editor can't place Maglev in alien or experimental rulesets

Update of bug #20710 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [patch #3842] Ensure use of boolean TRUE/FALSE in reqs specifications

Follow-up Comment #2, patch #3842 (project freeciv): Thanks for the GNA instruction and adjustment. Your logic is both more concise and absolutely correct: I missed the implications of the SECFILE_RETURN_VAL_IF_FAIL check. ___ Reply to thi

[Freeciv-Dev] [bug #20720] Transport allied cargo check doesn't recurse

Update of bug #20720 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #20694] in fill_sprite_array() [tilespec.c::4735]: assertion 't->sprites.background.graphic != NULL' failed

Update of bug #20694 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3842] Ensure use of boolean TRUE/FALSE in reqs specifications

Follow-up Comment #3, patch #3842 (project freeciv): An updated patch implementing pepeto's more concise expression (Thanks!). This has passed the same set of tests applied to the original patch, with the same results. (file #17722) ___ Ad

[Freeciv-Dev] Limited routing access for a week

Starting in about 24 hours, I'll have very limited routing access for about a week. I believe all my patches are currently up-to-date, and that I have addressed the outstanding requests pending in them, with the exception of the request for updates to the static ruleset helptexts in patch #381