[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries

Follow-up Comment #11, bug #21696 (project freeciv): > --enable-fcdb=all ... sets all the alternative libs to LUASQL_LIBS, with partly same content. -> bug #21897 ___ Reply to this item at:

[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries

URL: Summary: Enabling multiple fcdb backends cause same object files to be linked from multiple libraries Project: Freeciv Submitted by: cazfi Submitted on: Sun 06 Apr 2014 03:08:50 AM EEST Ca

[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries

Follow-up Comment #10, bug #21696 (project freeciv): I can see how your --enable-fcdb=all could be relevant, as configure.ac then sets all the alternative libs to LUASQL_LIBS, with partly same content. What I don't get is why it would work any more when the linking was made directly to executable.

[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries

Follow-up Comment #9, bug #21696 (project freeciv): > this patch breaks all builds using system lua libraries > (--enable-sys-lua) Intresting. The errors in your log are about luasql, not lua, so why is --enable-sys-lua relevant here? Are you sure it is? Anyway, I cannot reproduce in TRUNK (wher

[Freeciv-Dev] [bug #21896] "double free or corruption" after "Connect to network game"

Update of bug #21896 (project freeciv): Planned Release: 2.6.0 => 2.5.0, 2.6.0 ___ Follow-up Comment #1: > I wonder if it's insufficient thread safety around the message > window writing? Almost certa

[Freeciv-Dev] [bug #21894] Crash in is_my_zoc()

Follow-up Comment #1, bug #21894 (project freeciv): This crash shows up readily in a new game -- pressing 'G' on one of your first workers is often enough to provoke it, for me (I presume because there's plenty of unknown terrain around). The attached patch makes the crash go away, for me. _

[Freeciv-Dev] [bug #21896] "double free or corruption" after "Connect to network game"

URL: Summary: "double free or corruption" after "Connect to network game" Project: Freeciv Submitted by: jtn Submitted on: Sun 06 Apr 2014 00:32:03 BST Category: client-gtk-2.0

[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries

Update of bug #21696 (project freeciv): Open/Closed: Closed => Open ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [patch #4637] civ2civ3 rules: disasters

Update of patch #4637 (project freeciv): Category:None => rulesets Status:None => Ready For Test Planned Release: => 2.5.0-beta1, 2.6.0

[Freeciv-Dev] [patch #4641] civ2civ3: merchant units use railroad

Update of patch #4641 (project freeciv): Category:None => rulesets Status:None => Ready For Test Planned Release: => 2.5.0-beta1, 2.6.0

[Freeciv-Dev] [patch #4642] civ2civ3: happyborders disabled

Update of patch #4642 (project freeciv): Category:None => rulesets Status:None => Ready For Test Planned Release: => 2.5.0-beta1, 2.6.0

[Freeciv-Dev] [patch #4640] civ2civ3: sun tzu wonder fix

Update of patch #4640 (project freeciv): Category:None => rulesets Status:None => Ready For Test Planned Release: => 2.5.0-beta1, 2.6.0 _

[Freeciv-Dev] [patch #4646] civ2civ3: oneattack units

Update of patch #4646 (project freeciv): Category:None => rulesets Status:None => Ready For Test Planned Release: => 2.5.0-beta1, 2.6.0

[Freeciv-Dev] [patch #4643] Check goto sanity with pathfinding

Update of patch #4643 (project freeciv): Status:None => Ready For Test Assigned to:None => pepeto Planned Release: => 2.6.0 _

[Freeciv-Dev] [patch #4636] civ2civ3 rules: fixes

Follow-up Comment #3, patch #4636 (project freeciv): I keep this ticket for the fixes to bases: - Effects related to Bases were using the range "Tile" (that is wrong but was working without errors). Replaced by "Local". - Added regen HP effect for Airbases, else Helicopters can not "refuel" there

[Freeciv-Dev] [patch #4646] civ2civ3: oneattack units

URL: Summary: civ2civ3: oneattack units Project: Freeciv Submitted by: bardo Submitted on: sáb 05 abr 2014 14:48:29 UTC Category: None Priority: 5 - Normal Sta

[Freeciv-Dev] [bug #21893] Amplio2hexbig from modpack lacks two files

Follow-up Comment #2, bug #21893 (project freeciv): My fault, I didn't notice that kevin55I (anonymous) already reported the bug. ___ Reply to this item at:

[Freeciv-Dev] [patch #4608] civ2civ3 rules: added pre-fortress

Follow-up Comment #13, patch #4608 (project freeciv): I think the simpler solution to prevent workers from building fast fortresses when loaded on triremes is to forbid the construction of bases over rirvers. I also like the idea to give ZOC to triremes, I'll create a patch with both changes if y

[Freeciv-Dev] [patch #4643] Check goto sanity with pathfinding

Follow-up Comment #8, patch #4643 (project freeciv): Digging through, I think I like the pf_map_move_cost() based solution best. Updated patch attached. (file #20485) ___ Additional Item Attachment: File name: check-goto-sanity-with-map-m

[Freeciv-Dev] [patch #4636] civ2civ3 rules: fixes

Follow-up Comment #2, patch #4636 (project freeciv): Wait, let me do it properly. I'll split this patch in two: units and bases, and I'll add a new fix to the bases part (forbid bases on rivers). I expect to be the latest change that I submit for v2.5.

[Freeciv-Dev] [bug #21881] Wrong flags

Update of bug #21881 (project freeciv): Category: freeciv.org => rulesets Assigned to:None => mixcoatl ___ Reply to this item at:

[Freeciv-Dev] [bug #21881] Wrong flags

Follow-up Comment #1, bug #21881 (project freeciv): > Could you also tell me where can I add new countries, such as > Austria-Hungary, the Habsburg Empire, Hejaz, Tuscany, etc.? You can find the documentation to add new nations at http://freeciv.wikia.com/wiki/Nations If you want to contribute w

[Freeciv-Dev] [bug #21895] Match iterator initialisation and end statements

Follow-up Comment #2, bug #21895 (project freeciv): Patches for S2_4 and S2_5 attached. (file #20483, file #20484) ___ Additional Item Attachment: File name: update-map_move_cost_iterate-calls.S2_4.patch Size:1 KB File name: update-map_mov

[Freeciv-Dev] [patch #4643] Check goto sanity with pathfinding

Follow-up Comment #7, patch #4643 (project freeciv): Thanks. I'll review, and update the patch to be less redundant. For find_beachhead, there's that problem. Also, if the first tile *is* reachable, but the next tile in the iteration isn't, then the unreachable tile will be selected. _

[Freeciv-Dev] [bug #21895] Match iterator initialisation and end statements

Update of bug #21895 (project freeciv): Severity: 3 - Normal => 2 - Minor Priority: 5 - Normal => 3 - Low Status:None => Ready For Test Assigned to:

[Freeciv-Dev] [patch #4643] Check goto sanity with pathfinding

Follow-up Comment #6, patch #4643 (project freeciv): > The code is full of function pointers, so I'm sure I'm missing > something, but how and where is PF_IMPOSSIBLE_MOVE checked? I'm > happy to remove it, I just don't understand why I may. pf_map_move_cost(), pf_map_position() and pf_map_path()

[Freeciv-Dev] [bug #21895] Match iterator initialisation and end statements

URL: Summary: Match iterator initialisation and end statements Project: Freeciv Submitted by: persia Submitted on: Sat 05 Apr 2014 07:21:06 PM JST Category: ai Severity: 3 - Nor

[Freeciv-Dev] [bug #21894] Crash in is_my_zoc()

URL: Summary: Crash in is_my_zoc() Project: Freeciv Submitted by: pepeto Submitted on: sam. 05 avril 2014 12:15:08 CEST Category: general Severity: 4 - Important

[Freeciv-Dev] [patch #4643] Check goto sanity with pathfinding

Follow-up Comment #5, patch #4643 (project freeciv): The code is full of function pointers, so I'm sure I'm missing something, but how and where is PF_IMPOSSIBLE_MOVE checked? I'm happy to remove it, I just don't understand why I may. Looking for pf_map_move_cost(), I could only find two example

[Freeciv-Dev] [patch #4643] Check goto sanity with pathfinding

Follow-up Comment #4, patch #4643 (project freeciv): I think in your patch, testing checking "pos.total_MC != PF_IMPOSSIBLE_MOVE" is redundant. Checking the returned value of pf_map_position() already does that. In other place in the code (mainly in AI code), I tried to use the best function. So

[Freeciv-Dev] [bug #21875] Goto movement do not take into account roads with cost lower than igter

Follow-up Comment #7, bug #21875 (project freeciv): In that case, the patch from comment #4 is clearly superior. ___ Reply to this item at: ___ Message sent via/

[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries

Follow-up Comment #8, bug #21696 (project freeciv): this patch breaks all builds using system lua libraries (--enable-sys-lua); see the rpm builds at https://build.opensuse.org/project/monitor/home:syntron:freeciv ___ Reply to this item at:

[Freeciv-Dev] [bug #21875] Goto movement do not take into account roads with cost lower than igter

Follow-up Comment #6, bug #21875 (project freeciv): I think it can be better to have two lines. Else, the function map_move_cost() might be called twice because MIN() is a macro. ___ Reply to this item at: