[Freeciv-Dev] [patch #1962] Expand the commentary for RESULT_IS_KNOWN

2010-09-12 Thread James Spahlinger
URL: Summary: Expand the commentary for RESULT_IS_KNOWN Project: Freeciv Submitted by: nixeagle Submitted on: Monday 09/13/2010 at 00:14 Category: ai Priority: 1 - Later

[Freeciv-Dev] [patch #1936] limit the number of units a city can support

2010-09-12 Thread James Spahlinger
Follow-up Comment #13, patch #1936 (project freeciv): I was thinking trade after... well trade (routes) happened ;). That is still limited but has different dynamics then either pop limit or shield limit. Each city has a certain amount of trade, so the amount of resources that can _locally_ be us

[Freeciv-Dev] [patch #1948] Remove unit_att_rating_sq, replace only use with pow.

2010-09-10 Thread James Spahlinger
Follow-up Comment #1, patch #1948 (project freeciv): I ran M-x rgrep RET _sq( RET on the working directory and found that the vast majority of functions doing nothing but "squaring" something lie in aiunit.c. The one replacement with pow() does not exist in a loop and thus really should not be a

[Freeciv-Dev] [patch #1948] Remove unit_att_rating_sq, replace only use with pow.

2010-09-10 Thread James Spahlinger
URL: Summary: Remove unit_att_rating_sq, replace only use with pow. Project: Freeciv Submitted by: nixeagle Submitted on: Friday 09/10/2010 at 22:37 Category: ai Priority: 1 -

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-10 Thread James Spahlinger
Follow-up Comment #5, patch #1942 (project freeciv): Bah, the empty line had spaces in it, removed those 4 in this patch. I read that as "empty line". ;) (file #10296) ___ Additional Item Attachment: File name: 0004-refactor-first-portion

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-10 Thread James Spahlinger
Follow-up Comment #4, patch #1942 (project freeciv): Alright, new patch attached fixing comment header length to 77 chars. I copied from the header for ai_airlift which is 75. I left the empty line on line 127 as it separates the variable initialization for that block from the use of it. This f

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-09 Thread James Spahlinger
Follow-up Comment #2, patch #1942 (project freeciv): Thanks for the input, consistant style is important. Both are easy enough to fix. - I changed my emacs code template for C functions to have a new line before that '{' brace. No clue why I missed that detail, the rest of the functions follow i

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-08 Thread James Spahlinger
URL: Summary: refactor first portion of ai_airlift into find_neediest_airlift_city Project: Freeciv Submitted by: nixeagle Submitted on: Thursday 09/09/2010 at 03:58 Category: ai

[Freeciv-Dev] [patch #1936] limit the number of units a city can support

2010-09-07 Thread James Spahlinger
Follow-up Comment #7, patch #1936 (project freeciv): Just to add a little more on the trade idea: A well balanced game would treat gold(trade) upkeep very similar to shield upkeep. As the game stands it is not hard to have cities produce massive numbers of shields but very little trade. What limi

[Freeciv-Dev] [bug #16630] Copyleft notices for contributions

2010-09-07 Thread James Spahlinger
Follow-up Comment #1, bug #16630 (project freeciv): Any particular ones/examples? I looked at your link and from a quick glance they all seem to mention the GNU GPL, v2 or v3. Is there somewhere else the notices have to be? Or am I missing something (I'm very new to this project)? __

[Freeciv-Dev] [patch #1928] remove save_ppm and -P option

2010-09-06 Thread James Spahlinger
Follow-up Comment #1, patch #1928 (project freeciv): Why does this need removed? What is it being replaced with, or is the option simply no longer needed? If there has already been discussion, just poke me at it :). I don't object or anything like that, I'm just curious.

[Freeciv-Dev] [patch #1893] [metaticket] Help updates for 2.3.0

2010-09-06 Thread James Spahlinger
Follow-up Comment #5, patch #1893 (project freeciv): The word 'terraform' has been used to mean "changing land" in a few other games. Alpha Centauri is one I can think of off the top of my head. The word 'transform' goes more readily with "person changing". For example 'Transformers' the toy/fil

[Freeciv-Dev] Emacs configurations

2010-09-06 Thread James Spahlinger
is very "C" like). As emacs already supports C I'm hoping someone already did the project specific tweaks and I can just 'steal' them ;). In a day or two with luck I'll be getting my first patches on the patch tracker! :> -

[Freeciv-Dev] [patch #1936] limit the number of units a city can support

2010-09-06 Thread James Spahlinger
Follow-up Comment #3, patch #1936 (project freeciv): I don't know if this has been proposed or is currently done as I'm still new to both the game and the code. Instead of limiting the number of units a city can support under gold upkeep rules, perhaps limit what gold can be used for the unit up

[Freeciv-Dev] [bug #15628] server crashed.

2010-09-06 Thread James Spahlinger
Follow-up Comment #2, bug #15628 (project freeciv): I'm browsing through the bugs while I wait for my git clone of the svn repository to finish up (I'm up to r17852). This bug should probably be closed. It has been over 5 months since the request for more information. I doubt any is forthcoming.

[Freeciv-Dev] [bug #16623] netintf.c gcc warnings in net_lookup_service

2010-09-03 Thread James Spahlinger
URL: Summary: netintf.c gcc warnings in net_lookup_service Project: Freeciv Submitted by: nixeagle Submitted on: Friday 09/03/2010 at 20:48 Category: general Severity: 2 - Mino

[Freeciv-Dev] [bug #16614] nimiipuu.ruleset:

2010-09-02 Thread James Spahlinger
Follow-up Comment #1, bug #16614 (project freeciv): I'd love to change the title to what I originally intended but somehow forgot ;). If possible update it to: nimiipuu.ruleset: Missing end of i18n string marking ___ Reply to this item at

[Freeciv-Dev] [bug #16614] nimiipuu.ruleset:

2010-09-02 Thread James Spahlinger
URL: Summary: nimiipuu.ruleset: Project: Freeciv Submitted by: nixeagle Submitted on: Thursday 09/02/2010 at 13:35 Category: rulesets Severity: 2 - Minor Priori