[Freeciv-Dev] (PR#39922) BUG: keys operate units with map not in focus

2007-11-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39922 To replicate, try any report (such as F1) and then accidentally hit space or escape or any other unit command key. The action happens in the main map invisibly. ___ Freeciv-dev mailing list

Re: [Freeciv-Dev] (PR#39722) Change CMA by F1 panel don't work (gcc-4.2 specific bug)

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39722 Castanier Carl wrote: Yep. Optimisation -02 cause this problem. Too bad you didn't include this little detail in your original report. Too bad you didn't read the documentation on compiling: gcc 4.2.1 and 4.2.2 miscompile

Re: [Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39900 Christian Knoke wrote: No, I didn't. Which PR number? Your reply included the PR# in your second message, so we know you've previously seen it 'Update' is misleading. It's rather 'change'. But you also have 'change' in the

Re: [Freeciv-Dev] (PR#39879) bug with plane patrol

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39879 Thank you for the numerous savegames -- they say version 2.1.0. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39912) consistent UI - Chat - use apostrophe to select

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39912 Currently, the client uses Alt-C to open the _Chat tab. This potentially conflicts with many other menu items. Instead, most games use \' (AKA apostrophe, single quote, or prime) to begin a chat. Once selected, the focus should be in

Re: [Freeciv-Dev] (PR#39722) Change CMA by F1 panel don't work (gcc-4.2 specific bug)

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39722 Castanier Carl wrote: ... A program who miscompile is NOT cleanly written and I had make an effort to post patch to clean up this code. You can leave this patch as many others... The patch changes the order of the menu, and adds a

Re: [Freeciv-Dev] (PR#39879) bug with plane patrol

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39879 Michaël wrote: this crashed occured between sebvm 2 and sebvm 3, and two times (after reconnecting i tryed at once to do the same thing and the crash occured in this same way) I've looked at all the files, and French did

Re: [Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39900 Christian Knoke wrote: * S: (v) update (modernize or bring up to date) We updated the kitchen in the old house * S: (v) update (bring up to date; supply with recent information) * S: (v) update (bring to the latest state

Re: [Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39900 Erik Johansson wrote: Are there tools available for this, Not that I'm aware of. ... or guidelines, http://developer.gnome.org/projects/gup/hig/ http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/

Re: [Freeciv-Dev] (PR#39913) consistent UI - Government should be Edit

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39913 This also fixes the bug that the editor main menu was improperly disabled sometimes. HIG [page 43] explicitly says: Do not disable menu titles. Allow the user to explore the menu, even though there might be no available items on

Re: [Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39900 Jason Dorje Short wrote: Neither update nor change is synonymous with opening a popup window. Nor are any of the other synonyms. In fact, nothing is updated or changed when the button is pressed. (heavy sigh) Someday, somebody

Re: [Freeciv-Dev] (PR#39917) Diplomacy model bug: War as default relation for (previously) uncontacted allies of allies

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39917 Welcome back. I agree, war is a bad default state. And it was a fairly recent change, so the rest of the code doesn't work well. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

Re: [Freeciv-Dev] (PR#39913) consistent UI - Government should be Edit

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39913 Daniel Markstedt wrote: How about something like Council or Throne Room or Assembly etc. Please give suggestions! Civ2 used Kingdom. Anyway, it's a bad idea. Everything related to editing should be under the Edit menu. Please

Re: [Freeciv-Dev] (PR#39913) consistent UI - Government should be Edit

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39913 William Allen Simpson wrote: I will change Gover_nment to Gov_ernment, so gui-gtk2 matches gui-win32, to eliminate the conflict with other _n's. No po changes. Committed S2_1 revision 14083. Index: client/gui-gtk-2.0/menu.c

Re: [Freeciv-Dev] (PR#39900) _Update button in city report to _Inspect

2007-11-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39900 Daniel Markstedt wrote: Instead I propose Inspect, as an analogy of you as the leader personally visiting the city to inspect it. Good idea; I'll do that tomorrow, after checking for conflicts. Will need something else for _Update

Re: [Freeciv-Dev] (PR#39866) Tracking 2.1.1 release

2007-11-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39866 Daniel Markstedt wrote: What is the x11 client? gui-xaw. Yes, yes, I know that GTK and SDL can use x11, but Project Athena widgets are the native interface ___ Freeciv-dev mailing

Re: [Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39900 Daniel Markstedt wrote: I thought we agreed that only clearly broken strings in S_1 were to be touched... Go back and read the report. The old _Popup interfered with other _P. Also, this was the only place in the code that a

Re: [Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39901 William Allen Simpson wrote: Is this a Fedora only kind of thing? So, I did a bit of Googling, and there are a number of other reports about Fedora and this new requirement As a long-time BSD contributor, one of the things

[Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39901 Please use the email interface, your comments were not sent to the list. Not really, it's more of a security thing. Quote from one of our kernel guys: The problem is that without a mode being passed, the kernel uses whatever the

Re: [Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39900 There must be a language barrier here, or you didn't read the relevant problem report. (1) The buttons (in this dialog) are phrased as a desired user action. Select, Display, Update, etc. (2) The user doesn't want to Open the city,

Re: [Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39895 Per I. Mathisen wrote: The patch that introduced it did not mention it, and none of the references to it that I could find, in the code and in your patch, said anything about what it was or what it was supposed to do. It is quite

[Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39895 During the lull preparing 2.1.1 -- this won't interfere with that. Committed S2_2 revision 14054. Committed trunk revision 14055. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

Re: [Freeciv-Dev] (PR#39541) [Bug] Unit help claims that only spy can investigate cities

2007-11-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39541 The fuzzy process correctly caught the spy text change, but the diplomat was too different. Hand built the fuzzy translations. Committed S2_1 revision 14056. Index: po/cs.po

[Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39895 OK, great. Because the issue (borders appearing under foreign cities) was originally reported against 2.1, I made some extra effort to design for both 2.1 and 2.2. But there's more freedom with 2.2-only. The borders do expand

Re: [Freeciv-Dev] (PR#39900) _Update button in city report

2007-11-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39900 Just renamed from Popup (PR#23078). Nobody complained (or otherwise commented) during the standard review period There's another similar button elsewhere named Update City. Would that be better here? Probably the original authors

Re: [Freeciv-Dev] (PR#39901) Patch: Fix permission on open() call

2007-11-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39901 open() with O_CREAT in its second argument needs to have a third argument That's not accurate. Only when you wish to restrict the file mode mask. Without looking hard at this code, I don't see any reason we'd want to restrict the

Re: [Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39895 Per I. Mathisen wrote: What is VISION_SITE_RUIN? The value I reserved (several patches ago) for the civ3-like ruin left behind after a city is destroyed. It will be displayed per player, just like other non-owned cities. Whether you

Re: [Freeciv-Dev] (PR#39883) Gtk2 client tends to flake out after a while

2007-11-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39883 Sadly, there are quite a few memory leaks in 2.1. I'd fixed one in the goto code just the other week. But I've fixed at least a dozen only in 2.2/trunk. Fixing the iterators and such was deemed too disruptive for 2.1.

Re: [Freeciv-Dev] (PR#39887) Australian housing style should be EU

2007-11-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39887 Daniel is our de facto nation coordinator, and we await his decision. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39866) Tracking 2.1.1 release

2007-11-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39866 Thought I'd report that the x11 client still compiles and runs. Unfortunately, I don't seem to remember how to get it running a game How are the other clients? ___ Freeciv-dev mailing

[Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39895 After a fair amount of testing, here's my initial re-design of the border code. I left much of the old code in place (#ifdef OWNER_SOURCE) for comparison. As you can see (or I can supply screen shots), for a game in progress the code

[Freeciv-Dev] (PR#39723) Typo in server/settings.c

2007-11-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39723 Daniel, do we want these for 2.1? I committed them to 2.2 long ago, but never got feedback on whether you wanted them for 2.1 ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#39725) Various typos in client, remove log translation

2007-11-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39725 Committed S2_1 revision 14019, revised from S2_2 -- does not make most changes in keys, but propagating one simple key fix. As committed: Index: po/cs.po === --- po/cs.po

Re: [Freeciv-Dev] (PR#23078) 2.1.0 (F1) City (F3) Player - (Alt-H) S_how conflicts with _Help

2007-11-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=23078 Committed S2_1 revision 14016, with po updates. Committed S2_2 revision 14017. Committed trunk revision 14018. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

Re: [Freeciv-Dev] (PR#39895) deterministic borders (part 1)

2007-11-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39895 I think you attached the wrong patch. Sigh, that's what happens with too many branch windows open at the same time (Sorry, that was the patch I was committing in S2_1.) Index: server/citytools.c

Re: [Freeciv-Dev] (PR#39838) Dollar symbol

2007-11-21 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39838 Jason Short wrote: It should be easy enough to find a free SVG dollar sign... We had a dollar sign, we don't want a dollar sign, we want something international Please re-read the entire ticket. The new graphic looks good,

Re: [Freeciv-Dev] (PR#39875) default theme scroll bar thumbs are hard to see

2007-11-21 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39875 No, from being too close on gray color to the scroll bar itself. Did you try turning on scroll bars? ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#23078) 2.1.0 (F1) City (F3) Player - (Alt-H) S_how conflicts with _Help

2007-11-21 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=23078 Since this seems to be a moment to fix text in 2.1, this is an easy one. Changing those sub-menus to _List would actually make some sense, as these manage the columns in the listings. Also, looking at gui-gtk-2.0/menu.c, there's a

Re: [Freeciv-Dev] (PR#23078) 2.1.0 (F1) City (F3) Player - (Alt-H) S_how conflicts with _Help

2007-11-21 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=23078 William Allen Simpson wrote: Changing those sub-menus to _List would actually make some sense, as these manage the columns in the listings. Hard to tell, but it seems that _List would conflict with _Last, although I've not been able

[Freeciv-Dev] (PR#39881) GTK2 (F2) Unit (Alt-N) _Nearest conflicts with Gover_nment

2007-11-21 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39881 As mentioned in PR#23078, somebody in the not too distant past tried to change main menu _Edit to _Government, then Gover_nment (gtk2) and Gov_ernment (win32). Obviously, 'G' and 'O' and 'V' are already taken on the main menu. In

Re: [Freeciv-Dev] (PR#39541) [Bug] Unit help claims that only spy can investigate cities

2007-11-20 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39541 Daniel Markstedt wrote: Do diplomats behave differently in civ1/civ2 rulesets than in default? Not as far as I can tell (looked at 2.1). Is designated the initial explorer in civ1, but that's not a feature in traditional game.

[Freeciv-Dev] (PR#39875) default theme scroll bar thumbs are hard to see

2007-11-20 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39875 $subject ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39748) elephant help text

2007-11-20 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39748 Erik Johansson wrote: Elephants are towering animals trained for war and powerful shock troops, but have bad defense against all units. Elephants are towering animals trained for war that are often used as powerful shock troops, but

[Freeciv-Dev] (PR#16162) 2.1.0b1: help call crashes civclient

2007-11-20 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=16162 I cannot reproduce. The messages say there is a backtrace attached, but nothing in RT. Anybody? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39445) 2.1.0b4-gtk2 (Slackware) Help/Technology resizing

2007-11-20 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39445 I cannot reproduce. Running 2.1.0 on MacOS 10.3.9, the default window size is nearly perfect, and the window itself resizes. Anybody? ___ Freeciv-dev mailing list Freeciv-dev@gna.org

Re: [Freeciv-Dev] (PR#39876) fix soft restart; load game freelog translation; re-order early load

2007-11-20 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39876 Committed S2_1 revision 13993. Found S2_1 patch in PR#15609, ported for S2_2. Committed S2_2 revision 13994. Committed trunk revision 13995. Index: server/srv_main.c

[Freeciv-Dev] (PR#15854) goto.c:860: Assertion `unit_is_in_focus(punit)' failed

2007-11-19 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=15854 Still awaiting verification about one of the problems reported in this (improperly) merged report: Is anybody having problems when a turn timeout occurs while a user is mapping a goto?

[Freeciv-Dev] (PR#39801) harmonize goto_map_list with focus_units

2007-11-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39801 But not yet verified and deployed in a release, so I'm reopening it. It's part of a series of related tickets. Closing other developers' tickets is terribly impolite. I'm keeping my own tickets open to verify. What you do with

Re: [Freeciv-Dev] (PR#39869) last used ruleset should be saved as user pref

2007-11-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39869 This is also part and parcel of PR#39579. The server keeps sending completely unrequested and unrelated rulesets before an action has been initiated. There's no good reason that the tilespec is being loaded, or anything else, until the

Re: [Freeciv-Dev] (PR#39818) 2.1.0 multiple bugs from same savegame, plus suggestions

2007-11-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39818 Daniel Markstedt wrote: The crash caused by this bug is resolved, but the city still stayed behind when I last tested. See #39830 As he would have known had he actually read the thread and its children. Stolen back.

Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 I have verified that a unit sentried and then moved does not lose focus. The report accurately describes the problem. I have not yet found the problem. Unfortunately, there seem to be several methods used for every test, and for every

Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 Jason Dorje Short wrote: This was introduced in 39817. I've been over and over my code in PR#39817 today. I don't see the problem. Apparently, it needs more eyeballs. I'll leave this to Jason.

Re: [Freeciv-Dev] (PR#39868) unit woken up from sentry not properly deselected

2007-11-16 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 Daniel Markstedt wrote: Not necessarily. It may also be something that has ceased to work as intended, regardless of having been previously reported as a bug or not. Sorry, perhaps you're not a native English speaker (although I've

Re: [Freeciv-Dev] (PR#39868) unit woken up from sentry not properly deselected

2007-11-16 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 Daniel Markstedt wrote: Also, I'm pretty sure this is a regression between 2.1.0 and S2_1-devel. A regression is the re-introduction of a previously existing bug. What bug is that? Actually, this is probably an old bug uncovered by

Re: [Freeciv-Dev] (PR#39852) BUG: path finding incorrect air destination calculations

2007-11-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39852 After looking at airgoto code some more, found (more than one) function on the server side that looks for an airbase. Copied part here. Essentially no change for AI. The user can run the aircraft any direction for 1/2 move, *and*

Re: [Freeciv-Dev] (PR#39852) BUG: path finding incorrect air destination calculations

2007-11-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39852 Committed S2_2 revision 13959. Committed trunk revision 13960. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#20772) Bug: Air goto attack on unit or city not possible

2007-11-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=20772 I have tested the excellent savegame provided by Fernando, and the AWACS moves with either G or cursors. Aircraft can attack cities and units. As to the patches proposed, after a cursory examination, the first didn't even begin to

[Freeciv-Dev] (PR#20759) Crash on box select + mass goto

2007-11-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=20759 I have not been able to reproduce this problem with 2.1.0. Could somebody please verify, or provide a savegame that crashes? ___ Freeciv-dev mailing list Freeciv-dev@gna.org

Re: [Freeciv-Dev] (PR#39864) helicopter goto overly cautious

2007-11-14 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39864 Remember, a week ago this code didn't work at all As with anything else, you can move helicopters in 1/2 increments anywhere you like with waypoints. That seems to fill your expectation. Daniel Markstedt wrote: ... Certainly out

Re: [Freeciv-Dev] (PR#39865) goto into peaceful territory falsely labeled as possible

2007-11-14 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39865 Too complicated and hard to know in advance. Are you going to have an alliance next turn? Is your alliance dissolved at the end of this turn? Goto stops all the time. That's what it's designed to do. At some point, this has to be a

Re: [Freeciv-Dev] (PR#39858) middle click for terrain info on unexplored territory causes crash

2007-11-14 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39858 Jason Short wrote: This patch fixes text.c to give a better info text. Not popping up the window at all is also a solution but I see no problem with showing some descriptive unknown-tile text either. Perhaps, but not for 2.1 --

Re: [Freeciv-Dev] (PR#39859) Sliders in governor menu do not work

2007-11-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39859 Daniel Markstedt wrote: You're right - this is a regression between 2.1.0-rc1 and 2.1.0. Is this release 2.1.0? Or current source? What client? I looked at all the S2_1 commits between Oct 17 and Oct 27, and all I see are gui-sdl

Re: [Freeciv-Dev] (PR#39852) BUG: path finding incorrect air destination calculations

2007-11-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39852 I'm using MacOS 10.3.9, standard iso Amplio (shouldn't make a difference), and standard GTK2 (shouldn't make a difference). We are talking about a fighter to the S of the continent, in the middle of the ocean. It has moves (7)7.

Re: [Freeciv-Dev] (PR#39852) BUG: path finding incorrect air destination calculations

2007-11-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39852 Pepeto _ wrote: - It ignores if unit hasn't its full moves left. For example, if your unit already did some move this turn, it check as your unit didn't make this moves. Amazingly, you are actually correct. I tried moving the

Re: [Freeciv-Dev] (PR#39861) scrollbar on side and top doesnt work

2007-11-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39861 Daniel Markstedt wrote: - GTK fullscreen: OFF (to make PR#12119 less aggrevating) It seems to be off here, I always have to click the green plus for fullscreen. You don't? - Server setting 'aitoggle' OFF (workaround for PR#22082)

Re: [Freeciv-Dev] (PR#39852) BUG: path finding incorrect air destination calculations

2007-11-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39852 Forgot to mention, I also discovered that you could locate unseen units in the field by using goto to detect attack points. So, I added some checking to stop the cheat. ___ Freeciv-dev

Re: [Freeciv-Dev] (PR#13739) savegame can't be loaded (illegal activity transported_by fields)

2007-11-12 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=13739 There are some checks for this kind of thing in 2.2, with the new(ish) unit, terrain, movement class stuff, but I've not noticed anything in 2.1. ___ Freeciv-dev mailing list

Re: [Freeciv-Dev] (PR#39852) BUG: path finding incorrect air destination calculations

2007-11-12 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39852 Pepeto _ wrote: and say me that this stealth fighter can move to P1 and not go to dangerous positions. Verified. The stealth fighter, currently in the middle of the ocean, with 7/7 remaining, is unable to go to any dangerous

Re: [Freeciv-Dev] (PR#39852) BUG: path finding incorrect air destination calculations

2007-11-12 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39852 Committed S2_1 revision 13941. Committed S2_2 revision 13942. Committed trunk revision 13943. The slightly different S2_2/trunk patch for posterity: Index: common/aicore/pf_tools.c

Re: [Freeciv-Dev] (PR#39852) BUG: path finding incorrect air destination calculations

2007-11-11 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39852 Pepeto _ wrote: I think when you will get all this, you will conclude on a quite identical patch than PR#20772. The rejected patch(es) in PR#20772 did not address the underlying problem that this patch corrects. Those patches

Re: [Freeciv-Dev] (PR#39850) Huts cause crash on 1st turn of second game

2007-11-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39850 Brings back memories. My very first report was about hitting a hut on the first turn Long since fixed. Please send your crash dump, and both savegames via email attachment. ___

[Freeciv-Dev] (PR#39851) mystrcasestr

2007-11-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39851 As a side effect of the reported problems compiling strcasestr on debian (PR#39849), discussion led to a replacement for systems without it. This implements a replacement. See patch in parent (PR#39849).

Re: [Freeciv-Dev] (PR#39851) mystrcasestr

2007-11-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39851 Committed trunk revision 13939. Committed S2_2 revision 13940. With the minor change (alphabetized): Index: configure.ac === --- configure.ac(revision 13930) +++

[Freeciv-Dev] (PR#15854) goto.c:860: Assertion `unit_is_in_focus(punit)' failed

2007-11-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=15854 I'd reopened this because it was a quick hack that didn't address the underlying problems. Worse, Pepeto combined 3 reports of different problems that all had this same symptom. Now, I've added an urgent queue for sentries

Re: [Freeciv-Dev] (PR#39845) RFE: deterministic borders and vision

2007-11-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39845 Eddie Anderson wrote: That part was OK. I thought that I could fix that problem by moving one of my units onto that tile (to enforce my claim to it). That works in commercial civ. It's the natural expectation. This

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39831 Joan Creus wrote: For land units, except Diplomats and Spies: * Will be built as a veteran in cities with appropriate training facilities (see Barracks and Sun Tzu.) May also become veteran if it defeats an enemy unit. In this

Re: [Freeciv-Dev] (PR#39848) SDL client city_owner() compile error

2007-11-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39848 Jason Dorje Short wrote: If I'm not mistaken the city_owner field was removed a few days ago. No, it is a long-time existing access function. The problem here is that my (PR#39841) string search and replace was confused by the

Re: [Freeciv-Dev] (PR#39845) RFE: deterministic borders and vision

2007-11-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39845 Jason Dorje Short wrote: A triple-loop is also rather tedious (possibly too slow with a very large number of old cities in the game). A simpler loop is possible if we make border assignment context-based and impose the restraint

Re: [Freeciv-Dev] (PR#39845) RFE: deterministic borders and vision

2007-11-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39845 Randy Kramer wrote: If this is a step toward making freeciv more civ3-ish, I'd like to request that a means be kept to continue to have civ1 and civ2 like play. That's part of the idea. The current code is not parameterized.

Re: [Freeciv-Dev] (PR#39845) RFE: deterministic borders and vision

2007-11-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39845 Egor Vyscrebentsov wrote: Maybe there can be other iterator than city, say border_sources_iterator. (where border_source is union, for example.) [I understand that this has its own contras.] I've not been sufficiently clear. The

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39849 Jason Dorje Short wrote: Naive is fine but you forgot to add the check to configure.ac. Attached patch does that. I didn't forget; that ensured my new code was compiled and tested ... Yet it is clearly present in the

Re: [Freeciv-Dev] (PR#39844) Re: Freeciv not working in Mac OS X 1.5 (Leopard)

2007-11-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39844 Can this be moved to general? Done. Sadly, a number of things broke with Leopard. Another example is that libsdl won't compile with any QuickTime 7.0.3 -- and we're up to 7.3! Such things are out of our control, but this can track

Re: [Freeciv-Dev] (PR#39841) Cleanup city, unit, and tile accessor functions for *_owner (and others)

2007-11-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39841 Committed S2_1 revision 13925. Committed S2_2 revision 13926. Committed trunk revision 13927. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39840) Re: 2.2/trunk changing production doesn't work

2007-11-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39840 Daniel Markstedt wrote: If you want to be credited as bug reporter, please sign your reports. =) Heck -- if you want the reports to be seen, please sign your reports. Otherwise, they are automatically classed as junk. I try to clear

Re: [Freeciv-Dev] (PR#39817) goto interrupted by sentry

2007-11-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39817 Apparently, I forgot to attach the patch Here's S2_2 at the current revision: Index: client/control.c === --- client/control.c(revision 13927) +++ client/control.c

Re: [Freeciv-Dev] (PR#39845) RFE: deterministic borders and vision

2007-11-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39845 Per I. Mathisen wrote: I would suggest that you hunt down some of the old discussions and read them before embarking on this. There are lots of constraints involved here, and I may not remember them all. Thank you, as part of my

Re: [Freeciv-Dev] (PR#39840) 2.2/trunk changing production doesn`t work becouse of unwanted return

2007-11-07 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39840 wrote: This transaction appears to have no content Really need more explanation. And there's something wrong with the From: -- how did you submit this report? ___ Freeciv-dev mailing

Re: [Freeciv-Dev] (PR#39840) 2.2/trunk changing production doesn't work

2007-11-07 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39840 Looking at the code around your tiny patch, the return is very *much* wanted. Otherwise, you'd try to add a bad entry to the worklist. But, when I added error logging in PR#39827, I accidentally inserted the return one line too low.

Re: [Freeciv-Dev] (PR#39830) 2.1.0 border expansion acquires destroyed city

2007-11-06 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39830 William Allen Simpson wrote: Anyway, this shows my solution is on the right track. The tile will point to the dummy for owner information; they will always be the same. Sadly, unless I'm able to think of some other method

Re: [Freeciv-Dev] (PR#39830) 2.1.0 border expansion acquires destroyed city

2007-11-05 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39830 Per Inge Mathisen wrote: But why is this a problem? The vision code and the border code should not interact at all in the current design. And that, my friend, is the root of the problem. As the border expands, the vision isn't

Re: [Freeciv-Dev] (PR#39838) Dollar symbol

2007-11-05 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39838 He might mean the tax specialist. Here, as I click, it goes white smiley, flask, '$'... Should be a gold coin, instead. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#39835) BUG: 2.2.0-test fix PR#39562 and PR#39565

2007-11-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39835 Another problem found with PR#39562, this time on its stated purpose, better choice asserts. The assert() itself tests both = CT_NONE and != CT_NONE -- the previous version had commented out != CT_NONE. The assert() also doesn't use

[Freeciv-Dev] (PR#39835) BUG: 2.2.0-test fix PR#39562 and PR#39565

2007-11-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39835 Committed S2_2 revision 13914. Committed trunk revision 13915. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39565) NULL instead of valid impr_type in punittype-need_improvement

2007-11-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39565 As explained in PR#39385, this is exactly the kind of bug that PR#39553 was intended to catch. The old code didn't check for a valid improvement before using it. The fix was much easier than removing the useful log, or writing this

Re: [Freeciv-Dev] (PR#39830) 2.1.0 border expansion acquires destroyed city

2007-11-04 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39830 Per I. Mathisen wrote: If you are thinking about the distinction between server view of the world, and client views of the world (both contained within the server), then yes, these view may be radically different due to fog of war.

[Freeciv-Dev] (PR#39830) 2.1.0 border expansion acquires destroyed city

2007-11-02 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39830 Making a child of the original multi-bug report. See that report for the very useful samegames. Per, I need help understanding this one. Is there a reason that border expansion doesn't include vision expansion? That's not intuitive,

Re: [Freeciv-Dev] (PR#39818) 2.1.0 crash shared vision in send_tile_info()

2007-11-01 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39818 verified in S2_1 current Thread 0 Crashed: 0 civserver 0x0001c904 send_tile_info + 0x1a4 (maphand.c:495) 1 civserver 0x0001e838 really_give_tile_info_from_player_to_player + 0xfc (maphand.c:1093) 2 civserver 0x0001e99c

Re: [Freeciv-Dev] (PR#39818) Reproducable Crash on Freeciv-2.1.0-gtk2

2007-11-01 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39818 Daniel Markstedt wrote: Guest login fixed again for now. Please verify. verified. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39818) Reproducable Crash on Freeciv-2.1.0-gtk2

2007-10-31 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39818 Christoph Petschnig wrote: thanks for doing this great job!!! Btw, http://rt.freeciv.org/index.html won't let me login as 'guest' with the shown password 'viceerf'. Just verified that's broken, again Reproduce the bug:

Re: [Freeciv-Dev] (PR#39801) harmonize goto_map_list with focus_units

2007-10-30 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39801 Committed trunk revision 13899. Committed S2_2 revision 13900. Committed S2_1 revision 13901. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

<    1   2   3   4   5   6   7   >