Re: [Freeciv-Dev] (PR#39693) [Patch] Unit info label for impossible goto

2007-09-14 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39693 > On 10/09/2007, William Allen Simpson wrote: > > I used the existing infinity and existing "Turns to target: %d", just to > avoid making new translations. If that's not acceptable, and it's OK to > add a new translation, then "Unreachable" wo

Re: [Freeciv-Dev] (PR#39693) [Patch] Unit info label for impossible goto

2007-09-10 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39693 > Daniel Markstedt wrote: > It's IMHO ok to add new translatable strings while implementing new > functionality. What should be avoided is making minor adjustments to > existing ones. > Wasn't new functionality, was a 2.1 bug fix. But OK, I'l

Re: [Freeciv-Dev] (PR#39693) [Patch] Unit info label for impossible goto

2007-09-09 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39693 > On 9/10/07, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39693 > > > No, that's not the best fix. You shouldn't test the destination before > testing whether a goto is active. The !goto

Re: [Freeciv-Dev] (PR#39693) [Patch] Unit info label for impossible goto

2007-09-09 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39693 > No, that's not the best fix. You shouldn't test the destination before testing whether a goto is active. The !goto_get_turns does both. I used the existing infinity and existing "Turns to target: %d", just to avoid making new translations.

[Freeciv-Dev] (PR#39693) [Patch] Unit info label for impossible goto

2007-09-08 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39693 > Currently unit info label lists "Turns to target" with very large value (FC_INFINITY) when goto hover is over impossible destination (such as Sea tile for Land unit). This also causes widget resizes. I first found this bug as 'earthquake' e