Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-05 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40075 > On Feb 5, 2008 5:58 AM, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=40075 > > > Michael Kaufman wrote: > > On Mon, Feb 04, 2008 at 07:49:58PM -0800, Jason Dorje Short wrote: > >> ... W

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-05 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40075 > Michael Kaufman wrote: > On Mon, Feb 04, 2008 at 07:49:58PM -0800, Jason Dorje Short wrote: >> ... Why not just use the ptile->index as the city id? ... > > ... > without knowing the tile location that the city sits on (the capital city?)

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-04 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40075 > Building another city in the same place after the first one was destroyed should cause that to happen. In that case you'd have to either update the client to tell it the new city ID or (more likely) delete the old dummy city and then add the

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-04 Thread Michael Kaufman
http://bugs.freeciv.org/Ticket/Display.html?id=40075 > On Mon, Feb 04, 2008 at 07:49:58PM -0800, Jason Dorje Short wrote: > > Incidentally, is there a reason that pcity->id uses the idex > generator? Why not just use the ptile->index as the city id? Cities > can't ever move and there can't eve

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40075 > William Allen Simpson wrote: > ==12774== Address 0x5391ca0 is 0 bytes inside a block of size 76 free'd > ==12774==at 0x402365C: free (vg_replace_malloc.c:323) > ==12774==by 0x80E6669: reality_check_city (citytools.c:1792) > >

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40075 > Jason Dorje Short wrote: > I got this with chris's recent savegame but I have no idea if it's > related. Attached is the previous savegame; no clue if it's reproducable. > It helps pinpoint one of the potential problems from PR#40068 & PR#

Re: [Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-04 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40075 > The following apparently also shows up every turn (unnoticed because of the other server spam): 1: Failed sanitycheck.c:174 (srv_main.c:1852) at Plains (34,20): map_get_player_site(ptile, tile_owner(ptile)) != NULL _

[Freeciv-Dev] (PR#40075) S2_2 memory error in map_get_player_city

2008-02-04 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40075 > I got this with chris's recent savegame but I have no idea if it's related. Attached is the previous savegame; no clue if it's reproducable. ==12774== Invalid read of size 4 ==12774==at 0x80F3978: map_get_player_city (maphand.c:1206) =